[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414485#comment-15414485
]
Gary Gregory commented on LOG4J2-1501:
--
My plan from now on is to create missing builders when
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414324#comment-15414324
]
Remko Popma commented on LOG4J2-1501:
-
Strictly speaking this isn't the API module so I see the
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412449#comment-15412449
]
Gary Gregory commented on LOG4J2-1501:
--
So we can drop deprecated methods like
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412394#comment-15412394
]
Matt Sicker commented on LOG4J2-1501:
-
I don't want to convert them all to builders as it's rather
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412389#comment-15412389
]
Ralph Goers commented on LOG4J2-1501:
-
I will take a peek as soon as I can.
> FileAppender should be
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412388#comment-15412388
]
Ralph Goers commented on LOG4J2-1501:
-
I haven't had a chance to read the documentation that Matt put
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412385#comment-15412385
]
Ralph Goers commented on LOG4J2-1501:
-
There is no need for backward compatibility.
> FileAppender
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412316#comment-15412316
]
Gary Gregory commented on LOG4J2-1501:
--
I added a build (see [LOG4J2-1505]) and removed the new
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412189#comment-15412189
]
Matt Sicker commented on LOG4J2-1501:
-
I don't like completely deprecating {{@PluginFactory}} because
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412180#comment-15412180
]
Gary Gregory commented on LOG4J2-1501:
--
Let rephrase, should we deprecate {{@PluginFactory}} in
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412175#comment-15412175
]
Matt Sicker commented on LOG4J2-1501:
-
The old factories are kept for BC. Also, to deprecate and say
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412164#comment-15412164
]
Gary Gregory commented on LOG4J2-1501:
--
When I look at the ConsoleAppender it has both a builder AND
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412156#comment-15412156
]
Gary Gregory commented on LOG4J2-1501:
--
Because it is less work for me ATM.
Is there a way to
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412150#comment-15412150
]
Gary Gregory commented on LOG4J2-1501:
--
I did not want to just update the {{createAppender}} API
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412080#comment-15412080
]
Matt Sicker commented on LOG4J2-1501:
-
Hence why I suggest adding a builder.
> FileAppender should
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412056#comment-15412056
]
Ralph Goers commented on LOG4J2-1501:
-
Please explain why you deprecated the existing createAppender
[
https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412025#comment-15412025
]
Matt Sicker commented on LOG4J2-1501:
-
One point of review: why bother adding another huge factory
17 matches
Mail list logo