[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-09-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456182#comment-15456182 ] Gary Gregory commented on LOG4J2-1539: -- I just deleted the Git branch since I merged

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439418#comment-15439418 ] Gary Gregory commented on LOG4J2-1539: -- Checkpoint: Both sub tasks are completed: [L

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-23 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434126#comment-15434126 ] Gary Gregory commented on LOG4J2-1539: -- OK, good. I attached a patch for the first s

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-23 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433984#comment-15433984 ] Ralph Goers commented on LOG4J2-1539: - Yes, and the would be the preferred way to imp

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-23 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433809#comment-15433809 ] Gary Gregory commented on LOG4J2-1539: -- Looking at this last night I realized that i

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-22 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431980#comment-15431980 ] Matt Sicker commented on LOG4J2-1539: - LoggerContext(s) is/are owned by the ContextSe

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431972#comment-15431972 ] Gary Gregory commented on LOG4J2-1539: -- OK, but my question is where does the Logger

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-22 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431956#comment-15431956 ] Matt Sicker commented on LOG4J2-1539: - {{Builder}} is used by more than just plugin b

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431954#comment-15431954 ] Gary Gregory commented on LOG4J2-1539: -- Hm... should the AbstractConfiguration hold

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431942#comment-15431942 ] Gary Gregory commented on LOG4J2-1539: -- OK, understood. Is there a type of change yo

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-22 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431923#comment-15431923 ] Ralph Goers commented on LOG4J2-1539: - Yes. As I said, I am afraid getContext() might

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431918#comment-15431918 ] Gary Gregory commented on LOG4J2-1539: -- I created [LOG4J2-1540] to track the LoggerC

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-22 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431898#comment-15431898 ] Ralph Goers commented on LOG4J2-1539: - As soon as you need the LoggerContext in the M

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431879#comment-15431879 ] Gary Gregory commented on LOG4J2-1539: -- {quote} Actually, I dislike the currentConte

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431878#comment-15431878 ] Gary Gregory commented on LOG4J2-1539: -- Hi Ralph, Thank you for your review. I pla

[jira] [Commented] (LOG4J2-1539) Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)

2016-08-22 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431822#comment-15431822 ] Ralph Goers commented on LOG4J2-1539: - I dislike the patch because of the call to Log