[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892437#comment-15892437
]
Matt Sicker commented on LOG4J2-1820:
-
There's a good wiki page about this over on the Commons wiki
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892426#comment-15892426
]
Jason Tedor commented on LOG4J2-1820:
-
Thank you for providing all of this information [~jvz]. I hope
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891636#comment-15891636
]
Matt Sicker commented on LOG4J2-1820:
-
There are two main ways to properly merge a PR from GitHub
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891505#comment-15891505
]
Gary Gregory commented on LOG4J2-1820:
--
The bottom line is that we use GitHub as a read-only mirror
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891482#comment-15891482
]
Jason Tedor commented on LOG4J2-1820:
-
We discussed on LOG4J2-1563 that this should not be attributed
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891172#comment-15891172
]
Gary Gregory commented on LOG4J2-1820:
--
Yes, I just got the patch from the URL, copied it to the
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891164#comment-15891164
]
Matt Sicker commented on LOG4J2-1820:
-
We accept PRs, but we can't just click the button in GitHub to
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891116#comment-15891116
]
Jason Tedor commented on LOG4J2-1820:
-
The metadata is applied properly with {{git am}}:
{code}
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891095#comment-15891095
]
Matt Sicker commented on LOG4J2-1820:
-
It's easier to apply that properly as a pull request. Since
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891041#comment-15891041
]
Jason Tedor commented on LOG4J2-1820:
-
Thank you for your help here, and pulling in this patch.
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891028#comment-15891028
]
ASF subversion and git services commented on LOG4J2-1820:
-
Commit
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889131#comment-15889131
]
Jason Tedor commented on LOG4J2-1820:
-
Would someone be able to take a look at the latest patch and
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883635#comment-15883635
]
Jason Tedor commented on LOG4J2-1820:
-
It is indeed due to JDK 7 where AES/GCM/NoPadding is only
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883585#comment-15883585
]
Jason Tedor commented on LOG4J2-1820:
-
I suspect that that is due to the use of JDK 7. Let me see if
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883407#comment-15883407
]
Gary Gregory commented on LOG4J2-1820:
--
When I apply the patch I get this failure:
Tests in error:
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879919#comment-15879919
]
Matt Sicker commented on LOG4J2-1820:
-
The patch is fine, yes. We can take a closer look at broader
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879767#comment-15879767
]
Gary Gregory commented on LOG4J2-1820:
--
[~jvz]: Do you feel we have consensus that [~jasontedor]'s
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879104#comment-15879104
]
Jason Tedor commented on LOG4J2-1820:
-
I have seen no evidence that any of the other calls are
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877473#comment-15877473
]
Matt Sicker commented on LOG4J2-1820:
-
There appears to be a possibly useful method in
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877466#comment-15877466
]
Matt Sicker commented on LOG4J2-1820:
-
The use of {{ClassLoader.getParent()}} also requires a
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877459#comment-15877459
]
Gary Gregory commented on LOG4J2-1820:
--
More generally, how can we parameterize the unit tests to
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877457#comment-15877457
]
Gary Gregory commented on LOG4J2-1820:
--
Hi All,
It seems that we do not need to worry about cases
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877454#comment-15877454
]
Matt Sicker commented on LOG4J2-1820:
-
Ok, I looked into the JDK7 source code for more details since
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877437#comment-15877437
]
Matt Sicker commented on LOG4J2-1820:
-
There's a check in LoaderUtil for the getClassLoader
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877426#comment-15877426
]
Gary Gregory commented on LOG4J2-1820:
--
What about the other 31 call sites we have to
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877396#comment-15877396
]
Jason Tedor commented on LOG4J2-1820:
-
Yes.
{code}
[INFO] Reactor Summary:
[INFO]
[INFO] Apache
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877130#comment-15877130
]
Gary Gregory commented on LOG4J2-1820:
--
I'll try to take a look tonight, Does a full build pass?
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876449#comment-15876449
]
Remko Popma commented on LOG4J2-1820:
-
Hi Jason, I'm traveling and may not get around to looking at
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876283#comment-15876283
]
Jason Tedor commented on LOG4J2-1820:
-
Would someone be able to take a look at this patch and offer
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872628#comment-15872628
]
Jason Tedor commented on LOG4J2-1820:
-
I also took this opportunity to simplify the test case that I
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872625#comment-15872625
]
Jason Tedor commented on LOG4J2-1820:
-
I also took this opportunity to simplify the test case that I
[
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872619#comment-15872619
]
Jason Tedor commented on LOG4J2-1820:
-
I also took this opportunity to simplify the test case that I
32 matches
Mail list logo
