[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729206#comment-14729206
]
Gary Gregory commented on LOG4J2-952:
-
Sounds good. Any thoughts on getting LOG4J2-108
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728618#comment-14728618
]
Remko Popma commented on LOG4J2-952:
Go for it. I think we are all happy to merge this
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728514#comment-14728514
]
Ralph Goers commented on LOG4J2-952:
I've updated the branch from master, but I am sur
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726362#comment-14726362
]
Gary Gregory commented on LOG4J2-952:
-
I've reviewed and updated the code as much as I
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724831#comment-14724831
]
Gary Gregory commented on LOG4J2-952:
-
I think am done with the bulk of my changes for
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724123#comment-14724123
]
Ralph Goers commented on LOG4J2-952:
I don't know that that optimization buys much sin
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724109#comment-14724109
]
Gary Gregory commented on LOG4J2-952:
-
In
{{org.apache.logging.log4j.core.config.prop
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724105#comment-14724105
]
Gary Gregory commented on LOG4J2-952:
-
Committed to the branch.
> FAQ: How do I confi
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723875#comment-14723875
]
Ralph Goers commented on LOG4J2-952:
Yes. I forgot to do that.
> FAQ: How do I config
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723845#comment-14723845
]
Gary Gregory commented on LOG4J2-952:
-
I can see the forest for the trees better and b
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721694#comment-14721694
]
Ralph Goers commented on LOG4J2-952:
I have:
1. Modified Lifecycle to support and INIT
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721648#comment-14721648
]
Gary Gregory commented on LOG4J2-952:
-
Yes, the branch looks good but I feel like it n
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721643#comment-14721643
]
Bart S. commented on LOG4J2-952:
I think I'm just going to fork or "subclass" the thing. I
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721641#comment-14721641
]
Bart S. commented on LOG4J2-952:
Better.
> FAQ: How do I configure log4j2 programmaticall
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721640#comment-14721640
]
Bart S. commented on LOG4J2-952:
I don't think you should hold on to what a "builder" is.
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721636#comment-14721636
]
Ralph Goers commented on LOG4J2-952:
Yes, that is correct - although AbstractConfigura
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721635#comment-14721635
]
Bart S. commented on LOG4J2-952:
That's what I've been saying. It's a form of a Specificat
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721629#comment-14721629
]
Bart S. commented on LOG4J2-952:
I think you are correct though. Separating it into two pa
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721628#comment-14721628
]
Bart S. commented on LOG4J2-952:
It would still be Wise to change the error message from E
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721627#comment-14721627
]
Gary Gregory commented on LOG4J2-952:
-
Thank you for clarifying that again, it helps a
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721619#comment-14721619
]
Gary Gregory commented on LOG4J2-952:
-
OK then, if it is clearer to you and you've spe
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721615#comment-14721615
]
Ralph Goers commented on LOG4J2-952:
There is a huge difference between what a builder
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721613#comment-14721613
]
Ralph Goers commented on LOG4J2-952:
I think it is much more clear having them in sepa
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721611#comment-14721611
]
Ralph Goers commented on LOG4J2-952:
After writing the unit test for Configurator now
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721606#comment-14721606
]
Gary Gregory commented on LOG4J2-952:
-
{quote}
As I said previously, I didn't use "Bui
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721604#comment-14721604
]
Gary Gregory commented on LOG4J2-952:
-
{quote}
7. I think there is an error in your st
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721602#comment-14721602
]
Gary Gregory commented on LOG4J2-952:
-
{quote}
So I have no idea at this point if chan
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721600#comment-14721600
]
Gary Gregory commented on LOG4J2-952:
-
{quote}
To avoid that you MUST use a Configurat
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721519#comment-14721519
]
Remko Popma commented on LOG4J2-952:
Branch looks good to me.
> FAQ: How do I configu
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721372#comment-14721372
]
Ralph Goers commented on LOG4J2-952:
I made most of the changes you requested and chec
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720649#comment-14720649
]
Ralph Goers commented on LOG4J2-952:
Sure. I can create a branch for this. I should ha
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720604#comment-14720604
]
Gary Gregory commented on LOG4J2-952:
-
How about putting the patch in a branch so we c
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720067#comment-14720067
]
Gary Gregory commented on LOG4J2-952:
-
TL;DR except I saw the reference to [LOG4j2-109
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718649#comment-14718649
]
Bart S. commented on LOG4J2-952:
And you're also causing me to take time off my day becaus
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718629#comment-14718629
]
Bart S. commented on LOG4J2-952:
You have an issue with actually thinking about something.
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718553#comment-14718553
]
Ralph Goers commented on LOG4J2-952:
Bart, Jira is not an email system for you to docu
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718315#comment-14718315
]
Bart S. commented on LOG4J2-952:
Pff. Confusing, everything. I think the assembler solutio
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718118#comment-14718118
]
Ralph Goers commented on LOG4J2-952:
Wow your update is long!
1. I have shown two way
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718085#comment-14718085
]
Gary Gregory commented on LOG4J2-952:
-
Ralph,
Nice work!
Great stuff!
Here are my no
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717996#comment-14717996
]
Ralph Goers commented on LOG4J2-952:
Thanks. I will wait for feedback from Gary. If he
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717987#comment-14717987
]
Remko Popma commented on LOG4J2-952:
Reviewed patch 4. This looks very nice. A lot of
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712554#comment-14712554
]
Ralph Goers commented on LOG4J2-952:
The hope is that using addComponent allows you to
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711195#comment-14711195
]
Remko Popma commented on LOG4J2-952:
Finally had a chance to look at the patch. I like
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709192#comment-14709192
]
Ralph Goers commented on LOG4J2-952:
The log4j1 file contains class names for appender
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708881#comment-14708881
]
Gary Gregory commented on LOG4J2-952:
-
Have a different a properties file format than
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708864#comment-14708864
]
Ralph Goers commented on LOG4J2-952:
No, it is not in a branch. You should be able to
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708860#comment-14708860
]
Remko Popma commented on LOG4J2-952:
Ralph, is this in a branch? I'd like to play with
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703737#comment-14703737
]
Gary Gregory commented on LOG4J2-952:
-
Especially easy if you use Jackson.
> FAQ: How
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703738#comment-14703738
]
Gary Gregory commented on LOG4J2-952:
-
Especially easy if you use Jackson.
> FAQ: How
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703355#comment-14703355
]
Ralph Goers commented on LOG4J2-952:
Converting the Assembly into XML or JSON should b
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703290#comment-14703290
]
Gary Gregory commented on LOG4J2-952:
-
It would be neat to be able to transmit a confi
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702957#comment-14702957
]
Bart S. commented on LOG4J2-952:
Is there a reason the "getFilterAssembler()" (for instanc
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702530#comment-14702530
]
Ralph Goers commented on LOG4J2-952:
Although I would prefer it in the API I am not re
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702043#comment-14702043
]
Gary Gregory commented on LOG4J2-952:
-
Would this belong in the log4j-api or core modu
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701344#comment-14701344
]
Bart S. commented on LOG4J2-952:
Let's say the difference is that {{getAssembler()}} means
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701319#comment-14701319
]
Bart S. commented on LOG4J2-952:
That is like really verbose! Oeph!.
But I get the idea.
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701318#comment-14701318
]
Ralph Goers commented on LOG4J2-952:
Behrooz - Nothing has been finished yet. I poste
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701308#comment-14701308
]
Behrooz Nobakht commented on LOG4J2-952:
I would kindly need a confirmation, pleas
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701287#comment-14701287
]
Ralph Goers commented on LOG4J2-952:
I am working on a configuration builder that look
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700088#comment-14700088
]
Bart S. commented on LOG4J2-952:
Please also check
[LOG4J2-1095|https://issues.apache.org
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699575#comment-14699575
]
Ralph Goers commented on LOG4J2-952:
Just so you are aware, I have started working on
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699550#comment-14699550
]
Behrooz Nobakht commented on LOG4J2-952:
Thank you Bart and Mikael for your commen
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695452#comment-14695452
]
Bart S. commented on LOG4J2-952:
It's weird anyway that {{getConfiguration(ConfigurationSo
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695431#comment-14695431
]
Mikael Ståldal commented on LOG4J2-952:
---
BTW, we could make the XML literal approach
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695411#comment-14695411
]
Bart S. commented on LOG4J2-952:
{quote}Forcing compile time dependency on the log4j-core
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695397#comment-14695397
]
Bart S. commented on LOG4J2-952:
{quote}
Having some extra imports is not a big deal since
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695382#comment-14695382
]
Bart S. commented on LOG4J2-952:
By the way, the next-prettiest interface API I can think
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695358#comment-14695358
]
Mikael Ståldal commented on LOG4J2-952:
---
Having some extra imports is not a big deal
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695342#comment-14695342
]
Bart S. commented on LOG4J2-952:
A typical builder paradigm is that there is a fixed _Cont
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695325#comment-14695325
]
Mikael Ståldal commented on LOG4J2-952:
---
I don't understand what the disadvantage wi
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695305#comment-14695305
]
Bart S. commented on LOG4J2-952:
Well, because you have to change the implementation for t
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695279#comment-14695279
]
Mikael Ståldal commented on LOG4J2-952:
---
But if we can make it report more errors at
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695261#comment-14695261
]
Ralph Goers commented on LOG4J2-952:
Configuration from files in Log4j is a two step p
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695243#comment-14695243
]
Mikael Ståldal commented on LOG4J2-952:
---
My code was only meant to be an example, de
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695195#comment-14695195
]
Bart S. commented on LOG4J2-952:
The problem is that it would no longer be a builder (not
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694867#comment-14694867
]
Mikael Ståldal commented on LOG4J2-952:
---
I can see a problem with this, a simple spe
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694184#comment-14694184
]
Bart S. commented on LOG4J2-952:
You could have an API like:
addAppender("name", TYPE, pa
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694048#comment-14694048
]
Bart S. commented on LOG4J2-952:
I was writing before all of your comments (the last 3, by
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694029#comment-14694029
]
Gary Gregory commented on LOG4J2-952:
-
Are we talking about using a Log4j 1 prop file
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694027#comment-14694027
]
Gary Gregory commented on LOG4J2-952:
-
Yep, your right on the busy part. :-) I am sorr
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694006#comment-14694006
]
Behrooz Nobakht commented on LOG4J2-952:
Hi Ralph, thanks for taking a look on the
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693969#comment-14693969
]
Ralph Goers commented on LOG4J2-952:
Behrooz - I really like what you have done so far
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693950#comment-14693950
]
Behrooz Nobakht commented on LOG4J2-952:
I've been hitting the same requirement an
[
https://issues.apache.org/jira/browse/LOG4J2-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693918#comment-14693918
]
Bart S. commented on LOG4J2-952:
You'd still have a configuration file, just not on disk.
84 matches
Mail list logo
