Re: Close Input Stream in Configuration factory?

2016-08-21 Thread Mikael Ståldal
Ok, fixed. On Aug 21, 2016 12:40 PM, "Mikael Ståldal" wrote: > Is a ConfigurationFactory that uses the InputStream from the > ConfigurationSource supposed to close the stream when done? It seems like > XmlConfigurationFactory, JsonConfigurationFactory and > YamlConfigurationFactory do close the

Re: Close Input Stream in Configuration factory?

2016-08-21 Thread Ralph Goers
Almost certainly. Sent from my iPad > On Aug 21, 2016, at 3:40 AM, Mikael Ståldal wrote: > > Is a ConfigurationFactory that uses the InputStream from the > ConfigurationSource supposed to close the stream when done? It seems like > XmlConfigurationFactory, JsonConfigurationFactory and > Yaml

Re: Close Input Stream in Configuration factory?

2016-08-21 Thread Remko Popma
Sounds like an oversight. I can't think of any reason why closing the InputStream would be correct for some ConfigFactories but incorrect for PropertiesConfigurationFactory. Closing it should be fine. Sent from my iPhone > On 2016/08/21, at 19:40, Mikael Ståldal wrote: > > Is a Configuratio

Close Input Stream in Configuration factory?

2016-08-21 Thread Mikael Ståldal
Is a ConfigurationFactory that uses the InputStream from the ConfigurationSource supposed to close the stream when done? It seems like XmlConfigurationFactory, JsonConfigurationFactory and YamlConfigurationFactory do close the stream. But PropertiesConfigurationFactory does not. Should it?