Hi,
--- Ceki Gülcü <[EMAIL PROTECTED]> wrote:
> You mean because of the duplication or because you prefer Digester?
Because of the duplication. Joran is nice because it's lightweight and simple,
but Digester is more mature and better tested. I'm never a big fan of
duplication, but I realize in
At 09:15 PM 12/7/2004, you wrote:
Hi,
Yup, makes sense. I looked at the example actions and the ones in
log4j/joran/action. I kept thinking how nice it'd be if Digester didn't have
any dependencies ;)
You mean because of the duplication or because you prefer Digester?
Yoav
--
Ceki Gülcü
The comp
Hi,
Yup, makes sense. I looked at the example actions and the ones in
log4j/joran/action. I kept thinking how nice it'd be if Digester didn't have
any dependencies ;)
Yoav
--- Ceki Gülcü <[EMAIL PROTECTED]> wrote:
> At 09:03 PM 12/7/2004, Yoav Shapira wrote:
>
> >Why must Joran actions have a
At 09:03 PM 12/7/2004, Yoav Shapira wrote:
Why must Joran actions have a logger per instance, out of curiosity?
Well, it is preferable to have the logs go the repository being
currently configured. If log4j.jar is in common/lib, an Action's
static Logger will be loaded once. Consequently, that stat
Hi,
Yeah, the changes are fine. I'll do them in a bit.
Why must Joran actions have a logger per instance, out of curiosity?
Yoav Shapira http://www.yoavshapira.com
--- Ceki Gülcü <[EMAIL PROTECTED]> wrote:
> Yoav,
>
> Very nicely done. Thanks.
>
> Two small comments though. First, Actions MU
Yoav,
Very nicely done. Thanks.
Two small comments though. First, Actions MUST have a logger per
instance, not a static one.
So, for example,
if(getNamingContext() != null) {
LOGGER.warn("Overwriting existing naming context.");
}
should be written as
if(getNamingContext() != null) {
g
RE: JNDISubstitution [was: LogLog Conversion: duplicate effort]
>
>At 02:41 PM 11/24/2004, Shapira, Yoav wrote:
>
>>Hi,
>>I'm sorry, I didn't read the original message. I'm not sure why, I must
>>have deleted it accidentally. I do want to familiarize mys
At 02:41 PM 11/24/2004, Shapira, Yoav wrote:
Hi,
I'm sorry, I didn't read the original message. I'm not sure why, I must
have deleted it accidentally. I do want to familiarize myself with
JoranConfigurator, so please hold off on doing this JNDI substitution
thing yourself for a couple of days.
;t have hurt, either ;)
Happy thanksgiving to everyone,
Yoav Shapira http://www.yoavshapira.com
>-Original Message-
>From: Ceki Gülcü [mailto:[EMAIL PROTECTED]
>Sent: Wednesday, November 24, 2004 6:07 AM
>To: Log4J Developers List
>Subject: Re: JNDISubstitution [was:
than no one ;)
Yoav Shapira http://www.yoavshapira.com
>-Original Message-
>From: Paul Smith [mailto:[EMAIL PROTECTED]
>Sent: Monday, November 22, 2004 3:52 PM
>To: Log4J Developers List
>Subject: Re: LogLog Conversion: duplicate effort
>
>No problems at all, I only sp
ter to have everyone doing work
than no one ;)
Yoav Shapira http://www.yoavshapira.com
>-Original Message-
>From: Paul Smith [mailto:[EMAIL PROTECTED]
>Sent: Monday, November 22, 2004 3:52 PM
>To: Log4J Developers List
>Subject: Re: LogLog Conversion: duplicate effort
>
>No
ad of just going ahead. But
hey, it's better to have everyone doing work than no one ;)
Yoav Shapira http://www.yoavshapira.com
>-Original Message-
>From: Paul Smith [mailto:[EMAIL PROTECTED]
>Sent: Monday, November 22, 2004 3:52 PM
>To: Log4J Developers List
>Subje
No problems at all, I only spent 20 minutes or so to be honest. I had
some changes done on Friday (not committed) but thought I'd wait till I
read your response about one of my other postings before finalising it.
I will go ahead and just take a fresh copy of the files from CVS, and
see what e
Hi Paul,
Given that the changes are quite mechanical, I just went through them,
especially because of the pressing need to verify that the unit tests
continued to run successfully. At this time, I suggest that you override
your local changes as they should be more as identical to mine.
BTW, did
Ceki I appear to have a bunch of cvs conflicts from your recent
commits. It appears that you have been working through the same areas I
have! (.net package in particular).
Are you happy with the state of affairs in those areas, and should I
just override my locally modified versions with your
15 matches
Mail list logo
