Re: Fwd: logging-log4j2 git commit: LOG4J-1762 Add Builder to GelfLayout

2017-01-08 Thread Matt Sicker
I'd only add null checks or annotations in the builder for things that are actually required by the plugin. As for the configuration, if you need one but don't get one injected, you can fall back to using a new DefaultConfiguration(), but that would only be useful in unit tests I think (the PluginB

Re: Fwd: logging-log4j2 git commit: LOG4J-1762 Add Builder to GelfLayout

2017-01-08 Thread Mikael Ståldal
Do I need to check if configuration is null? What to do if it is? On Jan 7, 2017 10:33 PM, "Matt Sicker" wrote: > What do you mean? > > On 7 January 2017 at 15:03, Mikael Ståldal > wrote: > >> No fields are mandatory (any more). However, I added protection against >> additional fields being nul

Re: Fwd: logging-log4j2 git commit: LOG4J-1762 Add Builder to GelfLayout

2017-01-07 Thread Matt Sicker
What do you mean? On 7 January 2017 at 15:03, Mikael Ståldal wrote: > No fields are mandatory (any more). However, I added protection against > additional fields being null. > > What about configuration from AbstractLayout.Builder? > > On Jan 4, 2017 2:55 AM, "Matt Sicker" wrote: > >> You're mi

Re: Fwd: logging-log4j2 git commit: LOG4J-1762 Add Builder to GelfLayout

2017-01-07 Thread Mikael Ståldal
No fields are mandatory (any more). However, I added protection against additional fields being null. What about configuration from AbstractLayout.Builder? On Jan 4, 2017 2:55 AM, "Matt Sicker" wrote: > You're missing a @Required on the mandatory field(s) (or a null check in > the build method)