Re: Splitting off NoSQL to its own module.

2014-05-05 Thread Ralph Goers
If your intention is to contribute it to the ASF then check out log4j2 and add the new classes into the NoSQL project. If you are intending to keep it for yourself then create a standalone project that has dependencies on log4j-nosql, log4j-core and log4j-api and make sure you are using package

Re: Splitting off NoSQL to its own module.

2014-05-05 Thread Ralph Goers
If you are trying to add something to the log4j nosql package then it should be part of that project, not a separate project. Ralph On May 5, 2014, at 9:49 AM, lo...@markus-klose.de wrote: > Do I understand the process right? At compile time of log4j-nosql all nosql > based appender must be k

Re: Splitting off NoSQL to its own module.

2014-05-05 Thread Matt Sicker
You just need log4j-core as a dependency when you compile. By default, it will invoke the plugin processor to generate that .dat file. On 5 May 2014 11:49, lo...@markus-klose.de wrote: > Do I understand the process right? At compile time of log4j-nosql all > nosql based appender must be known?

Re: Splitting off NoSQL to its own module.

2014-05-05 Thread Ralph Goers
Do you have the new nosql jar in your classpath? Ralph On May 5, 2014, at 8:15 AM, Markus Klose wrote: > Hi, > > since you moved the nosql appender into a separate module some of my other > test are failing. > > I have a test that reads a log4j.xml, getting a specific logger and getting

Re: Splitting off NoSQL to its own module.

2014-05-05 Thread Matt Sicker
You are adding log4j-nosql to your deployment or classpath, right? When log4j-nosql is compiled, the Log4j2plugins.dat file is created by an annotation processor. In a typical environment, the classpath is scanned for all the resource files with the correct name and path. Are you getting any releva

Re: Splitting off NoSQL to its own module.

2014-05-05 Thread Markus Klose
Hi, since you moved the nosql appender into a separate module some of my other test are failing. I have a test that reads a log4j.xml, getting a specific logger and getting all appenders of that specific logger. but now this test does not have any (nosql) appender anymore in my output i have se

Re: Splitting off NoSQL to its own module.

2014-05-04 Thread Matt Sicker
Good point. I'm renaming it to org.apache.logging.log4j.nosql.appender. Committed in r1592377. On 4 May 2014 03:07, Markus Klose wrote: > does it makes sense to refactorr the package wihtin the module > "log4-nosql" as well > > actually the package is still "org.apache.logging.log4j.core.ap

Re: Splitting off NoSQL to its own module.

2014-05-04 Thread Markus Klose
does it makes sense to refactorr the package wihtin the module "log4-nosql" as well actually the package is still "org.apache.logging.log4j.core.appender" but its not core anymore Markus > Matt Sicker hat am 29. April 2014 um 00:49 geschrieben: > > After some basic discussion about this, I'