Re: github

I’m not trying to merge anything at this point. I am only trying to indicate that I have reviewed the code and am OK to have it committed. I have now found how to do that. Thanks! Ralph > On Jan 18, 2017, at 9:45 AM, Stefan Bodewig wrote: > > Sorry for the comment from the outside. > > Acce

Re: github

Thank you! That was exactly what I was looking for. Ralph > On Jan 18, 2017, at 9:43 AM, Mikael Ståldal wrote: > > It should be possible to accept the PR without making any comment. Just go do > the "Files changed" tab, click on "Review change" (upper-right) and choose > "Approve". > > On

Re: github

Sorry for the comment from the outside. Accepting a PR is only a matter of merging the commits or using something like "git am" on a file you create from the PR by appending .patch - e.g. https://github.com/apache/logging-log4j2/pull/53.patch If you do so, this will not close the PR, though. You

Re: github

It should be possible to accept the PR without making any comment. Just go do the "Files changed" tab, click on "Review change" (upper-right) and choose "Approve". On Wed, Jan 18, 2017 at 5:36 PM, Ralph Goers wrote: > So I can't accept the PR unless I have made at least one comment? > > Ralph >

Re: github

So I can't accept the PR unless I have made at least one comment? Ralph > On Jan 18, 2017, at 9:08 AM, Matt Sicker wrote: > > The commit count statistics have always been a silly function of GitHub. See > for example . > > As for reviewing PRs, you just

Re: github

The commit count statistics have always been a silly function of GitHub. See for example . As for reviewing PRs, you just click a line to add a comment, and it offers to start a review or just add a single comment at a time. It should let you do it; anyone ca

Re: github

Yes, I have an account and yes I am a member of the org. I also have my username specified at Id.apache.org. Ralph > On Jan 17, 2017, at 11:03 PM, Gary Gregory wrote: > > The repo is read-only, so it's only useful for people who like GitHub instead > of svn and who do not have commit rights t

Re: github

The repo is read-only, so it's only useful for people who like GitHub instead of svn and who do not have commit rights to our project. There is an issue with Apache and GitHub where if I look at my Travis CI page -- which I connected to my GitHub account -- I do not see myself in Travis CI's site,

Re: Github integration set up: logging--log4j-boot.git

It appears that this repository has been successfully deleted now. On 10 January 2017 at 20:30, Gary Gregory wrote: > That repo name is not right :-( > > G > > -- Forwarded message -- > From: > Date: Tue, Jan 10, 2017 at 6:30 PM > Subject: Github integration set up: logging--log

Re: Github integration set up: logging--log4j-boot.git

Yeah, that's a duplicate anyhow. The correctly named one is where I've added a few files. On 10 January 2017 at 20:30, Gary Gregory wrote: > That repo name is not right :-( > > G > > -- Forwarded message -- > From: > Date: Tue, Jan 10, 2017 at 6:30 PM > Subject: Github integrati

Re: GitHub pull requests

Someone should have a look at this Pull Request: https://github.com/apache/logging-log4j2/pull/41 I am not sure if it makes sense or not. On Tue, Aug 30, 2016 at 7:10 PM, Mikael Ståldal wrote: > Done. > > On Sun, Aug 28, 2016 at 12:20 PM, Remko Popma > wrote: > >> +1 Good idea! >> >> On Sun, A

Re: GitHub pull requests

Done. On Sun, Aug 28, 2016 at 12:20 PM, Remko Popma wrote: > +1 Good idea! > > On Sun, Aug 28, 2016 at 7:12 PM, Mikael Ståldal > wrote: > >> I think that some people find the project on GitHub, and they might not >> be aware about our JIRA. Should we mention this in the README.md that is >> vis

Re: GitHub pull requests

+1 Good idea! On Sun, Aug 28, 2016 at 7:12 PM, Mikael Ståldal wrote: > I think that some people find the project on GitHub, and they might not be > aware about our JIRA. Should we mention this in the README.md that is > visible on GitHub? > > On Aug 27, 2016 2:30 PM, "Mikael Ståldal" > wrote: >

Re: GitHub pull requests

I think that some people find the project on GitHub, and they might not be aware about our JIRA. Should we mention this in the README.md that is visible on GitHub? On Aug 27, 2016 2:30 PM, "Mikael Ståldal" wrote: > Does anyone keep track of incoming pull requests on GitHub? It seems like > we ge

Re: GitHub pull requests

If you go here: https://issues.apache.org/jira/secure/ManageFilters.jspa You can see there's a "Shared With" column. In theory, we can make a filter public, but I can't find how. On 27 August 2016 at 11:26, Gary Gregory wrote: > Jira has a SQL like query language... and you can save queries. B

Re: GitHub pull requests

Jira has a SQL like query language... and you can save queries. But that might be per user. Gary On Aug 27, 2016 8:39 AM, "Ralph Goers" wrote: > Yes, every patch needs a Jira issue. > > To be honest, I’d really like a tool that could tell us all the Jira > issues that have patches and all the o

Re: GitHub pull requests

Yes, every patch needs a Jira issue. To be honest, I’d really like a tool that could tell us all the Jira issues that have patches and all the outstanding pull requests. I am sure there are commands or queries that could do both of these things but I don’t remember exactly how to do them. It

Re: [GitHub] commons-lang pull request: StrSubstitutor can preserve escapes

I don't see how it can hurt. Ralph > On Feb 25, 2016, at 7:00 PM, Gary Gregory wrote: > > Just FYI, is that something we can use? > > Should we port again? > > Gary > -- Forwarded message -- > From: samuelkarp > Date: Thu, Feb 25, 2016 at 5:07 PM > Subject: [GitHub] commons-l

Re: GitHub out of sync or did we miss a step in the release?

I like having tags being immutable because we have a record of what we voted on, pass or fail. Gary On Fri, Jan 8, 2016 at 6:17 PM, Matt Sicker wrote: > Thanks! Until they let us change tags in git again, I guess this process > would make most sense. > > On 8 January 2016 at 19:32, Gary Gregory

Re: GitHub out of sync or did we miss a step in the release?

Thanks! Until they let us change tags in git again, I guess this process would make most sense. On 8 January 2016 at 19:32, Gary Gregory wrote: > I pushed a 2.5 tag based on the commit for the 2.5-rc1 tag. > > Gary > > On Fri, Jan 8, 2016 at 12:50 PM, Matt Sicker wrote: > >> That would make sen

Re: GitHub out of sync or did we miss a step in the release?

I pushed a 2.5 tag based on the commit for the 2.5-rc1 tag. Gary On Fri, Jan 8, 2016 at 12:50 PM, Matt Sicker wrote: > That would make sense. > > On 8 January 2016 at 14:40, Gary Gregory wrote: > >> Then shouldn't we simply copy the 2.5-rc1 tag to 2.5? >> >> Gary >> >> On Fri, Jan 8, 2016 at 1

Re: GitHub out of sync or did we miss a step in the release?

That would make sense. On 8 January 2016 at 14:40, Gary Gregory wrote: > Then shouldn't we simply copy the 2.5-rc1 tag to 2.5? > > Gary > > On Fri, Jan 8, 2016 at 12:34 PM, Ralph Goers > wrote: > >> I missed creating a 2.5 tag from the 2.5-rc1 tag. 2.5-rc1 is the actual >> release. In the past

Re: GitHub out of sync or did we miss a step in the release?

Then shouldn't we simply copy the 2.5-rc1 tag to 2.5? Gary On Fri, Jan 8, 2016 at 12:34 PM, Ralph Goers wrote: > I missed creating a 2.5 tag from the 2.5-rc1 tag. 2.5-rc1 is the actual > release. In the past I created the tag as 2.5 and then deleted it if the > release failed. We aren’t allowed

Re: GitHub out of sync or did we miss a step in the release?

I missed creating a 2.5 tag from the 2.5-rc1 tag. 2.5-rc1 is the actual release. In the past I created the tag as 2.5 and then deleted it if the release failed. We aren’t allowed to do that any more. Ralph > On Jan 8, 2016, at 1:15 PM, Gary Gregory wrote: > > Hi All: > > When I look here: ht

Re: github is tracking the wrong branch as default

On 2014-10-12, Remko Popma wrote: > Wow! That branch is like two years old... Right. It takes an INFRA ticket to fix it but I felt it might be better if the ticket came from a member of the team. Stefan - To unsubscribe, e-mai

Re: github is tracking the wrong branch as default

Wow! That branch is like two years old... Sent from my iPhone > On 2014/10/12, at 18:33, Stefan Bodewig wrote: > > Hi all > > while trying to pull some information together for an internal log4j2 > talk I realized github uses 2.0-beta1 as the default branch which is > what PRs would be based a