Re: logging-log4j2 git commit: FastConsoleAppender

2016-06-04 Thread Matt Sicker
Added documentation to the "Extending Log4j" page. Let me know if you have any more questions about it. On 26 May 2016 at 16:23, Matt Sicker wrote: > Is there any place the factory method version is documented? I could add > the info there. Otherwise, I'll have to figure out an appropriate place

Re: logging-log4j2 git commit: FastConsoleAppender

2016-05-26 Thread Matt Sicker
Is there any place the factory method version is documented? I could add the info there. Otherwise, I'll have to figure out an appropriate place for it (perhaps in the manual). On 26 May 2016 at 13:35, Matt Sicker wrote: > Sure. I can't believe I forgot to document that better. > > On 26 May 201

Re: logging-log4j2 git commit: FastConsoleAppender

2016-05-26 Thread Matt Sicker
Sure. I can't believe I forgot to document that better. On 26 May 2016 at 12:06, Ralph Goers wrote: > Can you provide documentation on using the builder? I tried to implement > something a few months ago using a builder and couldn’t quite figure it all > out so I went back to using a factory. >

Re: logging-log4j2 git commit: FastConsoleAppender

2016-05-26 Thread Ralph Goers
Can you provide documentation on using the builder? I tried to implement something a few months ago using a builder and couldn’t quite figure it all out so I went back to using a factory. Ralph > On May 26, 2016, at 8:31 AM, Matt Sicker wrote: > > I prefer builders when you have more than 2

Re: logging-log4j2 git commit: FastConsoleAppender

2016-05-26 Thread Matt Sicker
I prefer builders when you have more than 2 arguments to the factory. This is based on Item 2 from Effective Java (prefer builders for constructors that take a lot of arguments). On 26 May 2016 at 10:24, Mikael Ståldal wrote: > Which one of builder and factory is preferred? > > On Thu, May 26, 2

Re: logging-log4j2 git commit: FastConsoleAppender

2016-05-26 Thread Mikael Ståldal
Which one of builder and factory is preferred? On Thu, May 26, 2016 at 5:22 PM, Matt Sicker wrote: > Just FYI, if you make a plugin builder, you don't need to make a plugin > factory as well. The builder is used first if available followed by the > factory method. Classes that have both are main