https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
grobmeier changed:
What|Removed |Added
CC||[email protected]
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #15 from Ralph Goers 2011-10-21
13:51:52 UTC ---
I modified BurstFilter in 2.0 as you suggested.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: --
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #14 from John Vasileff 2011-10-03 22:25:21 UTC ---
Ralph, I believe the bug fix for #1 is either as shown in comment 12 (nanos
first) or comment 10 (use float for rate). Items #2 and #3 are just ideas.
I'm not sure it makes se
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #13 from Ralph Goers 2011-10-03
20:12:36 UTC ---
John, I encourage you to open a separate Jira issue for Log4J 2 and submit a
patch with how you'd like this to work and enhance the unit test as well.
Bugzilla really is for Log4
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #12 from John Vasileff 2011-10-03 17:53:02 UTC ---
I took a look at BurstFilter and have a few thoughts:
1) The calculation of burstInterval loses precision. Better may be to store
burstIntervalNanos with something like:
this
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #11 from Ralph Goers 2011-10-03
02:16:01 UTC ---
I agree and have made the suggested changes. If the max is left off it defaults
to 10 times the rate.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #10 from John Vasileff 2011-10-03 00:57:30 UTC ---
I wonder if it would be easier for end users if the configuration was made with
rate instead of burstInterval:
float rate; // average number of log statements allowed per secon
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #9 from Ralph Goers 2011-10-02
19:52:01 UTC ---
If you've looked at the code you will see that it is using a DelayQueue to
control how many log entries can be written. From what I could tell in looking
at your code your bucket
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #8 from Chad LaVigne 2011-10-02 17:42:04
UTC ---
Thank you for adding this, I thought my contribution might be a lost cause. So
it looks like this is basically the same filter except that you no longer
define the fill amount, i
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #7 from Chad LaVigne 2011-10-02 17:34:16
UTC ---
Hi Ralph,
The unit test should work, although it's a little hard to read the results. You
should see 100 of 110 info log statements print with the first test, then
there's a sec
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #6 from Ralph Goers 2011-10-02
07:26:37 UTC ---
I implemented a BurstFilter that behaves a bit differently that yours to the
Log4j 2.0 experimental branch. It will behave a bit differently than yours in
that it only needs the
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #5 from Ralph Goers 2011-10-02
02:33:15 UTC ---
I tried adding this to my Log4j 2.0 branch but am having some problems. It
isn't passing the unit test. It seems to me that when the filter is called it
does nothing until fillInt
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #4 from Chad LaVigne 2011-09-30 18:40:29
UTC ---
I opened this issue quite a while ago and never received feedback after making
the changes initially requested. I've found this filter useful on quite a few
projects and each tim
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #3 from Chad LaVigne 2009-04-01 11:42:05
PST ---
Is there any feedback on this contribution?
(In reply to comment #2)
> Created an attachment (id=23401)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23401) [d
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #2 from Chad LaVigne 2009-03-23 14:56:31
PST ---
Created an attachment (id=23401)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23401)
Update to BurstFilter contribution
The attached code addresses the follow
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
Curt Arnold changed:
What|Removed |Added
Summary|Code contribution |Code contribution
rn value of getToken is confusing and will update it.
--- On Thu, 10/9/08, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
From: [EMAIL PROTECTED] <[EMAIL PROTECTED]>
Subject: DO NOT REPLY [Bug 45753] Code contribution
To: [email protected]
Date: Thursday, October 9, 2008, 7:
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #1 from Curt Arnold <[EMAIL PROTECTED]> 2008-10-09 17:09:14 PST ---
First, some picky things:
The license headers in the source code should conform to
http://www.apache.org/legal/src-headers.html. If you could fix the head
> The log4j built predates that and uses a different directory
> structure. I think it is very unlikely that it would go directly
> into log4j itself. Probably the most reasonable course of action is
> to check out the extras companion and work the classes into that
> build environment. It would
On Nov 7, 2007, at 10:22 PM, Will Sargent wrote:
Curt Arnold wrote:
I did take a scan of the code, it does appear to conform to ASF
source header policy (http://www.apache.org/legal/src-headers.html).
It also stated that it was based on log4j 1.3. log4j 1.3
development has been abandoned
Curt Arnold wrote:
I did take a scan of the code, it does appear to conform to ASF source
header policy (http://www.apache.org/legal/src-headers.html).
It also stated that it was based on log4j 1.3. log4j 1.3 development
has been abandoned. I assume that it could be modified to work with
lo
> Collaborative software development is a key tenet of the ASF and code
> that is developed in isolation may need to come through the
> incubator. Ideally, new code contributions start with a "hey, I was
> thinking about " message and some initial discussion and then
> maybe a proof of concept
On Nov 5, 2007, at 2:55 PM, Will Sargent wrote:
Hi all,
I have a layered configurator that I'd like to contribute to log4j,
either as a companion or in the core code. I've read through the
wiki on
http://wiki.apache.org/logging-log4j/ContributingCode
and a description and zip of the co
Hi all,
I have a layered configurator that I'd like to contribute to log4j,
either as a companion or in the core code. I've read through the wiki on
http://wiki.apache.org/logging-log4j/ContributingCode
and a description and zip of the code is currently here:
http://tersesystems.com/code/in
Thanks Elias, all good ideas. I almost changed the name to exactly what you suggested. The only reason I didn't was because I thought it made the init params and java doc a little more confusing since they refer to the token bucket and how it is used. Maybe we can come up with better names for th
On Wed, 2006-07-05 at 09:27 -0700, Chad LaVigne wrote:
> I've attached the source code, a test class and a log4j configuration
> file that utilizes the filter. Please let me know if you have any
> questions or comments.
Just a couple of comments...
It might be nice to call it what it is used fo
Hello Log4j development team, My name is Chad LaVigne. I would like to submit a filter I've written for consideration as an addition to the log4j project. It is a filter that regulates bursts in logging using the Token Bucket algorithm. It is useful in situations where you want to limit the
Hi,
As soon as I finish up I'll send you the Sources.
How do I know if my Code is makeing it into the next release?
If not, I'd have to integrate the extras in our own framworks.
More important, how likley is it that you take over the changes I've made to
LogFileParser.java? All my extras depend
Hi,
Gerhard Muth ,
U can contribute u code with me on my mail id
[EMAIL PROTECTED]
thanks.
--- Gerhard Muth <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I have written some Code to ease the use of
> LogFactor5 in a network context.
> Namely I've modified LogFileParser to continously
> read the input S
Hi,
I have written some Code to ease the use of LogFactor5 in a network context.
Namely I've modified LogFileParser to continously read the input Stream
(like tail -f) and wrote a LF5SocketServerAppender and a class called
StartLogFactor5Client.
I would like to share my work with you. How can I c
30 matches
Mail list logo
