Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Gary Gregory
If you use the command line, call: git config --global core.autocrlf true I'm not sure if EGit picks that up automagically, but mine says Core -> autocrlf -> true Gary On Sat, Aug 20, 2016 at 5:35 PM, Matt Sicker wrote: > Ideally, we should just do an all at once conversion to unix line endin

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Gary Gregory
I thought Git did the conversion since I installed it that way (check out as Windows EOL and commit as Unix EOL)... hm... but yes I use Eclipse... and EGit which has "core autocrlf" set to true in my user settings. On the command line "git config --global core.autocrlf" says true. What's going on

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Matt Sicker
I use a similar setting in IntelliJ. It usually has a banner on the top of the file when you open it to let you know if the file isn't formatted with the same basic settings as the project (e.g., line endings, tabs versus spaces, number of spaces to an indent). On 20 August 2016 at 19:46, Remko Po

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Remko Popma
Looks like my IDE is set to use "system-dependent" line endings for new files. (I think that means that for existing files it will use the existing line endings.) Perhaps this is a formatter issue then? Gary, do you use Eclipse to format before committing? Perhaps the formatter has some setting to

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Matt Sicker
Ideally, we should just do an all at once conversion to unix line endings or windows line endings to all branches. Then the line ending fixes won't come in anymore. We could add an EditorConfig file to enforce it automatically in IDEs even. On 20 August 2016 at 19:33, Remko Popma wrote: > Gary,

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Remko Popma
Gary, can you please check your IDE settings for line endings? It is really difficult to see what changed if the whole file is marked as modified in the commit mail. I suspect this is because your IDE converts the unix line endings to windows CRLF or something. On Sun, Aug 21, 2016 at 9:30 AM, w