Re: svn commit: r909868 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/

2010-02-15 Thread Ceki Gulcu
On 15.02.2010 08:13, Ralph Goers wrote: I would also suggest that Ceki needs to be careful in not vetoing things simply because they are already in Logback as there is a potential conflict of interest here. If Curt's account is indeed true then I'm not convinced he did anything wrong,

Re: svn commit: r909868 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/

2010-02-15 Thread Ralph Goers
On Feb 15, 2010, at 9:23 PM, Curt Arnold wrote: On Feb 15, 2010, at 1:13 AM, Ralph Goers wrote: I'm not on the legal affairs committee, the board or the logging PMC so my opinion here is just that. I haven't looked recently at how prudent mode is implemented (although my experience

Re: svn commit: r909868 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/

2010-02-14 Thread Ceki Gülcü
On 14/02/2010 7:05 AM, Curt Arnold wrote: On Feb 13, 2010, at 3:58 PM, Ceki Gülcü wrote: Isn't the write method in PrudentWriter (see [1]) a copy-and-paste of code safeWrite() method in logback's FileAppender (see [2])? [1]

Re: svn commit: r909868 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/

2010-02-14 Thread Thorbjørn Ravn Andersen
Ceki Gülcü skrev: The process that I followed was to examine to the logback code to determine what prudent mode was, which I then described as part of the bug report and then implemented from the description. The fragments are similar since there aren't that many ways to get a lock on a

Re: svn commit: r909868 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/

2010-02-14 Thread Ralph Goers
I'm not on the legal affairs committee, the board or the logging PMC so my opinion here is just that. I haven't looked recently at how prudent mode is implemented (although my experience with file system locking tells me that no matter how good it is it will fail on some systems) or what was

svn commit: r909868 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/

2010-02-13 Thread carnold
Author: carnold Date: Sat Feb 13 18:24:46 2010 New Revision: 909868 URL: http://svn.apache.org/viewvc?rev=909868view=rev Log: Bug 48704: Add purient mode to FileAppender Added: logging/log4j/trunk/src/main/java/org/apache/log4j/helpers/PrudentWriter.java

Re: svn commit: r909868 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/

2010-02-13 Thread Ceki Gülcü
Isn't the write method in PrudentWriter (see [1]) a copy-and-paste of code safeWrite() method in logback's FileAppender (see [2])? [1] http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/helpers/PrudentWriter.java?revision=909868view=markuppathrev=909918 [2]

Re: svn commit: r909868 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/

2010-02-13 Thread Curt Arnold
On Feb 13, 2010, at 3:58 PM, Ceki Gülcü wrote: Isn't the write method in PrudentWriter (see [1]) a copy-and-paste of code safeWrite() method in logback's FileAppender (see [2])? [1]