Re: SMTPAppender work in progress, questions

2012-12-21 Thread Scott Severtson
It looks like Commons Email mocks out the javax.mail interfaces. We *could* take a similar approach, but in my opinion, it's both more comprehensive and easier to test delivery from end-to-end with a dummy SMTP server. --Scott On 12/20/2012 10:42 PM, Gary Gregory wrote: On Dec 20, 2012, at 20

Re: SMTPAppender work in progress, questions

2012-12-21 Thread Scott Severtson
On 12/21/2012 02:08 AM, Ralph Goers wrote: On Dec 20, 2012, at 5:02 PM, Scott Severtson wrote: I'll see what I can wrap up in the short term, for possible inclusion in beta 4. Sounds great! Code is complete, uses a manager for SMTP Session instances. It has decent unit test coverage, includi

Re: SMTPAppender work in progress, questions

2012-12-21 Thread Ralph Goers
Please create a Jira issue and attach the patches or files to that. Please create a separate Jira for the Syslog layout fix/enhancement. Ralph On Dec 21, 2012, at 9:31 AM, Scott Severtson wrote: > On 12/21/2012 02:08 AM, Ralph Goers wrote: >> On Dec 20, 2012, at 5:02 PM, Scott Severtson wrote:

[jira] [Updated] (LOG4J2-131) Create SMTPAppender

2012-12-21 Thread Scott Severtson (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Severtson updated LOG4J2-131: --- Attachment: SMTPAppender.patch A port of Log4J 1.x's SMTPAppender, with significant cleanup/r

[jira] [Created] (LOG4J2-136) Syslog: Optional escaping of newlines in message body

2012-12-21 Thread Scott Severtson (JIRA)
Scott Severtson created LOG4J2-136: -- Summary: Syslog: Optional escaping of newlines in message body Key: LOG4J2-136 URL: https://issues.apache.org/jira/browse/LOG4J2-136 Project: Log4j 2 Iss

[jira] [Updated] (LOG4J2-136) Syslog: Optional escaping of newlines in message body

2012-12-21 Thread Scott Severtson (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Severtson updated LOG4J2-136: --- Attachment: syslog-escape-newlines.patch Patch against trunk to support escaping newlines in

[jira] [Commented] (LOG4J2-136) Syslog: Optional escaping of newlines in message body

2012-12-21 Thread Scott Severtson (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538333#comment-13538333 ] Scott Severtson commented on LOG4J2-136: BTW, if you work with rsyslog, the logica

Re: SMTPAppender work in progress, questions

2012-12-21 Thread Scott Severtson
OK. I've attached SMTPAppender as a patch to LOG4J2-131 , and created LOG4J2-136 for the Syslog newline patch. Please let me know if there's any improvements that could be made to either. FYI,