Bug report for Log4j [2014/03/30]

2014-03-30 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

[jira] [Created] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Bruce Brouwer (JIRA)
Bruce Brouwer created LOG4J2-585: Summary: Markers not as powerful as slf4j Key: LOG4J2-585 URL: https://issues.apache.org/jira/browse/LOG4J2-585 Project: Log4j 2 Issue Type: Improvement

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954714#comment-13954714 ] Ralph Goers commented on LOG4J2-585: The choice to make Markers immutable and not supp

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954715#comment-13954715 ] Gary Gregory commented on LOG4J2-585: - Would it possible for Log4J 2 to work with an a

[jira] [Comment Edited] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954715#comment-13954715 ] Gary Gregory edited comment on LOG4J2-585 at 3/30/14 3:35 PM: --

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954753#comment-13954753 ] Bruce Brouwer commented on LOG4J2-585: -- About the performance, I suspected what Ralph

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954762#comment-13954762 ] Ralph Goers commented on LOG4J2-585: Yes, feel free to submit a patch. I have no prob

Looking for feedback on moving JMS code to their own packages.

2014-03-30 Thread Matt Sicker
Since JMS depends on Java EE APIs, it would make sense to place them in their own packages similar to how the db code is handled. I know they work fine as is, but it makes it easier to segregate optional dependencies. This would be useful for OSGi so that we can use the full set of metadata availab

Re: Looking for feedback on moving JMS code to their own packages.

2014-03-30 Thread Ralph Goers
What JaveEE APIs? JMX was moved to Java SE in 1.5 and 1.6. I’m not sure I like the mbeans registering automatically but oh well. Ralph On Mar 30, 2014, at 10:52 AM, Matt Sicker wrote: > Since JMS depends on Java EE APIs, it would make sense to place them in their > own packages similar to ho

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954776#comment-13954776 ] Ralph Goers commented on LOG4J2-585: If you are going to use a lock you might consider

Re: Looking for feedback on moving JMS code to their own packages.

2014-03-30 Thread Matt Sicker
JMS, not JMX. On 30 March 2014 13:11, Ralph Goers wrote: > What JaveEE APIs? JMX was moved to Java SE in 1.5 and 1.6. > > I’m not sure I like the mbeans registering automatically but oh well. > > Ralph > > On Mar 30, 2014, at 10:52 AM, Matt Sicker wrote: > > Since JMS depends on Java EE APIs,

Re: Looking for feedback on moving JMS code to their own packages.

2014-03-30 Thread Matt Sicker
Also, JMX code is already in its own package :) On 30 March 2014 13:16, Matt Sicker wrote: > JMS, not JMX. > > > On 30 March 2014 13:11, Ralph Goers wrote: > >> What JaveEE APIs? JMX was moved to Java SE in 1.5 and 1.6. >> >> I’m not sure I like the mbeans registering automatically but oh wel

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954781#comment-13954781 ] Ralph Goers commented on LOG4J2-585: I looked at BasicMarker again. It has changed a b

[jira] [Created] (LOG4J2-586) Capability to merge LoggerContexts or dynamically add an additional ConfigurationSource to a context.

2014-03-30 Thread James Hutton (JIRA)
James Hutton created LOG4J2-586: --- Summary: Capability to merge LoggerContexts or dynamically add an additional ConfigurationSource to a context. Key: LOG4J2-586 URL: https://issues.apache.org/jira/browse/LOG4J2-586

Re: Looking for feedback on moving JMS code to their own packages.

2014-03-30 Thread Ralph Goers
Oops, sorry. Ralph > On Mar 30, 2014, at 11:16 AM, Matt Sicker wrote: > > JMS, not JMX. > > >> On 30 March 2014 13:11, Ralph Goers wrote: >> What JaveEE APIs? JMX was moved to Java SE in 1.5 and 1.6. >> >> I’m not sure I like the mbeans registering automatically but oh well. >> >> Ralph >

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954805#comment-13954805 ] Bruce Brouwer commented on LOG4J2-585: -- Cool. So, in my patch, when I make log4j Mark

[jira] [Comment Edited] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954805#comment-13954805 ] Bruce Brouwer edited comment on LOG4J2-585 at 3/30/14 7:12 PM: -

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954808#comment-13954808 ] Ralph Goers commented on LOG4J2-585: You could use CopyOnWriteArrayList. If adds and r

Re: Looking for feedback on moving JMS code to their own packages.

2014-03-30 Thread Gary Gregory
JMX shoud be off by default IMO? Is there a recommendation or a known pattern in this area? Gary On Sun, Mar 30, 2014 at 2:11 PM, Ralph Goers wrote: > What JaveEE APIs? JMX was moved to Java SE in 1.5 and 1.6. > > I’m not sure I like the mbeans registering automatically but oh well. > > Ralph

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954871#comment-13954871 ] Gary Gregory commented on LOG4J2-585: - Why can't we have 2 Marker implementations? Mut

[jira] [Comment Edited] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954871#comment-13954871 ] Gary Gregory edited comment on LOG4J2-585 at 3/30/14 11:46 PM: -

Re: Looking for feedback on moving JMS code to their own packages.

2014-03-30 Thread Remko Popma
I disagree. Why would you want to do that? When you have a production issue and you need to look inside the server to see what is going on you cannot restart the process to enable JMX... I really think it should be on by default. Sent from my iPhone > On 2014/03/31, at 8:39, Gary Gregory wro

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954878#comment-13954878 ] Bruce Brouwer commented on LOG4J2-585: -- Interesting. I don't know if it makes sense f

unit test failures?

2014-03-30 Thread Gary Gregory
Hi All: I have a large change set (can't break it up into smaller bits) on my machine and it does not seem related to the following failures I see: Results : Failed tests: XmlFileAppenderTest.testFlushAtEndOfBatch:70 line1 incorrect: [ ], does not contain: [AbstractJpaAppenderTest.testBaseJpa

[jira] [Created] (LOG4J2-587) log4j-1.2-api emulation jar missing classes

2014-03-30 Thread Adam Gent (JIRA)
Adam Gent created LOG4J2-587: Summary: log4j-1.2-api emulation jar missing classes Key: LOG4J2-587 URL: https://issues.apache.org/jira/browse/LOG4J2-587 Project: Log4j 2 Issue Type: Bug

core.impl.Log4jLogEvent.LogEventProxy

2014-03-30 Thread Gary Gregory
As I am working on LOG4J2-583I ran into core.impl.Log4jLogEvent.LogEventProxy. - LogEventProxy is used to move events across threads internally - A real Log4jLogEvent is used in the SerializedLayout. Why the different? As you answer, if you can a

[jira] [Updated] (LOG4J2-587) log4j-1.2-api emulation jar missing classes

2014-03-30 Thread Adam Gent (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Gent updated LOG4J2-587: - Description: The log4j 1.2 emulation jar does not contain {{AppenderSkeleton}}. There are several Spring

[jira] [Commented] (LOG4J2-587) log4j-1.2-api emulation jar missing classes

2014-03-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954926#comment-13954926 ] Gary Gregory commented on LOG4J2-587: - Would you be willing to submit a patch (diff fi

[jira] [Closed] (LOG4J2-587) log4j-1.2-api emulation jar missing classes

2014-03-30 Thread Adam Gent (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Gent closed LOG4J2-587. Resolution: Fixed Apparently a custom component of ours was accessing AppenderSkeleton (an import statemen

Re: core.impl.Log4jLogEvent.LogEventProxy

2014-03-30 Thread Ralph Goers
Unless I completely screwed up SerializedLayout should be using the proxy when the LogEvent is serialized. See item #78 in Effective Java. Ralph On Mar 30, 2014, at 8:04 PM, Gary Gregory wrote: > As I am working on LOG4J2-583 I ran into > core.impl.Log4jLogEvent.LogEventProxy. > > - LogEvent

Re: core.impl.Log4jLogEvent.LogEventProxy

2014-03-30 Thread Ralph Goers
Out of curiosity, why does implementing an XML socket server require touching the LogEvent? What are XMLLogEventInput and JSONLogEventInput going to do that would require that? Ralph On Mar 30, 2014, at 8:04 PM, Gary Gregory wrote: > As I am working on LOG4J2-583 I ran into > core.impl.Log4

Re: unit test failures?

2014-03-30 Thread Ralph Goers
Trunk is building for me. Ralph On Mar 30, 2014, at 7:43 PM, Gary Gregory wrote: > Hi All: > > I have a large change set (can't break it up into smaller bits) on my machine > and it does not seem related to the following failures I see: > > Results : > > Failed tests: > XmlFileAppenderTes