[jira] [Commented] (LOG4J2-797) log4j-core should be listed as runtime dependency

2014-09-24 Thread whaefelinger (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146029#comment-14146029 ] whaefelinger commented on LOG4J2-797: - {quote} Too much detail? Perhaps only add this

[jira] [Commented] (LOG4J2-798) jar scanning for plugins too expensive and called too many times

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146116#comment-14146116 ] Remko Popma commented on LOG4J2-798: [~ianbarfield] We are getting ready for a 2.1 rel

[jira] [Updated] (LOG4J2-702) LoggerConfig#waitForCompletion is not thread safe

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-702: --- Fix Version/s: (was: 2.1) 2.2 Assignee: (was: Matt Sicker) The Fix

[jira] [Updated] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-323: --- Fix Version/s: (was: 2.1) 2.2 I've looked at this and I don't think it is possi

[jira] [Commented] (LOG4J2-824) How to delegate logging to a utility class in Log4j2

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146176#comment-14146176 ] Remko Popma commented on LOG4J2-824: Did you have a chance to take a look at this? Did

[jira] [Created] (LOG4J2-855) Broken links on Appenders manual page

2014-09-24 Thread Remko Popma (JIRA)
Remko Popma created LOG4J2-855: -- Summary: Broken links on Appenders manual page Key: LOG4J2-855 URL: https://issues.apache.org/jira/browse/LOG4J2-855 Project: Log4j 2 Issue Type: Bug C

[jira] [Commented] (LOG4J2-727) Need a way to create RollingRandomAccessFileAppender with custom manager

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146189#comment-14146189 ] Remko Popma commented on LOG4J2-727: There is a built-in header/footer function you ca

Fwd: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Gary Gregory
Do we really want two LifeCycle abstract classes? Will this not be a case -- like plug in builders vs. factory methods -- where we have two ways of doing the same thing? When do I use one vs. the other? You'd need to Javadoc that at least. Shouldn't we just have one way of doing this? Gary

Re: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Gary Gregory
Hm... and why does start() behave differently in AALC from ALC? AALC is not used either... so... what is it in there for? Gary On Wed, Sep 24, 2014 at 7:37 AM, Gary Gregory wrote: > Do we really want two LifeCycle abstract classes? > > Will this not be a case -- like plug in builders vs. factor

[jira] [Closed] (LOG4J2-855) Broken links on Appenders manual page

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-855. -- Resolution: Fixed Fixed in master in commit a902612. > Broken links on Appenders manual page >

Re: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Matt Sicker
Looks like I meant to add this to a different branch. This is how I think LifeCycle classes should work, though, so feedback would be good. If possible, I'd like to replace the current ALC with the proposed AALC (which would just be renamed to AbstractLifeCycle). On 24 September 2014 06:43, Gary G

Re: [1/4] git commit: Add Comparator for @Order-annotated classes.

2014-09-24 Thread Matt Sicker
Note that Spring has the same annotation, but they use a default order value of Integer.MAX_VALUE. In this case, I even put an unannotated class as lower priority than that. Also, I think I can update how the weighted ConfigurationFactory lookup. Would be nice in 2.2 to support it in general for p

Re: Towards a 2.1 release

2014-09-24 Thread Matt Sicker
That's why I thought calling it a "candidate" release made that distinction. Plus, Alpha, Beta, Candidate release. Going ABC like that makes suffixes like Final or Release both come next, though that's not an issue here. On 23 September 2014 16:30, Ralph Goers wrote: > When you do a release that

[jira] [Commented] (LOG4J2-797) log4j-core should be listed as runtime dependency

2014-09-24 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146296#comment-14146296 ] Matt Sicker commented on LOG4J2-797: I'm rethinking my stance on this. In my projects,

[jira] [Resolved] (LOG4J2-797) log4j-core should be listed as runtime dependency

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-797. Resolution: Fixed Pushed to master in commit 83953ba. Please verify and close. To answer your quest

[jira] [Commented] (LOG4J2-797) log4j-core should be listed as runtime dependency

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146300#comment-14146300 ] Remko Popma commented on LOG4J2-797: Matt, looks like our messages crossed. Does the s

[jira] [Created] (LOG4J2-856) Maven and Ivy page is missing build documentation for log4j-nosql, log4j-jul and log4j-iostreams

2014-09-24 Thread Remko Popma (JIRA)
Remko Popma created LOG4J2-856: -- Summary: Maven and Ivy page is missing build documentation for log4j-nosql, log4j-jul and log4j-iostreams Key: LOG4J2-856 URL: https://issues.apache.org/jira/browse/LOG4J2-856

[jira] [Commented] (LOG4J2-797) log4j-core should be listed as runtime dependency

2014-09-24 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146305#comment-14146305 ] Matt Sicker commented on LOG4J2-797: No, it looks good now. > log4j-core should be li

[jira] [Commented] (LOG4J2-797) log4j-core should be listed as runtime dependency

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146308#comment-14146308 ] Remko Popma commented on LOG4J2-797: OK, thanks. > log4j-core should be listed as ru

[jira] [Assigned] (LOG4J2-856) Maven and Ivy page is missing build documentation for log4j-nosql, log4j-jul and log4j-iostreams

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-856: -- Assignee: Remko Popma > Maven and Ivy page is missing build documentation for log4j-nosql, log4

[jira] [Closed] (LOG4J2-856) Maven and Ivy page is missing build documentation for log4j-nosql, log4j-jul and log4j-iostreams

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-856. -- Resolution: Fixed Pushed to master in commit 5923880. > Maven and Ivy page is missing build documentati

Re: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Gary Gregory
Hm... so how do we pick one. Are there cases w/i Log4j where we'd want one in one case and the other in another case? Hm... I am warming up to having the same states as OSGi... Gary On Wed, Sep 24, 2014 at 9:07 AM, Matt Sicker wrote: > Looks like I meant to add this to a different branch. This

Re: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Matt Sicker
This implementation is threadsafe. On 24 September 2014 09:24, Gary Gregory wrote: > Hm... so how do we pick one. Are there cases w/i Log4j where we'd want one > in one case and the other in another case? > > Hm... I am warming up to having the same states as OSGi... > > Gary > > On Wed, Sep 24,

[jira] [Commented] (LOG4J2-589) Allow the use of custom levels in configuration

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146417#comment-14146417 ] Remko Popma commented on LOG4J2-589: An even simpler syntax: {code} ... {c

Re: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Gary Gregory
How is the ACL not thread safe? I see that hashCode() could be an issue. Gary On Wed, Sep 24, 2014 at 10:59 AM, Matt Sicker wrote: > This implementation is threadsafe. > > On 24 September 2014 09:24, Gary Gregory wrote: > >> Hm... so how do we pick one. Are there cases w/i Log4j where we'd wan

[jira] [Commented] (LOG4J2-589) Allow the use of custom levels in configuration

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146441#comment-14146441 ] Remko Popma commented on LOG4J2-589: I see some code in AbstractConfiguration that loo

Re: Towards a 2.1 release

2014-09-24 Thread Remko Popma
Are there any issues in the list of open 2.1 items we would want to address for 2.1? Or should t

Re: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Remko Popma
On Wed, Sep 24, 2014 at 10:07 PM, Matt Sicker wrote: > Looks like I meant to add this to a different branch. This is how I think > LifeCycle classes should work, though, so feedback would be good. If > possible, I'd like to replace the current ALC with the proposed AALC (which > would just be ren

[jira] [Commented] (LOG4J2-589) Allow the use of custom levels in configuration

2014-09-24 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146495#comment-14146495 ] Ralph Goers commented on LOG4J2-589: I will have to refresh my memory. That code was c

Re: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Gary Gregory
On Wed, Sep 24, 2014 at 12:03 PM, Remko Popma wrote: > > > On Wed, Sep 24, 2014 at 10:07 PM, Matt Sicker wrote: > >> Looks like I meant to add this to a different branch. This is how I think >> LifeCycle classes should work, though, so feedback would be good. If >> possible, I'd like to replace

[jira] [Commented] (LOG4J2-589) Allow the use of custom levels in configuration

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146526#comment-14146526 ] Remko Popma commented on LOG4J2-589: I see. That was the early days of custom levels..

Re: Towards a 2.1 release

2014-09-24 Thread Gary Gregory
For my money, move them all to 2.2. Gary On Wed, Sep 24, 2014 at 11:59 AM, Remko Popma wrote: > Are there any issues in the list of open 2.1 items >

[jira] [Comment Edited] (LOG4J2-589) Allow the use of custom levels in configuration

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146526#comment-14146526 ] Remko Popma edited comment on LOG4J2-589 at 9/24/14 4:57 PM: -

[jira] [Comment Edited] (LOG4J2-589) Allow the use of custom levels in configuration

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146526#comment-14146526 ] Remko Popma edited comment on LOG4J2-589 at 9/24/14 4:58 PM: -

[jira] [Commented] (LOG4J2-589) Allow the use of custom levels in configuration

2014-09-24 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146675#comment-14146675 ] Ralph Goers commented on LOG4J2-589: How do these get used in an application? The the

Re: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Matt Sicker
I'll move it to a branch tonight, sorry about that. And I might be wrong about thread safety, but using AtomicReference seems to make more sense. On 24 September 2014 11:47, Gary Gregory wrote: > On Wed, Sep 24, 2014 at 12:03 PM, Remko Popma > wrote: > >> >> >> On Wed, Sep 24, 2014 at 10:07 PM,

[jira] [Updated] (LOG4J2-381) Changes in SizeBasedTriggeringPolicy has no effects when automatic reconfiguration is on.

2014-09-24 Thread Anthony Baldocchi (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baldocchi updated LOG4J2-381: - Attachment: LOG4J2-381.patch Attached patch resolves the issue for me. > Changes in SizeB

[jira] [Commented] (LOG4J2-589) Allow the use of custom levels in configuration

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147080#comment-14147080 ] Remko Popma commented on LOG4J2-589: I'm assuming that users want to write code like t

[jira] [Updated] (LOG4J2-381) Changes in SizeBasedTriggeringPolicy has no effects when automatic reconfiguration is on.

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-381: --- Description: My config is very simple: {code}

[jira] [Comment Edited] (LOG4J2-589) Allow the use of custom levels in configuration

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147080#comment-14147080 ] Remko Popma edited comment on LOG4J2-589 at 9/25/14 1:22 AM: -

[jira] [Updated] (LOG4J2-846) Combine Log4jWebInitializerImpl into a LoggerContext/LifeCycle wrapper class

2014-09-24 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-846: --- Fix Version/s: (was: 2.1) 2.2 > Combine Log4jWebInitializerImpl into a LoggerCo

[jira] [Updated] (LOG4J2-779) Upgrade site to Twitter Bootstrap version 3.2.0

2014-09-24 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-779: --- Fix Version/s: (was: 2.1) 2.2 > Upgrade site to Twitter Bootstrap version 3.2.0

[jira] [Commented] (LOG4J2-801) org.apache.logging.log4j.core.Logger should be serializable

2014-09-24 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147224#comment-14147224 ] Matt Sicker commented on LOG4J2-801: It currently is. Close? > org.apache.logging.log

[jira] [Created] (LOG4J2-857) Add support for the @Order annotation on all @Plugin classes.

2014-09-24 Thread Matt Sicker (JIRA)
Matt Sicker created LOG4J2-857: -- Summary: Add support for the @Order annotation on all @Plugin classes. Key: LOG4J2-857 URL: https://issues.apache.org/jira/browse/LOG4J2-857 Project: Log4j 2 Is

Re: Towards a 2.1 release

2014-09-24 Thread Matt Sicker
I updated a couple in that list that I assigned to myself. There's an issue by Gary that looks to be fixed already that he can probably close. On 24 September 2014 11:45, Gary Gregory wrote: > For my money, move them all to 2.2. > > Gary > > On Wed, Sep 24, 2014 at 11:59 AM, Remko Popma > wrote

[jira] [Commented] (LOG4J2-801) org.apache.logging.log4j.core.Logger should be serializable

2014-09-24 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147240#comment-14147240 ] Gary Gregory commented on LOG4J2-801: - The class may implement Serializable but having

[jira] [Updated] (LOG4J2-801) org.apache.logging.log4j.core.Logger should be serializable

2014-09-24 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-801: Fix Version/s: (was: 2.1) 2.2 > org.apache.logging.log4j.core.Logger should b

Re: NoSQL 3rd party updates

2014-09-24 Thread Gary Gregory
Matt, This could wait for 2.2 unless you have time to test. Right now, it seems there is no way to test this from the build. Gary On Sun, Sep 14, 2014 at 12:51 AM, Gary Gregory wrote: > If you have time to check this for 2.1 that would be nice. > > Gary > > On Thu, Sep 11, 2014 at 3:03 PM, Mat

Re: NoSQL 3rd party updates

2014-09-24 Thread Matt Sicker
There's several tests for any NoSQL implementation following the general contract of how they're all supposed to work. The MongoDB driver should be safe to update, but the Lightcouch one is still rather new, so I wouldn't trust a new version without perusing their changelog. On 24 September 2014 2

Re: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Matt Sicker
Reverted the commit. On 24 September 2014 14:30, Matt Sicker wrote: > I'll move it to a branch tonight, sorry about that. And I might be wrong > about thread safety, but using AtomicReference seems to make more > sense. > > On 24 September 2014 11:47, Gary Gregory wrote: > >> On Wed, Sep 24, 20

[jira] [Resolved] (LOG4J2-798) jar scanning for plugins too expensive and called too many times

2014-09-24 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker resolved LOG4J2-798. Resolution: Fixed Fix Version/s: 2.1 This was fixed from the work done on LOG4J2-745. Could y

[jira] [Commented] (LOG4J2-812) Performance optimization: avoid use of synchronized SimpleDateFormat in Dat​ePatternCo​nverter

2014-09-24 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147255#comment-14147255 ] Gary Gregory commented on LOG4J2-812: - d) Use a thread local to for the formatter > P

[jira] [Created] (LOG4J2-858) Improve PluginManager to filter plugins by class

2014-09-24 Thread Matt Sicker (JIRA)
Matt Sicker created LOG4J2-858: -- Summary: Improve PluginManager to filter plugins by class Key: LOG4J2-858 URL: https://issues.apache.org/jira/browse/LOG4J2-858 Project: Log4j 2 Issue Type: New

Re: NoSQL 3rd party updates

2014-09-24 Thread Gary Gregory
It feels like we need an integration test to start/stop a MongoDB instance... same for the other guy. Gary On Wed, Sep 24, 2014 at 9:59 PM, Matt Sicker wrote: > There's several tests for any NoSQL implementation following the general > contract of how they're all supposed to work. The MongoDB d

Re: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Gary Gregory
Revisit for 2.2... Gary On Wed, Sep 24, 2014 at 9:59 PM, Matt Sicker wrote: > Reverted the commit. > > On 24 September 2014 14:30, Matt Sicker wrote: > >> I'll move it to a branch tonight, sorry about that. And I might be wrong >> about thread safety, but using AtomicReference seems to make mo

[jira] [Created] (LOG4J2-859) Use an AtomicReference for AbstractLifeCycle to make a finite state machine

2014-09-24 Thread Matt Sicker (JIRA)
Matt Sicker created LOG4J2-859: -- Summary: Use an AtomicReference for AbstractLifeCycle to make a finite state machine Key: LOG4J2-859 URL: https://issues.apache.org/jira/browse/LOG4J2-859 Project: Log4j

Re: [2/4] git commit: Add LifeCycle abstract class that uses AtomicReference.

2014-09-24 Thread Matt Sicker
https://issues.apache.org/jira/browse/LOG4J2-859 On 24 September 2014 21:07, Gary Gregory wrote: > Revisit for 2.2... > > Gary > > On Wed, Sep 24, 2014 at 9:59 PM, Matt Sicker wrote: > >> Reverted the commit. >> >> On 24 September 2014 14:30, Matt Sicker wrote: >> >>> I'll move it to a branch

[jira] [Commented] (LOG4J2-859) Use an AtomicReference for AbstractLifeCycle to make a finite state machine

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147275#comment-14147275 ] Remko Popma commented on LOG4J2-859: Can you elaborate a bit on the motivation for thi

[jira] [Commented] (LOG4J2-859) Use an AtomicReference for AbstractLifeCycle to make a finite state machine

2014-09-24 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147278#comment-14147278 ] Matt Sicker commented on LOG4J2-859: No need for a volatile field, for one. Built in s

[jira] [Commented] (LOG4J2-812) Performance optimization: avoid use of synchronized SimpleDateFormat in Dat​ePatternCo​nverter

2014-09-24 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147282#comment-14147282 ] Gary Gregory commented on LOG4J2-812: - I'm not sure using a different formatter would

[jira] [Commented] (LOG4J2-859) Use an AtomicReference for AbstractLifeCycle to make a finite state machine

2014-09-24 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147283#comment-14147283 ] Gary Gregory commented on LOG4J2-859: - Matt, Can you attach the code we are talking a

[jira] [Created] (LOG4J2-860) Unify plugin builders and plugin factories

2014-09-24 Thread Matt Sicker (JIRA)
Matt Sicker created LOG4J2-860: -- Summary: Unify plugin builders and plugin factories Key: LOG4J2-860 URL: https://issues.apache.org/jira/browse/LOG4J2-860 Project: Log4j 2 Issue Type: Improvemen

[jira] [Commented] (LOG4J2-859) Use an AtomicReference for AbstractLifeCycle to make a finite state machine

2014-09-24 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147291#comment-14147291 ] Matt Sicker commented on LOG4J2-859: {code} package org.apache.logging.log4j.core; im

[jira] [Closed] (LOG4J2-814) Configuration file loading should be abstracted into a sort of ResourceLoader interface

2014-09-24 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker closed LOG4J2-814. -- Resolution: Duplicate Turns out that ConfigurationSource is basically the same thing. > Configuration f

Re: Delete redundant branches?

2014-09-24 Thread Matt Sicker
Cleared out a few of those branches (at least the ones that I put up there in the first place). Still have the new-levels branch (not sure about), 2.0-beta1 (sounds rather outdated), and LOG4J2-609 (still looks to be in progress). On 23 September 2014 12:52, Matt Sicker wrote: > It doesn't delet

No for each loop comment?

2014-09-24 Thread Gary Gregory
Why does this "//noinspection ForLoopReplaceableByForEach" comment mean? Why not for an enhanced for each loop? private static boolean contains(final Marker parent, final Marker... localParents) { //noinspection ForLoopReplaceableByForEach for (int i = 0, localParentsLeng

Re: No for each loop comment?

2014-09-24 Thread Matt Sicker
>From what I remember, it had something to do with the incredibly large difference in speed between for loops and foreach loops on arrays. And by incredibly large, I mean most likely negligible. On 24 September 2014 22:12, Gary Gregory wrote: > Why does this "//noinspection ForLoopReplaceableByF

[jira] [Updated] (LOG4J2-589) Allow filtering on custom levels in configuration

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-589: --- Summary: Allow filtering on custom levels in configuration (was: Allow the use of custom levels in co

[jira] [Comment Edited] (LOG4J2-589) Allow filtering on custom levels in configuration

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147080#comment-14147080 ] Remko Popma edited comment on LOG4J2-589 at 9/25/14 4:04 AM: -

Re: No for each loop comment?

2014-09-24 Thread Remko Popma
> On 2014/09/25, at 12:46, Matt Sicker wrote: > > From what I remember, it had something to do with the incredibly large > difference in speed between for loops and foreach loops on arrays. And by > incredibly large, I mean most likely negligible. :-) I do remember reading that someone found a

[jira] [Updated] (LOG4J2-589) Allow filtering on custom levels in configuration

2014-09-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-589: --- Fix Version/s: (was: 2.2) 2.1 Assignee: Remko Popma This is turning ou