[jira] [Commented] (LOG4J2-1010) Possibility to set ThreadContext values in calls to Logger method

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346009#comment-15346009 ] Greg Thomas commented on LOG4J2-1010: - On the assumption that (generally) a thread th

[jira] [Commented] (LOG4J2-1010) Possibility to set ThreadContext values in calls to Logger method

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346041#comment-15346041 ] Mikael Ståldal commented on LOG4J2-1010: I am actually using [Local|https://twit

[jira] [Comment Edited] (LOG4J2-1010) Possibility to set ThreadContext values in calls to Logger method

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346054#comment-15346054 ] Mikael Ståldal edited comment on LOG4J2-1010 at 6/23/16 8:35 AM: --

[jira] [Commented] (LOG4J2-1010) Possibility to set ThreadContext values in calls to Logger method

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346054#comment-15346054 ] Mikael Ståldal commented on LOG4J2-1010: That might work. However, Twitter Finagl

[jira] [Commented] (LOG4J2-1010) Possibility to set ThreadContext values in calls to Logger method

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346283#comment-15346283 ] Greg Thomas commented on LOG4J2-1010: - > void logMessage(String fqcn, Level level, Ma

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map and stack

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346312#comment-15346312 ] Remko Popma commented on LOG4J2-1349: - The current {{ThreadContext}} map implementati

[jira] [Updated] (LOG4J2-1401) Support changing the log level for all messages related to some domain object

[ https://issues.apache.org/jira/browse/LOG4J2-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1401: Description: Use case: We have a low-garbage trading system. When a production incident occurs we

[jira] [Commented] (LOG4J2-1430) Add optional support for Conversant DisruptorBlockingQueue in AsyncAppender

[ https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346328#comment-15346328 ] Anthony Maire commented on LOG4J2-1430: --- I had a look on the ResponseTimeTest, it's

[jira] [Updated] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal updated LOG4J2-1010: --- Description: It would be useful to have a way to inject context properties into a {{LogEvent

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346359#comment-15346359 ] Mikael Ståldal commented on LOG4J2-1010: OK, I have changed the title and descrip

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346419#comment-15346419 ] Remko Popma commented on LOG4J2-1010: - The best place to inject context map data into

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346517#comment-15346517 ] Mikael Ståldal commented on LOG4J2-1010: Can you give an example of how I am supp

[jira] [Comment Edited] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346564#comment-15346564 ] Remko Popma edited comment on LOG4J2-1010 at 6/23/16 3:02 PM: -

[jira] [Comment Edited] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346564#comment-15346564 ] Remko Popma edited comment on LOG4J2-1010 at 6/23/16 3:04 PM: -

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346564#comment-15346564 ] Remko Popma commented on LOG4J2-1010: - In the Scala module, you would define a class,

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346594#comment-15346594 ] Mikael Ståldal commented on LOG4J2-1010: I think this is putting the abstraction

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346636#comment-15346636 ] Remko Popma commented on LOG4J2-1010: - Actually the {{List}} parameter is coming from

[jira] [Comment Edited] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346636#comment-15346636 ] Remko Popma edited comment on LOG4J2-1010 at 6/23/16 3:47 PM: -

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346651#comment-15346651 ] Matt Sicker commented on LOG4J2-1010: - Here's an example of an asynchronous library a

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346655#comment-15346655 ] Mikael Ståldal commented on LOG4J2-1010: {{LogEvent}} is in log4j-core, and I gue

[jira] [Comment Edited] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346636#comment-15346636 ] Remko Popma edited comment on LOG4J2-1010 at 6/23/16 4:02 PM: -

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346670#comment-15346670 ] Remko Popma commented on LOG4J2-1010: - Ah! No, what I had in mind is to put this inte

[jira] [Comment Edited] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346670#comment-15346670 ] Remko Popma edited comment on LOG4J2-1010 at 6/23/16 4:08 PM: -

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346677#comment-15346677 ] Mikael Ståldal commented on LOG4J2-1010: I think it's better to put this in log4j

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346681#comment-15346681 ] Remko Popma commented on LOG4J2-1010: - Why? The whole point is to decouple LogEvent c

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346691#comment-15346691 ] Remko Popma commented on LOG4J2-1010: - I think there is still some confusion on how t

[jira] [Comment Edited] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346691#comment-15346691 ] Remko Popma edited comment on LOG4J2-1010 at 6/23/16 4:20 PM: -

[jira] [Comment Edited] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346691#comment-15346691 ] Remko Popma edited comment on LOG4J2-1010 at 6/23/16 4:21 PM: -

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346714#comment-15346714 ] Mikael Ståldal commented on LOG4J2-1010: Yes, this would work. However, currentl

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346716#comment-15346716 ] Mikael Ståldal commented on LOG4J2-1010: BTW, it is Finagle, not Finacle. > Inje

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346749#comment-15346749 ] Remko Popma commented on LOG4J2-1010: - The beauty of this approach is that it would p

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346781#comment-15346781 ] Mikael Ståldal commented on LOG4J2-1010: Don't get me wrong. I like this injector

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346789#comment-15346789 ] Ralph Goers commented on LOG4J2-1010: - I just saw my name mentioned here. I definitel

Jenkins build became unstable: Log4j 2.x #2057

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Jenkins build is back to stable : Log4j 2.x #2058

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Created] (LOG4J2-1445) OnStartupTriggeringPolicyTest fails on Windows saying the file is used by another process

Ludovic HOCHET created LOG4J2-1445: -- Summary: OnStartupTriggeringPolicyTest fails on Windows saying the file is used by another process Key: LOG4J2-1445 URL: https://issues.apache.org/jira/browse/LOG4J2-1445

[jira] [Created] (LOG4J2-1446) RollingAppenderSizeTest fails on Windows saying the file is used by another process

Ludovic HOCHET created LOG4J2-1446: -- Summary: RollingAppenderSizeTest fails on Windows saying the file is used by another process Key: LOG4J2-1446 URL: https://issues.apache.org/jira/browse/LOG4J2-1446

AbstractManager.release() -> AutoCloseable

I seems that AbstractManager should implement AutoCloseable where close() does the same thing as release() and release() can be deprecated. org.apache.logging.log4j.core.appender.AbstractManager.release() This will let us rewrite things like the recently fixed "OnStartupTriggeringPolicyTest fails

Lock pattern

I wonder if anyone knows why Lock is not AutoCloseable. This: public static boolean hasManager(final String name) { LOCK.lock(); try { return MAP.containsKey(name); } finally { LOCK.unlock(); } } Seems lame in comparison to: p

[jira] [Resolved] (LOG4J2-1445) OnStartupTriggeringPolicyTest fails on Windows saying the file is used by another process

[ https://issues.apache.org/jira/browse/LOG4J2-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1445. -- Resolution: Fixed Fix Version/s: 2.6.2 Thank you for your suggestion. A fix is in Git ma

Re: Lock pattern

Good idea! Maybe propose this for Java 9? Looks very reasonable to me. Sent from my iPhone > On 2016/06/24, at 8:32, Gary Gregory wrote: > > I wonder if anyone knows why Lock is not AutoCloseable. > > This: > > public static boolean hasManager(final String name) { > LOCK.lock();

Re: Lock pattern

I''m sure I read somewhere that it was a deliberate choice not to make it, to stop people using the very common pattern of creating the object in the try() - which isn't much use for a lock. Greg -- Sent from my iPhone > On 24 Jun 2016, at 00:45, Remko Popma wrote: > > Good idea! > Maybe p

Re: Lock pattern

Sounds like an opportunity for a small Commons or independent project. CloseableLock! On 23 June 2016 at 18:51, Greg Thomas wrote: > I''m sure I read somewhere that it was a deliberate choice not to make it, > to stop people using the very common pattern of creating the object in the > try() - w

Re: Lock pattern

Like this: public static boolean hasManager(final String name) { try (Object o = AutoCloseableLock.lock(LOCK)) { return MAP.containsKey(name); } } With a new class: public class AutoCloseableLock implements AutoCloseable { public static AutoCloseableLock

Re: Lock pattern

On Thu, Jun 23, 2016 at 4:56 PM, Gary Gregory wrote: > Like this: > > public static boolean hasManager(final String name) { > try (Object o = AutoCloseableLock.lock(LOCK)) { > return MAP.containsKey(name); > } > } > > With a new class: > > public class AutoClos

Re: Lock pattern

On Thu, Jun 23, 2016 at 4:51 PM, Greg Thomas wrote: > I''m sure I read somewhere that it was a deliberate choice not to make it, > to stop people using the very common pattern of creating the object in the > try() - which isn't much use for a lock. > It feels like there is a discrepancy between

Jenkins build became unstable: Log4j 2.x #2059

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Comment Edited] (LOG4J2-1349) Garbage-free ThreadContext map and stack

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346312#comment-15346312 ] Remko Popma edited comment on LOG4J2-1349 at 6/24/16 12:09 AM:

[jira] [Updated] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1349: Summary: Garbage-free ThreadContext map (was: Garbage-free ThreadContext map and stack) > Garbage

[jira] [Closed] (LOG4J2-1445) OnStartupTriggeringPolicyTest fails on Windows saying the file is used by another process

[ https://issues.apache.org/jira/browse/LOG4J2-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ludovic HOCHET closed LOG4J2-1445. -- The fix works for me. > OnStartupTriggeringPolicyTest fails on Windows saying the file is used by

[jira] [Created] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

Remko Popma created LOG4J2-1447: --- Summary: Garbage-free data structure for LogEvent's context map data Key: LOG4J2-1447 URL: https://issues.apache.org/jira/browse/LOG4J2-1447 Project: Log4j 2

[jira] [Comment Edited] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346312#comment-15346312 ] Remko Popma edited comment on LOG4J2-1349 at 6/24/16 12:30 AM:

Re: Lock pattern

On Thu, Jun 23, 2016 at 4:58 PM, Gary Gregory wrote: > On Thu, Jun 23, 2016 at 4:56 PM, Gary Gregory > wrote: > >> Like this: >> >> public static boolean hasManager(final String name) { >> try (Object o = AutoCloseableLock.lock(LOCK)) { >> return MAP.containsKey(name); >>

Re: Lock pattern

I kind of hate to point this out, but what's wrong with this when you're not using multiple condition variables? final Object lock = new Object(); synchronized (lock) { // ... } It auto-unlocks at the end, too. On 23 June 2016 at 19:35, Gary Gregory wrote: > On Thu, Jun 23, 2016 at 4:58 PM,

Jenkins build is back to stable : Log4j 2.x #2060

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

RollingAppenderSizeTest failures explained

The failures in RollingAppenderSizeTest are due to the fact that the OutputStreamManager holds on to a CloseShieldOutputStream. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Ed

Re: RollingAppenderSizeTest failures explained

Nope, I was wrong. The close shield is for the console appender... Gary On Thu, Jun 23, 2016 at 6:11 PM, Gary Gregory wrote: > The failures in RollingAppenderSizeTest are due to the fact that the > OutputStreamManager holds on to a CloseShieldOutputStream. > > Gary > > -- > E-Mail: garydgreg...

[jira] [Assigned] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1349: --- Assignee: Remko Popma > Garbage-free ThreadContext map > -- > >

Re: Lock pattern

On Thu, Jun 23, 2016 at 5:52 PM, Matt Sicker wrote: > I kind of hate to point this out, but what's wrong with this when you're > not using multiple condition variables? > > final Object lock = new Object(); > synchronized (lock) { > // ... > } > Considering that we use a lot of ReentrantLocks,

[jira] [Updated] (LOG4J2-1401) Support changing the log level for all messages related to some domain object

[ https://issues.apache.org/jira/browse/LOG4J2-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1401: Assignee: Remko Popma Fix Version/s: 2.7 The use case in the description emphasizes using

[jira] [Updated] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1010: Assignee: Remko Popma Fix Version/s: 2.7 > Injectable context properties > ---

Re: Lock pattern

Any locks that don't use wait/notify could be converted to Object monitors instead. Using the Lock interface works best combined with Conditions as it's more powerful than the basic stuff in Object. Also, if you need something serializable as a lock, you can apparently use Object[0] because an emp

Re: Lock pattern

If my memory serves me right, there is a whole thread on OpenJDK message boards on this design. I will find it and send it, time permitting. On Jun 23, 2016 9:07 PM, "Matt Sicker" wrote: > Any locks that don't use wait/notify could be converted to Object monitors > instead. Using the Lock interf

Re: Lock pattern

Before you go on a dig, is the discussion thread you are looking for arguing against creating such a gadget as an AutoCloseableLock? As in, it's an aberration? Gary On Thu, Jun 23, 2016 at 7:49 PM, Paul Benedict wrote: > If my memory serves me right, there is a whole thread on OpenJDK message >

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347633#comment-15347633 ] Ralph Goers commented on LOG4J2-1010: - OK - I've read this whole thing: 1. I never re

Re: Lock pattern

FWIW, I'm still interested in this AutoCloseableLock idea. On 23 June 2016 at 22:25, Gary Gregory wrote: > Before you go on a dig, is the discussion thread you are looking for > arguing against creating such a gadget as an AutoCloseableLock? As in, it's > an aberration? > > Gary > > On Thu, Jun