[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451555#comment-15451555 ] Mikael Ståldal commented on LOG4J2-1010: I am OK with 1010 & 1447. I still have s

[jira] [Commented] (LOG4J2-1548) [CronTriggeringPolicy] ConfigurationScheduler schedules the task infinitely after first fire

[ https://issues.apache.org/jira/browse/LOG4J2-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451570#comment-15451570 ] Steffen Offermann commented on LOG4J2-1548: --- @[~garydgregory]: This is an extre

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451588#comment-15451588 ] Mikael Ståldal commented on LOG4J2-1349: There are still multiple implementations

Re: With the upcoming Scala support, shall we start investigating general polyglot support?

Could make sense. Otherwise people will probably create and use libraries like https://github.com/MicroUtils/kotlin-logging which links to SLF4J. On Tue, Aug 30, 2016 at 8:21 PM, Matt Sicker wrote: > I'm currently interesting in a few JVM languages, and besides Groovy, each > language seems to h

[jira] [Commented] (LOG4J2-1525) Convert Log4j 1 log4j.properties into equvivalent Log4j 2 config file

[ https://issues.apache.org/jira/browse/LOG4J2-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451705#comment-15451705 ] Mikael Ståldal commented on LOG4J2-1525: Proof-of-concept here: org.apache.log4j.

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451989#comment-15451989 ] Remko Popma commented on LOG4J2-1349: - Yes, these are the selected implementations th

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452009#comment-15452009 ] Mikael Ståldal commented on LOG4J2-1349: It should be possible to move all of the

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452024#comment-15452024 ] Mikael Ståldal commented on LOG4J2-1349: How does the selection of different Thre

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452032#comment-15452032 ] Remko Popma commented on LOG4J2-1349: - Actually, after thinking about this some more,

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452040#comment-15452040 ] Mikael Ståldal commented on LOG4J2-1349: Ideally, even DefaultThreadContextMap sh

[jira] [Commented] (LOG4J2-1548) [CronTriggeringPolicy] ConfigurationScheduler schedules the task infinitely after first fire

[ https://issues.apache.org/jira/browse/LOG4J2-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452244#comment-15452244 ] Ralph Goers commented on LOG4J2-1548: - It is very likely the 2.7 release will occur w

[jira] [Commented] (LOG4J2-1548) [CronTriggeringPolicy] ConfigurationScheduler schedules the task infinitely after first fire

[ https://issues.apache.org/jira/browse/LOG4J2-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452254#comment-15452254 ] Steffen Offermann commented on LOG4J2-1548: --- Thanks, Ralph. However, we'd much

[jira] [Commented] (LOG4J2-1548) [CronTriggeringPolicy] ConfigurationScheduler schedules the task infinitely after first fire

[ https://issues.apache.org/jira/browse/LOG4J2-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452270#comment-15452270 ] Mikael Ståldal commented on LOG4J2-1548: Can you elaborate a bit on which bad exp

[jira] [Commented] (LOG4J2-1548) [CronTriggeringPolicy] ConfigurationScheduler schedules the task infinitely after first fire

[ https://issues.apache.org/jira/browse/LOG4J2-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452288#comment-15452288 ] Steffen Offermann commented on LOG4J2-1548: --- I'd have to digest deeper for deta

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452362#comment-15452362 ] Remko Popma commented on LOG4J2-1349: - Conceptually these classes belong in the SPI p

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452366#comment-15452366 ] Remko Popma commented on LOG4J2-1349: - Sorry about that. Please see {{ThreadContext:

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452390#comment-15452390 ] Mikael Ståldal commented on LOG4J2-1349: Now it is clear. > Garbage-free ThreadC

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452403#comment-15452403 ] Mikael Ståldal commented on LOG4J2-1349: Making them package-private would be bet

[jira] [Commented] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452416#comment-15452416 ] Mikael Ståldal commented on LOG4J2-1447: The contract for the {{ContextData.asMap

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452427#comment-15452427 ] Mikael Ståldal commented on LOG4J2-1349: If {{ContextData.asMap()}} can return an

Re: With the upcoming Scala support, shall we start investigating general polyglot support?

I know Groovy already has a built-in feature that makes using Log4j 2 easier: http://docs.groovy-lang.org/latest/html/gapi/groovy/util/logging/Log4j2.html And that's pretty similar to the Lombok feature: https://projectlombok.org/features/Log.html On 31 August 2016 at 03:36, Mikael Ståldal wro

Scala module names

We have a naming inconsistency where we use a dash to separate the version number: log4-api-1.2 and the Scala modules use an underscore: log4j-api-scala_2.10 log4j-api-scala_2.11 Should we fix this? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate

Re: With the upcoming Scala support, shall we start investigating general polyglot support?

Then we probably not have to do anything for Groovy. But maybe for Kotlin. Another language to consider would be Clojure. On Wed, Aug 31, 2016 at 4:54 PM, Matt Sicker wrote: > I know Groovy already has a built-in feature that makes using Log4j 2 > easier: > > http://docs.groovy-lang.org/latest/

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452470#comment-15452470 ] Remko Popma commented on LOG4J2-1349: - Any change to the log4j-api module should be b

Re: Scala module names

No, there is a naming conventions for Scala modules which is like that, and we need to stick to it to be compatible with SBT (the most popular build tool for Scala projects). On Wed, Aug 31, 2016 at 5:01 PM, Gary Gregory wrote: > We have a naming inconsistency where we use a dash to separate the

[jira] [Commented] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452494#comment-15452494 ] Remko Popma commented on LOG4J2-1447: - Currently all implementations are mutable. I

[jira] [Commented] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452516#comment-15452516 ] Mikael Ståldal commented on LOG4J2-1447: See comment on LOG4J2-1349 for benefit o

[jira] [Commented] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452571#comment-15452571 ] Remko Popma commented on LOG4J2-1447: - If empty there is no need to instantiate, that

[jira] [Commented] (LOG4J2-1548) [CronTriggeringPolicy] ConfigurationScheduler schedules the task infinitely after first fire

[ https://issues.apache.org/jira/browse/LOG4J2-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452573#comment-15452573 ] Gary Gregory commented on LOG4J2-1548: -- Yes, change is risk and lots of changes comp

Re: With the upcoming Scala support, shall we start investigating general polyglot support?

I like the idea of Lombok and doing more with annotations and having to write less code as a user. Gary On Wed, Aug 31, 2016 at 8:03 AM, Mikael Ståldal wrote: > Then we probably not have to do anything for Groovy. But maybe for Kotlin. > > Another language to consider would be Clojure. > > On W

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452585#comment-15452585 ] Gary Gregory commented on LOG4J2-1349: -- Comming in late in the thread. I like the id

[jira] [Comment Edited] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452585#comment-15452585 ] Gary Gregory edited comment on LOG4J2-1349 at 8/31/16 3:47 PM:

Re: Scala module names

Check. Gary On Wed, Aug 31, 2016 at 8:04 AM, Mikael Ståldal wrote: > No, there is a naming conventions for Scala modules which is like that, > and we need to stick to it to be compatible with SBT (the most popular > build tool for Scala projects). > > On Wed, Aug 31, 2016 at 5:01 PM, Gary Grego

Failure in org.apache.logging.log4j.core.config.builder.ConfigurationBuilderTest.testXmlConstructing()

In Git master: I get a failure in Eclipse and Maven test on Windows with: org.apache.logging.log4j.core.config.builder.ConfigurationBuilderTest.testXmlConstructing() java.lang.AssertionError: Expected: Expected text value ' ' but was ' ' - comparing at /Configuration[1]/text()[1] to at /Conf

Re: Failure in org.apache.logging.log4j.core.config.builder.ConfigurationBuilderTest.testXmlConstructing()

I'm seeing the same error on the LOG4J2-1349 -gcfree-threadcontext branch. On Thu, Sep 1, 2016 at 1:22 AM, Gary Gregory wrote: > In Git master: > > I get a failure in Eclipse and Maven test on Windows with: > > org.apache.logging.log4j.core.conf

throw new RuntimeException(e);

We've got a few of these... not good. Surely there is a better exception checked or not we can use. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition

[jira] [Reopened] (LOG4J2-1528) Serialize configuration into a log4j2.xml file

[ https://issues.apache.org/jira/browse/LOG4J2-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reopened LOG4J2-1528: -- Broken unit test (on Windows 7 for me): {code:java} java.lang.AssertionError: Expected: Expected

[jira] [Comment Edited] (LOG4J2-1528) Serialize configuration into a log4j2.xml file

[ https://issues.apache.org/jira/browse/LOG4J2-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452907#comment-15452907 ] Gary Gregory edited comment on LOG4J2-1528 at 8/31/16 6:01 PM:

Jenkins build became unstable: Log4j 2.x #2237

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Created] (LOG4J2-1556) Custom Log4j threads should extend Log4jThread

Gary Gregory created LOG4J2-1556: Summary: Custom Log4j threads should extend Log4jThread Key: LOG4J2-1556 URL: https://issues.apache.org/jira/browse/LOG4J2-1556 Project: Log4j 2 Issue Type:

[jira] [Closed] (LOG4J2-1556) Custom Log4j threads should extend Log4jThread

[ https://issues.apache.org/jira/browse/LOG4J2-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1556. Resolution: Fixed In Git master. > Custom Log4j threads should extend Log4jThread > --

Jenkins build is back to stable : Log4j 2.x #2238

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Memory leak in TCP appender in odd case

We have this code in org.apache.logging.log4j.core.net.TcpSocketManager.TcpSocketManagerFactory.createManager(String, FactoryData): @Override public TcpSocketManager createManager(final String name, final FactoryData data) { InetAddress inetAddress; Output

Jenkins build became unstable: Log4j 2.x #2240

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: Memory leak in TCP appender in odd case

(Without looking at the code) I vaguely remember that class has a reconnect mechanism. Is the ByteArrayOutputStream used during the reconnect? Sent from my iPhone > On 2016/09/01, at 7:16, Gary Gregory wrote: > > We have this code in > org.apache.logging.log4j.core.net.TcpSocketManager.TcpSoc

Re: logging-log4j2 git commit: [LOG4J2-1553] AbstractManager should implement AutoCloseable.

Don't forget to delete the branch now that it's merged into master. (We should really do that for all branches after they are merged. Easy to forget otherwise...) Sent from my iPhone > On 2016/09/01, at 2:42, ggreg...@apache.org wrote: > > Repository: logging-log4j2 > Updated Branches: > refs

Fwd: logging-log4j2 git commit: Ignore Eclipse IDE files.

You should be able to just put these in the root .gitignore and it applies to all subdirectories. -- Forwarded message -- From: Date: 31 August 2016 at 16:40 Subject: logging-log4j2 git commit: Ignore Eclipse IDE files. To: comm...@logging.apache.org Repository: logging-log4j2 U

Re: throw new RuntimeException(e);

If it's just to rethrow a checked exception, it should use Throwables.rethrow(Throwable t). No exception wrapping is done in that method anymore thanks to an abuse of generics I found a couple months ago, so the stacktrace looks better. On 31 August 2016 at 11:29, Gary Gregory wrote: > We've got

Re: Scala module names

I'm also pretty sure we had this same exact discussion back when Mikael was naming the modules originally. On 31 August 2016 at 10:48, Gary Gregory wrote: > Check. > > Gary > > On Wed, Aug 31, 2016 at 8:04 AM, Mikael Ståldal > wrote: > >> No, there is a naming conventions for Scala modules whic

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454075#comment-15454075 ] Matt Sicker commented on LOG4J2-1349: - If you put a class in spi, it has to be BC. If

Re: With the upcoming Scala support, shall we start investigating general polyglot support?

The amount of support code Lombok has to abuse the annotation processor the way it does makes it seem like it should remain outside log4j. The lack of a need for Groovy-specific code is because Groovy is very similar to Java. Even without the annotations, you could do something like: class Foo {

Re: With the upcoming Scala support, shall we start investigating general polyglot support?

Oh, I almost forgot, there's a terrible way to abuse Groovy that causes performance problems, and I found this out by accident once: import static org.apache.logging.log4j.LogManager.logger def foo() { logger.debug("Hello, world!") } This calls LogManager.getLogger() for every use of "logger

Going to merge the AsyncAppender changes soon (LOG4J2-1430)

I've been pretty busy lately with work and life, so I haven't been able to do much outside of responding to random emails, so I haven't been able to finish that branch yet. However, the code is complete there, and the documentation I wanted to add is there in theory (all the info I need is in the t

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454229#comment-15454229 ] Remko Popma commented on LOG4J2-1349: - I'm thinking to move {{ArrayContextData}} to u

[jira] [Commented] (LOG4J2-1548) [CronTriggeringPolicy] ConfigurationScheduler schedules the task infinitely after first fire

[ https://issues.apache.org/jira/browse/LOG4J2-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454452#comment-15454452 ] Steffen Offermann commented on LOG4J2-1548: --- Thanks for your comment, Gary! A p