Re: OS-based dynamic configuration file

Great, thanks Ralph. Gary On Sun, Sep 18, 2016 at 11:14 PM, Ralph Goers wrote: > Yup to both. I’ll look at it tomorrow. > > Ralph > > On Sep 18, 2016, at 10:31 PM, Gary Gregory wrote: > > Nevermind, I can just overwrite the name in the Node's attribute map... > that works. I'd like a code revi

Jenkins build became unstable: Log4j 2.x #2331

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Commented] (LOG4J2-1593) Concrete Filter implementations should override equals and hashCode

[ https://issues.apache.org/jira/browse/LOG4J2-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502701#comment-15502701 ] Mikael Ståldal commented on LOG4J2-1593: Then we need to document that third-part

[jira] [Commented] (LOG4J2-1593) Concrete Filter implementations should override equals and hashCode

[ https://issues.apache.org/jira/browse/LOG4J2-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502717#comment-15502717 ] Remko Popma commented on LOG4J2-1593: - The alternative is to override equals on Abstr

[jira] [Commented] (LOG4J2-1593) Concrete Filter implementations should override equals and hashCode

[ https://issues.apache.org/jira/browse/LOG4J2-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502737#comment-15502737 ] Mikael Ståldal commented on LOG4J2-1593: OK, given the current implementation of

[jira] [Commented] (LOG4J2-1576) Better automated backwards compatibility checking

[ https://issues.apache.org/jira/browse/LOG4J2-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503530#comment-15503530 ] Remko Popma commented on LOG4J2-1576: - I started a thread on the revapi mailing list:

Fwd: logging-log4j2 git commit: [LOG4J2-1597]

When could the Configuration possibly be null? If you want to support required params via builders, I'd suggest adding the null check in the setter rather than in the build() method. During config file parsing (the usual method), the @Required annotation invokes a validator that also checks for non

Re: Fwd: logging-log4j2 git commit: [LOG4J2-1597]

On Sep 19, 2016 7:09 AM, "Matt Sicker" wrote: > > When could the Configuration possibly be null? Through programmatic configuration, if you force it or forget to set it. It seems simpler to centralize validation in one place. Gary If you want to support required params via builders, I'd sugges

Re: OS-based dynamic configuration file

I took a look and it looks OK to me. > On Sep 19, 2016, at 12:02 AM, Gary Gregory wrote: > > Great, thanks Ralph. > > Gary > > On Sun, Sep 18, 2016 at 11:14 PM, Ralph Goers > wrote: > Yup to both. I’ll look at it tomorrow. > > Ralph > >> On Sep 18, 2016, a

Re: OS-based dynamic configuration file

Ok, thank you. I'll merge in a couple of hours. Gary On Sep 19, 2016 2:22 PM, "Ralph Goers" wrote: > I took a look and it looks OK to me. > > On Sep 19, 2016, at 12:02 AM, Gary Gregory wrote: > > Great, thanks Ralph. > > Gary > > On Sun, Sep 18, 2016 at 11:14 PM, Ralph Goers > wrote: > >> Yup

Re: OS-based dynamic configuration file

Actually, I do have one minor issue. It will cause confusion calling it ScriptSelector. I am imagining the next step will be to create a LayoutSelector that uses Scripts. I can also imagine a Selector for AppenderRefs that uses Scripts. So calling it ScriptSelector is a bit ambiguous, unless i

Re: OS-based dynamic configuration file

ScriptSelectorAppender? On Sep 19, 2016 2:29 PM, "Ralph Goers" wrote: > Actually, I do have one minor issue. It will cause confusion calling it > ScriptSelector. I am imagining the next step will be to create a > LayoutSelector that uses Scripts. I can also imagine a Selector for > AppenderRefs

Re: OS-based dynamic configuration file

The 3 obvious choices: ScriptSelectorAppender, ScriptAppenderSelector, or AppenderScriptSelector. I actually prefer the second as it is an AppenderSelector that uses a Script (or rather, a Selector of an Appender that uses a Script). The first isn’t too bad as it is an Appender that is a Script

Re: OS-based dynamic configuration file

I am OK with ScriptAppenderSelector so I'll change it to that. Gary On Mon, Sep 19, 2016 at 3:23 PM, Ralph Goers wrote: > The 3 obvious choices: ScriptSelectorAppender, ScriptAppenderSelector, or > AppenderScriptSelector. I actually prefer the second as it is an > AppenderSelector that uses a S

[jira] [Updated] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1597: - Summary: Add a ScriptAppenderSelector to create an Appender specified by a Script (was: Add a Sc

[jira] [Updated] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1597: - Description: The use case is to create an OS-based dynamic configuration file. The script determ

[jira] [Resolved] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1597. -- Resolution: Fixed Fix Version/s: 2.7 In Git master. > Add a ScriptAppenderSelector to c

Re: OS-based dynamic configuration file

Branch LOG4J2-1597 merged in Git master; tracked with https://issues.apache.org/jira/browse/LOG4J2-1597. I'll delete the LOG4J2-1597 branch soon. Gary On Mon, Sep 19, 2016 at 4:55 PM, Gary Gregory wrote: > I am OK with ScriptAppenderSelector so I'll change it to that. > > Gary > > On Mon, Sep 1

[jira] [Closed] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1597. Closing: In Git master. > Add a ScriptAppenderSelector to create an Appender specified by a Script > -

[jira] [Created] (LOG4J2-1598) Update Jackson from 2.8.2 to 2.8.3

Gary Gregory created LOG4J2-1598: Summary: Update Jackson from 2.8.2 to 2.8.3 Key: LOG4J2-1598 URL: https://issues.apache.org/jira/browse/LOG4J2-1598 Project: Log4j 2 Issue Type: Improvement

Jenkins build is back to stable : Log4j 2.x #2332

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Closed] (LOG4J2-1598) Update Jackson from 2.8.2 to 2.8.3

[ https://issues.apache.org/jira/browse/LOG4J2-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1598. Resolution: Fixed Fix Version/s: 2.7 In Git master. > Update Jackson from 2.8.2 to 2.8.3 >

Re: logging-log4j2 git commit: Add missing license headers

Thank you! Sorry I missed that. Sent from my iPhone > On 2016/09/20, at 9:31, rgo...@apache.org wrote: > > Repository: logging-log4j2 > Updated Branches: > refs/heads/LOG4J2-1597 21ac645e0 -> 4a5f2b70d > > > Add missing license headers > > > Project: http://git-wip-us.apache.org/repos/asf/

Re: logging-log4j2 git commit: Add missing license headers

Too bad I did it to the wrong branch. Just added them again to master. Ralph > On Sep 19, 2016, at 7:39 PM, Remko Popma wrote: > > Thank you! Sorry I missed that. > > Sent from my iPhone > >> On 2016/09/20, at 9:31, rgo...@apache.org wrote: >> >> Repository: logging-log4j2 >> Updated Branch

[jira] [Created] (LOG4J2-1599) NPE in org.apache.logging.log4j.message.ParameterFormatter.formatMessage3(StringBuilder, char[], int, Object[], int, int[])

Gary Gregory created LOG4J2-1599: Summary: NPE in org.apache.logging.log4j.message.ParameterFormatter.formatMessage3(StringBuilder, char[], int, Object[], int, int[]) Key: LOG4J2-1599 URL: https://issues.apache.o

[jira] [Commented] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505464#comment-15505464 ] Remko Popma commented on LOG4J2-1597: - About the Appenders manual page documentation

[jira] [Commented] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505539#comment-15505539 ] Gary Gregory commented on LOG4J2-1597: -- I tweaked the example. > Add a ScriptAppend

Fwd: logging-log4j2 git commit: Add logo for 2.7 release

Nice choice :-) Gary -- Forwarded message -- From: Date: Mon, Sep 19, 2016 at 10:01 PM Subject: logging-log4j2 git commit: Add logo for 2.7 release To: comm...@logging.apache.org Repository: logging-log4j2 Updated Branches: refs/heads/master 62c5e9e9f -> 166bc6574 Add logo f

Re: logging-log4j2 git commit: Add logo for 2.7 release

Thanks. First release build failed due to check-ins while it was running :-( Ralph > On Sep 19, 2016, at 10:18 PM, Gary Gregory wrote: > > Nice choice :-) > > Gary > -- Forwarded message -- > From: mailto:rgo...@apache.org>> > Date: Mon, Sep 19, 2016 at 10:01 PM > Subject: logg

Re: logging-log4j2 git commit: Add logo for 2.7 release

Boo :-( I am done for today here FWIW. Gary On Mon, Sep 19, 2016 at 10:37 PM, Ralph Goers wrote: > Thanks. First release build failed due to check-ins while it was running > :-( > > Ralph > > On Sep 19, 2016, at 10:18 PM, Gary Gregory wrote: > > Nice choice :-) > > Gary > -- Forwarded

ThreadContextMapFilter performance

I started the release process tonight but stopped it when I noticed that the FilterPerformanceComparison test is now taking over 200 seconds to complete. Where it used to be faster than Logback it is now from 3 to 60 times slower depending on the number of threads. I am assuming this is due to