Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Johannes Schleger
May it be possible to integrate the third patch from Log4j2-1506? Then I would be happy too with the release. Johannes

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Remko Popma
Johannes, We are currently reviewing whether the artifacts or the web site for this release candidate has any showstoppers. If showstoppers are found and we need to rebuild and repackage anyway we can consider merging other patches. Otherwise it will be the next release. Generally I try to gi

[jira] [Commented] (LOG4J2-1161) Builder like pattern to add values to MapMessage

2016-09-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528758#comment-15528758 ] Mikael Ståldal commented on LOG4J2-1161: Yes. > Builder like pattern to add valu

[jira] [Reopened] (LOG4J2-1161) Builder like pattern to add values to MapMessage

2016-09-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal reopened LOG4J2-1161: > Builder like pattern to add values to MapMessage > --

[jira] [Closed] (LOG4J2-1161) Builder like pattern to add values to MapMessage

2016-09-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal closed LOG4J2-1161. -- > Builder like pattern to add values to MapMessage > --

[jira] [Resolved] (LOG4J2-1161) Builder like pattern to add values to MapMessage

2016-09-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal resolved LOG4J2-1161. Resolution: Fixed > Builder like pattern to add values to MapMessage >

[jira] [Updated] (LOG4J2-1161) Builder like pattern to add values to MapMessage

2016-09-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal updated LOG4J2-1161: --- Fix Version/s: 2.5 > Builder like pattern to add values to MapMessage > -

[jira] [Commented] (LOG4J2-1390) Remove workaround for Kafka close timeout

2016-09-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528831#comment-15528831 ] Mikael Ståldal commented on LOG4J2-1390: Not really since this issue is not fixed

[jira] [Commented] (LOG4J2-1395) Add "direct" option to ConsoleAppender for increased performance

2016-09-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528837#comment-15528837 ] Mikael Ståldal commented on LOG4J2-1395: Yes. > Add "direct" option to ConsoleAp

[jira] [Commented] (LOG4J2-1395) Add "direct" option to ConsoleAppender for increased performance

2016-09-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528840#comment-15528840 ] Mikael Ståldal commented on LOG4J2-1395: I still don't think this is an issue wit

[jira] [Created] (LOG4J2-1616) Cab´t define dynamic appName in Syslog Appender using Mdc values

2016-09-28 Thread Joaquin Diez (JIRA)
Joaquin Diez created LOG4J2-1616: Summary: Cab´t define dynamic appName in Syslog Appender using Mdc values Key: LOG4J2-1616 URL: https://issues.apache.org/jira/browse/LOG4J2-1616 Project: Log4j 2

[jira] [Updated] (LOG4J2-1616) Can´t define dynamic appName in Syslog Appender using Mdc values

2016-09-28 Thread Joaquin Diez (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joaquin Diez updated LOG4J2-1616: - Summary: Can´t define dynamic appName in Syslog Appender using Mdc values (was: Cab´t define dyn

[jira] [Updated] (LOG4J2-1616) Can´t define dynamic appName in Syslog Appender using Mdc values

2016-09-28 Thread Joaquin Diez (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joaquin Diez updated LOG4J2-1616: - Description: I need to define the value of the appName based on the user logged in the system.

[jira] [Updated] (LOG4J2-1616) Can´t define dynamic appName in Syslog Appender using Mdc values

2016-09-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1616: Description: I need to define the value of the appName based on the user logged in the system. Wh

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Matt Sicker
+1 Works with my application, compiles and tests fine from git (Java 1.8), gpg sigs are all good, log4j-bom looks good, manifest looks good. Note that there are no links to the Scala components on the left sidebar, but that can be updated directly on svn. Same goes on the javadocs page. There is

[jira] [Commented] (LOG4J2-1614) Package attribute for discovering custom plugins within jars fails

2016-09-28 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529720#comment-15529720 ] Matt Sicker commented on LOG4J2-1614: - Yeah, that looks like a probable duplicate. >

[jira] [Resolved] (LOG4J2-1614) Package attribute for discovering custom plugins within jars fails

2016-09-28 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker resolved LOG4J2-1614. - Resolution: Duplicate > Package attribute for discovering custom plugins within jars fails >

[jira] [Created] (LOG4J2-1617) PatternLayout Exception handling with filter

2016-09-28 Thread JIRA
Zoltán Nébli created LOG4J2-1617: Summary: PatternLayout Exception handling with filter Key: LOG4J2-1617 URL: https://issues.apache.org/jira/browse/LOG4J2-1617 Project: Log4j 2 Issue Type: Bu

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Mikael Ståldal
I fixed the Kafka issue and pushed it to master branch. However, I have another concern, what timeout value is actually passed in to AbstractManager.releaseSub ? On Wed, Sep 28, 2016 at 3:51 PM, Mikael Ståldal wrote: > -1 since the Kafka appender now only works with Kafka client (and thus > ser

[jira] [Commented] (LOG4J2-1235) org.apache.logging.log4j.core.appender.routing.IdlePurgePolicy not working correctly

2016-09-28 Thread Sascha Scholz (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529913#comment-15529913 ] Sascha Scholz commented on LOG4J2-1235: --- I just checked that the issue with the Rol

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Gary Gregory
I do not think it makes sense to support old versions that are not even 1.0. Gary On Wed, Sep 28, 2016 at 7:42 AM, Mikael Ståldal wrote: > I fixed the Kafka issue and pushed it to master branch. > > However, I have another concern, what timeout value is actually passed in > to AbstractManager.r

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Mikael Ståldal
Kafka server 0.8 is still in use, and newer Kafka clients cannot connect to older Kafka servers. On Wed, Sep 28, 2016 at 5:10 PM, Gary Gregory wrote: > I do not think it makes sense to support old versions that are not even > 1.0. > > Gary > > On Wed, Sep 28, 2016 at 7:42 AM, Mikael Ståldal > w

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Gary Gregory
On Wed, Sep 28, 2016 at 7:42 AM, Mikael Ståldal wrote: > I fixed the Kafka issue and pushed it to master branch. > > However, I have another concern, what timeout value is actually passed in > to AbstractManager.releaseSub ? > releaseSub() is called by org.apache.logging.log4j.core.appender.Abst

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Gary Gregory
On Wed, Sep 28, 2016 at 8:13 AM, Mikael Ståldal wrote: > Kafka server 0.8 is still in use, and newer Kafka clients cannot connect > to older Kafka servers. > There will always be users of old software. That does not mean that new versions of Log4j must support old software, especially pre-1.0 so

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Remko Popma
I am in favour of having these few lines of extra code if it enables people who for some reason cannot upgrade their Kafka server to use Log4j 2. There is no drawback for us, and it can be a huge help to users. On Thu, Sep 29, 2016 at 12:24 AM, Gary Gregory wrote: > On Wed, Sep 28, 2016 at 8:13

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Mikael Ståldal
We have already discussed this here: https://issues.apache.org/jira/browse/LOG4J2-1390 I don't think the release process is the right occasion to reopen this discussion. Can we please keep the Kafka 0.8 compatibility for this release, and then possibly reopen this discussion after the release (and

[jira] [Commented] (LOG4J2-1235) org.apache.logging.log4j.core.appender.routing.IdlePurgePolicy not working correctly

2016-09-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529997#comment-15529997 ] Remko Popma commented on LOG4J2-1235: - Sasha, I thought you verified that master work

Jenkins build is back to stable : Log4j 2.x #2389

2016-09-28 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Comment Edited] (LOG4J2-1235) org.apache.logging.log4j.core.appender.routing.IdlePurgePolicy not working correctly

2016-09-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529997#comment-15529997 ] Remko Popma edited comment on LOG4J2-1235 at 9/28/16 3:33 PM: -

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Mikael Ståldal
I see that KafkaManager.releaseSub() is passed a timeout of 0 at runtime, which is not very useful. How is this actually supposed to be used? How can you make it get something else than 0? On Wed, Sep 28, 2016 at 5:33 PM, Mikael Ståldal wrote: > We have already discussed this here: https://issue

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Gary Gregory
It is used when you call LifeCycle2.stop(long, TimeUnit), like stopping a LoggerContext or all of Log4j through the shutdown() method. Gary On Wed, Sep 28, 2016 at 8:35 AM, Mikael Ståldal wrote: > I see that KafkaManager.releaseSub() is passed a timeout of 0 at runtime, > which is not very usef

[jira] [Closed] (LOG4J2-1297) Document "gc-free" configuration and performance

2016-09-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-1297. --- > Document "gc-free" configuration and performance > > >

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Mikael Ståldal
To track this, I temporary added this to KafkaManager.releaseSub(): LOGGER.info("releaseSub: timeout=" + timeout + " " + timeUnit.toString(), new Throwable()); and I get: 2016-09-28 17:43:14,382 pool-1-thread-1 INFO releaseSub: timeout=0 MILLISECONDS java.lang.Throwable at org.apache.lo

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Mikael Ståldal
Was this timeout thing implemented as part of any JIRA issue? On Wed, Sep 28, 2016 at 5:49 PM, Mikael Ståldal wrote: > To track this, I temporary added this to KafkaManager.releaseSub(): > LOGGER.info("releaseSub: timeout=" + timeout + " " + timeUnit.toString(), new > Throwable()); > > and I get

[jira] [Commented] (LOG4J2-928) Lock-free synchronous sub-microsecond appender

2016-09-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530043#comment-15530043 ] Remko Popma commented on LOG4J2-928: Linking this issue to the binary layout. It will

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Ralph Goers
I don’t know what is going on with my email but I never saw your -1 email. Obviously, I see it now. I agree that we should not be breaking compatibility like this. Ralph > On Sep 28, 2016, at 7:42 AM, Mikael Ståldal wrote: > > I fixed the Kafka issue and pushed it to master branch. > > Howev

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Ralph Goers
I don’t recall but he did mention it on the dev list. As I recall he decided we needed to add timeouts to all the stop calls to make sure shutdown doesn’t hang. Ralph > On Sep 28, 2016, at 8:51 AM, Mikael Ståldal wrote: > > Was this timeout thing implemented as part of any JIRA issue? > > On

[jira] [Closed] (LOG4J2-930) Improve PatternLayout performance

2016-09-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-930. -- Resolution: Later I am postponing further effort to improve PatternLayout performance. I think most of

[VOTE][CANCELLED] Release Log4j 2.7-rc1

2016-09-28 Thread Ralph Goers
This vote is cancelled due to the compatibility breakage with the Kafka appender. Ralph > On Sep 26, 2016, at 8:50 AM, Ralph Goers wrote: > > This is a vote to release Log4j 2.6.2, the next version of the Log4j 2 > project. > > Please download, test, and cast your votes on the log4j develope

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Remko Popma
I also did not see Mikael's -1 email... Strange. I agree we should not break compatibility like this. On Thu, Sep 29, 2016 at 12:55 AM, Ralph Goers wrote: > I don’t know what is going on with my email but I never saw your -1 email. > Obviously, I see it now. > > I agree that we should not be bre

[jira] [Resolved] (LOG4J2-1506) Unregister JMX ignores log4j2.disable.jmx property

2016-09-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1506. - Resolution: Fixed Assignee: Remko Popma Applied 0003-JMX-Server-unregistering-won-t-ignore-

[jira] [Comment Edited] (LOG4J2-1506) Unregister JMX ignores log4j2.disable.jmx property

2016-09-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530146#comment-15530146 ] Remko Popma edited comment on LOG4J2-1506 at 9/28/16 4:28 PM: -

pruning old branches

2016-09-28 Thread Remko Popma
Can any of these branches be deleted? origin/2.0-beta1 (Ralph) origin/AutoCloseableLock (Gary) origin/StyledMessage (Gary) origin/StyledXException (Gary) origin/level-logger (Gary) origin/new-levels (Gary) origin/scala-fast-location (Mikael) origin/updated-site-2.0.2 (Matt)

Re: [VOTE] Release Log4j 2.7-rc1

2016-09-28 Thread Gary Gregory
On Wed, Sep 28, 2016 at 8:51 AM, Mikael Ståldal wrote: > Was this timeout thing implemented as part of any JIRA issue? > The high level ticket is: https://issues.apache.org/jira/browse/LOG4J2-1539 Gary > > On Wed, Sep 28, 2016 at 5:49 PM, Mikael Ståldal > wrote: > >> To track this, I tempora

Fwd: logging-log4j2 git commit: LOG4J2-1506 patch by Johannes Schleger to catch Throwable instead of Exception

2016-09-28 Thread Gary Gregory
-1: It's rarely a good idea to catch Throwable. I doubt you want to catch OutOfMemoryError for example. Just say what you want to catch in a mutli-catch. In this case, catch NoClassDefFoundError and Exception. In fact, since we need to deal with Android and Google App Engine restrictions in a few

Re: logging-log4j2 git commit: LOG4J2-1506 patch by Johannes Schleger to catch Throwable instead of Exception

2016-09-28 Thread Remko Popma
While I agree with you on the principle that catching Throwable is rarely a good idea, I argue that this is one of the exceptions to the rule: We want to unregister a LoggerContext, but if this fails we want to continue since failing to unregister a JMX MBean should not prevent Log4j from workin

Re: logging-log4j2 git commit: LOG4J2-1506 patch by Johannes Schleger to catch Throwable instead of Exception

2016-09-28 Thread Gary Gregory
On Wed, Sep 28, 2016 at 10:18 AM, Remko Popma wrote: > While I agree with you on the principle that catching Throwable is rarely > a good idea, I argue that this is one of the exceptions to the rule: > > We want to unregister a LoggerContext, but if this fails we want to > continue since failing

Jenkins build became unstable: Log4j 2.x #2390

2016-09-28 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: pruning old branches

2016-09-28 Thread Matt Sicker
updated-site-2.0.2 can definitely be deleted. On 28 September 2016 at 11:48, Remko Popma wrote: > Can any of these branches be deleted? > > origin/2.0-beta1 (Ralph) > origin/AutoCloseableLock (Gary) > origin/StyledMessage (Gary) > origin/StyledXException (Gary) > origin/level-logger (G

Re: pruning old branches

2016-09-28 Thread Gary Gregory
Please keep: origin/AutoCloseableLock (Gary) origin/level-logger (Gary) origin/new-levels (Gary) Please delete: origin/StyledMessage (Gary) origin/StyledXException (Gary) Thank you for tidy up. Gary On Wed, Sep 28, 2016 at 9:48 AM, Remko Popma wrote: > Can any of these branches be

Re: pruning old branches

2016-09-28 Thread Gary Gregory
[wi-fi problems, resending] Please keep: origin/AutoCloseableLock (Gary) origin/level-logger (Gary) origin/new-levels (Gary) Please delete: origin/StyledMessage (Gary) origin/StyledXException (Gary) Thank you for tidy up. Gary On Wed, Sep 28, 2016 at 9:48 AM, Remko Popma wrote: >

Jenkins build is still unstable: Log4j 2.x #2391

2016-09-28 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Created] (LOG4J2-1618) JVM shutdown fails with ClassCastException on SimpleLogger to Logger

2016-09-28 Thread Raman Gupta (JIRA)
Raman Gupta created LOG4J2-1618: --- Summary: JVM shutdown fails with ClassCastException on SimpleLogger to Logger Key: LOG4J2-1618 URL: https://issues.apache.org/jira/browse/LOG4J2-1618 Project: Log4j 2

[jira] [Updated] (LOG4J2-1618) JVM shutdown fails with ClassCastException on SimpleLogger to Logger

2016-09-28 Thread Raman Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raman Gupta updated LOG4J2-1618: Description: Apparently the fix for https://issues.apache.org/jira/browse/LOG4J2-1222 is causing a

[jira] [Updated] (LOG4J2-1618) JVM shutdown fails with ClassCastException on SimpleLogger to Logger

2016-09-28 Thread Raman Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raman Gupta updated LOG4J2-1618: Description: Apparently the fix for https://issues.apache.org/jira/browse/LOG4J2-1222 is causing a

[jira] [Commented] (LOG4J2-1222) Initializing Logger during JVM shutdown fails with FATAL error

2016-09-28 Thread Raman Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530885#comment-15530885 ] Raman Gupta commented on LOG4J2-1222: - The fix for this seems to have created a new i

[jira] [Updated] (LOG4J2-1618) JVM shutdown fails with ClassCastException on SimpleLogger to Logger

2016-09-28 Thread Raman Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raman Gupta updated LOG4J2-1618: Description: Apparently the fix for https://issues.apache.org/jira/browse/LOG4J2-1222 is causing a

[jira] [Commented] (LOG4J2-1222) Initializing Logger during JVM shutdown fails with FATAL error

2016-09-28 Thread Raman Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530888#comment-15530888 ] Raman Gupta commented on LOG4J2-1222: - Created https://issues.apache.org/jira/browse/

[jira] [Updated] (LOG4J2-1618) ClassCastException at shutdown with JUL: casting SimpleLogger to Logger

2016-09-28 Thread Raman Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raman Gupta updated LOG4J2-1618: Summary: ClassCastException at shutdown with JUL: casting SimpleLogger to Logger (was: JVM shutdow

Re: logging-log4j2 git commit: LOG4J2-1506 patch by Johannes Schleger to catch Throwable instead of Exception

2016-09-28 Thread Gary Gregory
On Wed, Sep 28, 2016 at 10:23 AM, Gary Gregory wrote: > On Wed, Sep 28, 2016 at 10:18 AM, Remko Popma > wrote: > >> While I agree with you on the principle that catching Throwable is rarely >> a good idea, I argue that this is one of the exceptions to the rule: >> >> We want to unregister a Logg

Re: logging-log4j2 git commit: LOG4J2-1506 patch by Johannes Schleger to catch Throwable instead of Exception

2016-09-28 Thread Matt Sicker
Narrowing it to LinkageError makes sense, go for it! On 28 September 2016 at 17:09, Gary Gregory wrote: > On Wed, Sep 28, 2016 at 10:23 AM, Gary Gregory > wrote: > >> On Wed, Sep 28, 2016 at 10:18 AM, Remko Popma >> wrote: >> >>> While I agree with you on the principle that catching Throwable

Re: logging-log4j2 git commit: LOG4J2-1506 patch by Johannes Schleger to catch Throwable instead of Exception

2016-09-28 Thread Remko Popma
Hm, ok. OutOfMemoryError may actually be recoverable if GC occurs, but ThreadDeath is probably not something we want to catch without rethrowing. Agree it's better to narrow it down to Exception|LinkageError. Sent from my iPhone > On 29 Sep 2016, at 2:23, Gary Gregory wrote: > >> On Wed, Se

Re: logging-log4j2 git commit: LOG4J2-1506 patch by Johannes Schleger to catch Throwable instead of Exception

2016-09-28 Thread Gary Gregory
On Wed, Sep 28, 2016 at 3:43 PM, Remko Popma wrote: > Hm, ok. > OutOfMemoryError may actually be recoverable if GC occurs, but ThreadDeath > is probably not something we want to catch without rethrowing. Agree it's > better to narrow it down to Exception|LinkageError. > Will do... Gary > > Se

[jira] [Created] (LOG4J2-1619) new Log4jLogEvent().toString() throws an NPE

2016-09-28 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1619: Summary: new Log4jLogEvent().toString() throws an NPE Key: LOG4J2-1619 URL: https://issues.apache.org/jira/browse/LOG4J2-1619 Project: Log4j 2 Issue Type: Bu

[jira] [Closed] (LOG4J2-1619) new Log4jLogEvent().toString() throws an NPE

2016-09-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1619. Resolution: Fixed In Git master. > new Log4jLogEvent().toString() throws an NPE >

Re: logging-log4j2 git commit: LOG4J2-1506 patch by Johannes Schleger to catch Throwable instead of Exception

2016-09-28 Thread Gary Gregory
On Wed, Sep 28, 2016 at 3:47 PM, Gary Gregory wrote: > On Wed, Sep 28, 2016 at 3:43 PM, Remko Popma > wrote: > >> Hm, ok. >> OutOfMemoryError may actually be recoverable if GC occurs, but >> ThreadDeath is probably not something we want to catch without rethrowing. >> Agree it's better to narrow

Jenkins build is back to stable : Log4j 2.x #2392

2016-09-28 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Commented] (LOG4J2-1618) ClassCastException at shutdown with JUL: casting SimpleLogger to Logger

2016-09-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531608#comment-15531608 ] Gary Gregory commented on LOG4J2-1618: -- [~rocketraman]: Thank you for your report.

[jira] [Comment Edited] (LOG4J2-1618) ClassCastException at shutdown with JUL: casting SimpleLogger to Logger

2016-09-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531608#comment-15531608 ] Gary Gregory edited comment on LOG4J2-1618 at 9/29/16 2:50 AM:

Jenkins build became unstable: Log4j 2.x #2394

2016-09-28 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Created] (LOG4J2-1620) 2.7-rc1: RollingFileAppender immediateFlush default value changed

2016-09-28 Thread Sascha Scholz (JIRA)
Sascha Scholz created LOG4J2-1620: - Summary: 2.7-rc1: RollingFileAppender immediateFlush default value changed Key: LOG4J2-1620 URL: https://issues.apache.org/jira/browse/LOG4J2-1620 Project: Log4j 2

[jira] [Commented] (LOG4J2-1235) org.apache.logging.log4j.core.appender.routing.IdlePurgePolicy not working correctly

2016-09-28 Thread Sascha Scholz (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531942#comment-15531942 ] Sascha Scholz commented on LOG4J2-1235: --- The original issue is fixed, but an unrela

Jenkins build is back to stable : Log4j 2.x #2395

2016-09-28 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org