[jira] [Commented] (LOG4J2-1724) Using variables in GelfLayout's additional fields at runtime

2017-01-06 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804295#comment-15804295 ] Mikael Ståldal commented on LOG4J2-1724: [~alexkra] Do you have a full name to be

[jira] [Commented] (LOG4J2-1640) RollingFileAppender with CronTriggeringPolicy broken?

2017-01-06 Thread Chris McGee (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804630#comment-15804630 ] Chris McGee commented on LOG4J2-1640: - Thanks, that was the push that I needed. I've

[jira] [Commented] (LOG4J2-1640) RollingFileAppender with CronTriggeringPolicy broken?

2017-01-06 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804788#comment-15804788 ] Ralph Goers commented on LOG4J2-1640: - Yes, please post the latest trace output and s

[jira] [Comment Edited] (LOG4J2-1640) RollingFileAppender with CronTriggeringPolicy broken?

2017-01-06 Thread Chris McGee (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804832#comment-15804832 ] Chris McGee edited comment on LOG4J2-1640 at 1/6/17 3:48 PM: -

[jira] [Commented] (LOG4J2-1640) RollingFileAppender with CronTriggeringPolicy broken?

2017-01-06 Thread Chris McGee (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804832#comment-15804832 ] Chris McGee commented on LOG4J2-1640: - To keep this bug report from becoming ungodly-

[jira] [Comment Edited] (LOG4J2-1640) RollingFileAppender with CronTriggeringPolicy broken?

2017-01-06 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804788#comment-15804788 ] Ralph Goers edited comment on LOG4J2-1640 at 1/6/17 4:40 PM: -

[jira] [Created] (LOG4J2-1769) JsonLayout Throwing Exceptions And Producing Broken Logs

2017-01-06 Thread Brandon Goodin (JIRA)
Brandon Goodin created LOG4J2-1769: -- Summary: JsonLayout Throwing Exceptions And Producing Broken Logs Key: LOG4J2-1769 URL: https://issues.apache.org/jira/browse/LOG4J2-1769 Project: Log4j 2

[jira] [Updated] (LOG4J2-1769) JsonLayout Throwing Exceptions And Producing Broken Logs

2017-01-06 Thread Brandon Goodin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Goodin updated LOG4J2-1769: --- Attachment: JSONLayoutIssuesTest.java Test that displays the exceptions and broken logs. > J

[jira] [Updated] (LOG4J2-1769) JsonLayout Throwing Exceptions And Producing Broken Logs

2017-01-06 Thread Brandon Goodin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Goodin updated LOG4J2-1769: --- Attachment: log4j2.xml log4j2.xml file that can be used in conjunction with unit test to disp

[jira] [Updated] (LOG4J2-1769) JsonLayout Throwing Exceptions And Producing Broken Logs

2017-01-06 Thread Brandon Goodin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Goodin updated LOG4J2-1769: --- Attachment: (was: JSONLayoutIssuesTest.java) > JsonLayout Throwing Exceptions And Produci

[jira] [Updated] (LOG4J2-1769) JsonLayout Throwing Exceptions And Producing Broken Logs

2017-01-06 Thread Brandon Goodin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Goodin updated LOG4J2-1769: --- Attachment: RequestStatistic.java JSONLayoutIssuesTest.java Unit test and sim

[jira] [Issue Comment Deleted] (LOG4J2-1769) JsonLayout Throwing Exceptions And Producing Broken Logs

2017-01-06 Thread Brandon Goodin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Goodin updated LOG4J2-1769: --- Comment: was deleted (was: Unit test and simple bean class that is used for reproducing the i

[jira] [Issue Comment Deleted] (LOG4J2-1769) JsonLayout Throwing Exceptions And Producing Broken Logs

2017-01-06 Thread Brandon Goodin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Goodin updated LOG4J2-1769: --- Comment: was deleted (was: Test that displays the exceptions and broken logs.) > JsonLayout

[jira] [Issue Comment Deleted] (LOG4J2-1769) JsonLayout Throwing Exceptions And Producing Broken Logs

2017-01-06 Thread Brandon Goodin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Goodin updated LOG4J2-1769: --- Comment: was deleted (was: log4j2.xml file that can be used in conjunction with unit test to

[jira] [Created] (LOG4J2-1770) Add builder for JDBC appender

2017-01-06 Thread Matt Sicker (JIRA)
Matt Sicker created LOG4J2-1770: --- Summary: Add builder for JDBC appender Key: LOG4J2-1770 URL: https://issues.apache.org/jira/browse/LOG4J2-1770 Project: Log4j 2 Issue Type: Improvement

Generic plugin builder classes problem

2017-01-06 Thread Matt Sicker
So I've noticed that although everything compiles correctly, IntelliJ has difficulty understanding the generics going on in the hierarchy of builder classes. If you use methods from the parent in a chain, it returns the wrong class, though this doesn't really matter to the compiled code due to type

[jira] [Assigned] (LOG4J2-1769) JsonLayout Throwing Exceptions And Producing Broken Logs

2017-01-06 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1769: --- Assignee: Remko Popma > JsonLayout Throwing Exceptions And Producing Broken Logs > -

Re: logging-log4j2 git commit: Extract isEmpty() logic from RequiredValidator

2017-01-06 Thread Remko Popma
Instead of Map::isEmpty, we could do Collection::isEmpty. Also is it a good idea to call Iterator::hasNext? In some implementations calling this method moves the cursor one position forward. Do we actually need to check that an Iterator is empty anywhere? Sent from my iPhone > On Jan 7, 2017,

Re: Generic plugin builder classes problem

2017-01-06 Thread Matt Sicker
After all that, actually, I think I found a much simpler way to fix this problem, and it allows for arbitrary ordering of the builder chain while still working properly. The old factory methods just need to add a generic signature as well: public static > MockAppender createAppender(...) { retur

Re: logging-log4j2 git commit: Extract isEmpty() logic from RequiredValidator

2017-01-06 Thread Matt Sicker
Map doesn't implement collection. And the Iterator::hasNext is called on a new Iterator obtained from the Iterable. It was implemented as a Collection before, but I had a thought and implemented it as such. The javadocs for Iterable don't exactly state whether or not the Iterator is a singleton, bu

Re: logging-log4j2 git commit: Extract isEmpty() logic from RequiredValidator

2017-01-06 Thread Matt Sicker
In the JDK, only a couple classes directly implement Iterable: Path, DirectoryStream, and Collection. DirectoryStream has a note that it doesn't support calling iterator() more than once, so I guess this is a possibility. I'll change it back to Collection. On 6 January 2017 at 22:52, Matt Sicker

Jenkins build is back to stable : Log4j 2.x #2571

2017-01-06 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Closed] (LOG4J2-1770) Add builder for JDBC appender

2017-01-06 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker closed LOG4J2-1770. --- Resolution: Fixed Added to master. > Add builder for JDBC appender > - >

[jira] [Commented] (LOG4J2-1640) RollingFileAppender with CronTriggeringPolicy broken?

2017-01-06 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806849#comment-15806849 ] Ralph Goers commented on LOG4J2-1640: - Did you change your system's clock while the t

[jira] [Created] (LOG4J2-1771) Add Builder for ColumnConfig

2017-01-06 Thread Matt Sicker (JIRA)
Matt Sicker created LOG4J2-1771: --- Summary: Add Builder for ColumnConfig Key: LOG4J2-1771 URL: https://issues.apache.org/jira/browse/LOG4J2-1771 Project: Log4j 2 Issue Type: Improvement

Re: Generic plugin builder classes problem

2017-01-06 Thread Remko Popma
You did scare me there for a bit... :-) Sent from my iPhone > On Jan 7, 2017, at 13:40, Matt Sicker wrote: > > After all that, actually, I think I found a much simpler way to fix this > problem, and it allows for arbitrary ordering of the builder chain while > still working properly. The old

[jira] [Closed] (LOG4J2-1771) Add Builder for ColumnConfig

2017-01-06 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker closed LOG4J2-1771. --- Resolution: Fixed Added to master. > Add Builder for ColumnConfig > > >

Jenkins build became unstable: Log4j 2.x #2572

2017-01-06 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Commented] (LOG4J2-1640) RollingFileAppender with CronTriggeringPolicy broken?

2017-01-06 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806994#comment-15806994 ] Ralph Goers commented on LOG4J2-1640: - At midnight the properly rolled over file was

Jenkins build is still unstable: Log4j 2.x #2573

2017-01-06 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: Jenkins build is still unstable: Log4j 2.x #2573

2017-01-06 Thread Matt Sicker
Fixed. On 7 January 2017 at 01:12, Apache Jenkins Server wrote: > See > > > - > To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org > For additional commands, e-ma