Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Mikael Ståldal
+1 Works for me. But there are some issues with https://issues.apache.org/j ira/browse/LOG4J2-1733 We need to include a note about that in the release notes. On Sun, Jan 22, 2017 at 7:08 AM, Ralph Goers wrote: > This is a vote to release Log4j 2.8 the next version of the Log4j 2 > project. > >

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Apache
+1 from me. Ralph > On Jan 21, 2017, at 11:08 PM, Ralph Goers wrote: > > This is a vote to release Log4j 2.8 the next version of the Log4j 2 project. > > Please download, test, and cast your votes on the log4j developers list. > [] +1, release the artifacts > [] -1, don't release because... >

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Remko Popma
+1 Site looks good, RAT checks good, md5 and sha1 checksums good. Sent from my iPhone > On Jan 22, 2017, at 15:08, Ralph Goers wrote: > > This is a vote to release Log4j 2.8 the next version of the Log4j 2 project. > > Please download, test, and cast your votes on the log4j developers list. >

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Matt Sicker
Broken links: http://rgoers.github.io/log4j2-site/faq.html#exclusions (not sure how that happened there) We have some interesting dependency convergence "issues", but it appears to be mostly test related: http://rgoers.github.io/log4j2-site/dependency-convergence.html Technically, an ASL2.0 heade

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Apache
I don’t see any links in the exclusions section. What is broken? Ralph > On Jan 24, 2017, at 9:07 AM, Matt Sicker wrote: > > Broken links: http://rgoers.github.io/log4j2-site/faq.html#exclusions > (not sure how that > happened there) >

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Apache
We should fix the dependency convergence issues in master. Ralph > On Jan 24, 2017, at 9:07 AM, Matt Sicker wrote: > > Broken links: http://rgoers.github.io/log4j2-site/faq.html#exclusions > (not sure how that > happened there) > > We

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Matt Sicker
Everything in the "Log4j Dependency" column are supposed to be markdown links to subdirectories. On 24 January 2017 at 10:49, Apache wrote: > We should fix the dependency convergence issues in master. > > Ralph > > On Jan 24, 2017, at 9:07 AM, Matt Sicker wrote: > > Broken links: http://rgoers.

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Apache
OK - I don’t see that as a big deal. Ralph > On Jan 24, 2017, at 9:55 AM, Matt Sicker wrote: > > Everything in the "Log4j Dependency" column are supposed to be markdown links > to subdirectories. > > On 24 January 2017 at 10:49, Apache > wrote: > We should

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Remko Popma
The http://rgoers.github.io/log4j2-site/faq.html#exclusions link actually works fine for me. On Wed, Jan 25, 2017 at 2:09 AM, Apache wrote: > OK - I don’t see that as a big deal. > > Ralph > > On Jan 24, 2017, at 9:55 AM, Matt Sicker wrote: > > Everything in the "Log4j Dependency" column are su

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Remko Popma
On Wed, Jan 25, 2017 at 1:55 AM, Matt Sicker wrote: > Everything in the "Log4j Dependency" column are supposed to be markdown > links to subdirectories. > Ah, I missed that. But not a showstopper: the table and the text are very valuable by themselves. > > On 24 January 2017 at 10:49, Apache w

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Matt Sicker
It's fixable via a manual commit to svn anyways in the meantime. On 24 January 2017 at 11:23, Remko Popma wrote: > > > On Wed, Jan 25, 2017 at 1:55 AM, Matt Sicker wrote: > >> Everything in the "Log4j Dependency" column are supposed to be markdown >> links to subdirectories. >> > Ah, I missed t

RollingAppenderSizeTest

2017-01-24 Thread Apache
I am looking at the failures that are occurring in the RollingAppenderSizeTest in the Jenkins build. I am working at modifying the code so that the asynchronous tasks will complete before shutdown is allowed to complete. But I am running into an issue I am not sure how to resolve. The test is co

[VOTE][RESULT] Release Apache Logging Parent Pom version 1

2017-01-24 Thread Matt Sicker
The vote has passed by lazy approval with +1 (binding) votes from Remko Popma and Mikael Ståldal. I will be releasing the artifacts from Nexus shortly. -- Matt Sicker

Re: [VOTE][RESULT] Release Apache Logging Parent Pom version 1

2017-01-24 Thread Matt Sicker
Artifacts have been released on Nexus. The pom should be mirror in Maven Central within the next 24 hours, probably sooner than that for most mirrors, though. On 24 January 2017 at 15:28, Matt Sicker wrote: > The vote has passed by lazy approval with +1 (binding) votes from Remko > Popma and Mik

Re: RollingAppenderSizeTest

2017-01-24 Thread Apache
I ended up having to put a delay in the loop that logs events and increase the number of bytes in each file. Obviously, this isn’t a perfect solution, but I’m really not sure what we can do if the async task takes longer than the time it takes to schedule it again. I suppose one option would be

Re: RollingAppenderSizeTest

2017-01-24 Thread Matt Sicker
A custom ExecutorService extension that only allows one task of each kind to be executed at a time or some other classifier could be an approach possibly? On 24 January 2017 at 15:53, Apache wrote: > I ended up having to put a delay in the loop that logs events and increase > the number of bytes

Re: RollingAppenderSizeTest

2017-01-24 Thread Gary Gregory
It feels like we've had so many issues with the rolling file appender for so long. For me, I'd rather have a "rolling" file appender be more like a "time window" file appender where NO files are renamed. For example, with a time window/rollover of 1 day you start with a file called 2017-01-01.txt a

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Gary Gregory
In the future it would be nice to have the VOTE email include a URL to the KEYS file. Gary On Mon, Jan 23, 2017 at 11:04 AM, Apache wrote: > My view is that trying to keep the releases in synch is going to be more > trouble than it is worth. > > Ralph > > On Jan 23, 2017, at 9:06 AM, Matt Sicke

Re: logging-log4j2 git commit: Use an ExecutorService to verify shutdown of the async threads

2017-01-24 Thread Remko Popma
What's the purpose of the EmptyQueue? What would happen if a configuration has multiple rolling files that all roll over at the same time, would EmptyQueue prevent the 2nd task from being scheduled? Small detail: public boolean releaseSub(final long timeout, final TimeUnit timeUnit) { +L

Jenkins build is still unstable: Log4j 2.x #2627

2017-01-24 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: Jenkins build is still unstable: Log4j 2.x #2627

2017-01-24 Thread Remko Popma
There seems to be a problem with the custom Delete action in RollingFileAppender now. Sent from my iPhone > On Jan 25, 2017, at 8:32, Apache Jenkins Server > wrote: > > See > > > ---

[jira] [Commented] (LOG4J2-1784) Large values for max in DefaultRolloverStrategy blocks application

2017-01-24 Thread Charles Hache (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836962#comment-15836962 ] Charles Hache commented on LOG4J2-1784: --- Hi Ralph, I will be able to test this soon

Re: logging-log4j2 git commit: Use an ExecutorService to verify shutdown of the async threads

2017-01-24 Thread Apache
According to the Javadoc, the ExecutorService will first create threads up to corePoolSize. Those threads will be left active in the pool. Next, if there are more that corePoolSize but less than maximumPoolSize threads running then the request will be added to the queue. If the queue is full the

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Gary Gregory
Reviewing src zip. MD5, ASC OK. Reviewing with BUILDING.md. With: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T08:41:47-08:00) Maven home: C:\Java\apache-maven-3.3.9\bin\.. Java version: 1.8.0_112, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.8.0_1

Re: RollingAppenderSizeTest

2017-01-24 Thread Apache
I thought of that but it doesn’t help. The renames are synchronous and they happen with each rollover and conflict with the compression. We have to prevent the next rollover from starting before the async task finishes. Ralph > On Jan 24, 2017, at 2:55 PM, Matt Sicker wrote: > > A custom Exec

Re: RollingAppenderSizeTest

2017-01-24 Thread Apache
That is in 2.8. Just don’t specify a file name. The only downside is that when the system is shut down the file isn’t compressed. That is because it will be reused if you immediately restart. But if it no longer matches the file pattern it will never be compressed. Of course, if you don’t compre

Re: Jenkins build is still unstable: Log4j 2.x #2627

2017-01-24 Thread Apache
Wonderful. Ralph > On Jan 24, 2017, at 4:38 PM, Remko Popma wrote: > > There seems to be a problem with the custom Delete action in > RollingFileAppender now. > > Sent from my iPhone > >> On Jan 25, 2017, at 8:32, Apache Jenkins Server >> wrote: >> >> See

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Apache
If you run the rat check with -P rat the docker files will be ignored. I have never seen that test failure before on my computers but I do see that failure in Jenkins. I’ve never looked at that test though. It started recently. I don’t see it as a release blocker though. Ralph > On Jan 24, 201

Re: RollingAppenderSizeTest

2017-01-24 Thread Apache
Actually, in looking at the code I see that there is already a semaphore there. It is just being improperly released by the rollover method. Ralph > On Jan 24, 2017, at 6:31 PM, Apache wrote: > > I thought of that but it doesn’t help. The renames are synchronous and they > happen with each ro

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Matt Sicker
I've also only seen that failure in Jenkins. On 24 January 2017 at 19:39, Apache wrote: > If you run the rat check with -P rat the docker files will be ignored. > > I have never seen that test failure before on my computers but I do see > that failure in Jenkins. I’ve never looked at that test t

Re: RollingAppenderSizeTest

2017-01-24 Thread Apache
RollingSizeTest now seems to be working properly. Ralph > On Jan 24, 2017, at 6:51 PM, Apache wrote: > > Actually, in looking at the code I see that there is already a semaphore > there. It is just being improperly released by the rollover method. > > Ralph > >> On Jan 24, 2017, at 6:31 PM,

Re: RollingAppenderSizeTest

2017-01-24 Thread Matt Sicker
🎉 On 24 January 2017 at 20:00, Apache wrote: > RollingSizeTest now seems to be working properly. > > Ralph > > On Jan 24, 2017, at 6:51 PM, Apache wrote: > > Actually, in looking at the code I see that there is already a semaphore > there. It is just being improperly released by the rollover me

Re: Jenkins build is still unstable: Log4j 2.x #2627

2017-01-24 Thread Remko Popma
On the bright side, the compress tests used to fail regularly but passed this time! Sent from my iPhone > On Jan 25, 2017, at 10:36, Apache wrote: > > Wonderful. > > Ralph > >> On Jan 24, 2017, at 4:38 PM, Remko Popma wrote: >> >> There seems to be a problem with the custom Delete action i

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Remko Popma
I will try to improve that test. I think it's safe to say that test failure is not a blocker. Remko Sent from my iPhone > On Jan 25, 2017, at 10:54, Matt Sicker wrote: > > I've also only seen that failure in Jenkins. > >> On 24 January 2017 at 19:39, Apache wrote: >> If you run the rat che

Jenkins build is still unstable: Log4j 2.x #2628

2017-01-24 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Gary Gregory
On Tue, Jan 24, 2017 at 5:29 PM, Gary Gregory wrote: > Reviewing src zip. MD5, ASC OK. > > Reviewing with BUILDING.md. > > With: > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > 2015-11-10T08:41:47-08:00) > Maven home: C:\Java\apache-maven-3.3.9\bin\.. > Java version: 1.8.0_112

Re: [VOTE] Release Log4j 2.8-rc1

2017-01-24 Thread Apache
I’ve never seen that error before either. Something to do with Windows? Also, I would think that any test with a name ending in IT should be run by the failsafe plugin. Ralph > On Jan 24, 2017, at 9:08 PM, Gary Gregory wrote: > > On Tue, Jan 24, 2017 at 5:29 PM, Gary Gregory

[VOTE][RESULT] Log4j 2.8 rc1

2017-01-24 Thread Apache
This vote has passed with binding +1 votes from Mikael Ståldal, Ralph Goers, Remko Popma, and Matt Sicker. Thanks to all who voted. I will continue on with the release process. Ralph - To unsubscribe, e-mail: log4j-dev-unsubs