org.apache.logging.log4j.ThreadContext.pop()

2017-03-05 Thread Gary Gregory
When I want to pop the ThreadContext more than once I do: ThreadContext.pop(); ThreadContext.pop(); ThreadContext.pop(); ThreadContext.pop(); Instead I'd like to update some legacy code to: ThreadContext.pop(4); (I know, I know, I should update that old code to push()/clear()) Thoughts on addi

[jira] [Updated] (LOG4J2-1837) NdcPatternConverter isn't GC-free

2017-03-05 Thread Mal Graty (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mal Graty updated LOG4J2-1837: -- Description: The issue (LOG4J2-1715) sought to make the {{NdcPatternConverter}} GC-free, but it looks

Re: org.apache.logging.log4j.ThreadContext.pop()

2017-03-05 Thread Matt Sicker
I'm interested to hear what you use the stack instead of map for in the first place. There's already a method for this, though: ThreadContext.trim(int). On 5 March 2017 at 09:52, Gary Gregory wrote: > When I want to pop the ThreadContext more than once I do: > > ThreadContext.pop(); > ThreadCon

[jira] [Commented] (LOG4J2-1561) print expected mdc info to each line of the exception stacktrace

2017-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896445#comment-15896445 ] ASF GitHub Bot commented on LOG4J2-1561: Github user xnslong commented on the iss

[jira] [Created] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
Zilong Song created LOG4J2-1838: --- Summary: Add support for appending common suffix to each line of throwable stack trace Key: LOG4J2-1838 URL: https://issues.apache.org/jira/browse/LOG4J2-1838 Project:

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song updated LOG4J2-1838: Description: Add support for appending common suffix to each line of throwable stack trace. The su

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song updated LOG4J2-1838: Description: Add support for appending common suffix to each line of throwable stack trace. The su

[jira] [Commented] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896465#comment-15896465 ] ASF GitHub Bot commented on LOG4J2-1838: Github user xnslong commented on the iss

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song updated LOG4J2-1838: Description: Add support for appending common suffix to each line of throwable stack trace. The su

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song updated LOG4J2-1838: Description: Add support for appending common suffix to each line of throwable stack trace. The su

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song updated LOG4J2-1838: Description: Add support for appending common suffix to each line of throwable stack trace. The su

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song updated LOG4J2-1838: Description: Add support for appending common suffix to each line of throwable stack trace. The su

Re: org.apache.logging.log4j.ThreadContext.pop()

2017-03-05 Thread Gary Gregory
IIRC this is just old code mindlessly ported from log4j 1. Gary On Mar 5, 2017 6:17 PM, "Matt Sicker" wrote: I'm interested to hear what you use the stack instead of map for in the first place. There's already a method for this, though: ThreadContext.trim(int). On 5 March 2017 at 09:52, Gary

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song updated LOG4J2-1838: Description: Add support for appending common suffix to each line of throwable stack trace. The su

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song updated LOG4J2-1838: Description: Add support for appending common suffix to each line of throwable stack trace. The su

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song updated LOG4J2-1838: Description: Add support for appending common suffix to each line of throwable stack trace. The su

[jira] [Commented] (LOG4J2-1561) print expected mdc info to each line of the exception stacktrace

2017-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896658#comment-15896658 ] ASF GitHub Bot commented on LOG4J2-1561: Github user xnslong closed the pull requ

Re: org.apache.logging.log4j.ThreadContext.pop()

2017-03-05 Thread Matt Sicker
Looking at the code for trim(int), it seems to do the opposite actually: https://github.com/apache/logging-log4j2/blob/master/log4j-api/src/main/java/org/apache/logging/log4j/spi/MutableThreadContextStack.java#L102 You'd have to keep the old depth before pushing, then restoring it with the old de

[jira] [Commented] (LOG4J2-1824) (GC) Avoid allocating temporary objects in KafkaAppender

2017-03-05 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896691#comment-15896691 ] Matt Sicker commented on LOG4J2-1824: - There's work being done to port the byte buffe

[jira] [Closed] (LOG4J2-1561) print expected mdc info to each line of the exception stacktrace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song closed LOG4J2-1561. --- Resolution: Duplicate The linked issue have brought a better approach to solve this problem. > print

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song updated LOG4J2-1838: Description: Add support for appending common suffix to each line of throwable stack trace. The su

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread Zilong Song (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Song updated LOG4J2-1838: Description: Add support for appending common suffix to each line of throwable stack trace. The su

[jira] [Commented] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

2017-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896756#comment-15896756 ] ASF GitHub Bot commented on LOG4J2-1838: Github user jvz commented on the issue:

[jira] [Commented] (LOG4J2-673) plugin preloading fails in shaded jar files

2017-03-05 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896795#comment-15896795 ] David Česal commented on LOG4J2-673: Is there some progress on it? I have the same pro