[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872993#comment-15872993
]
Remko Popma commented on LOG4J2-1563:
-
I Saw you raised LOG4J2-1820 for the new issue. Perfect,
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872608#comment-15872608
]
Jason Tedor commented on LOG4J2-1563:
-
I would like to submit another patch for a similar issue. It
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562011#comment-15562011
]
Jason Tedor commented on LOG4J2-1563:
-
That's a workflow that a lot of people are use to these days,
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1590#comment-1590
]
Jason Tedor commented on LOG4J2-1563:
-
How about just iterating with the patch author if more changes
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1588#comment-1588
]
Gary Gregory commented on LOG4J2-1563:
--
In EGit (Eclipse), I see an Author and Commit text box, so
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1585#comment-1585
]
Remko Popma commented on LOG4J2-1563:
-
I hear you. We do appreciate the time and effort you put into
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1574#comment-1574
]
Jason Tedor commented on LOG4J2-1563:
-
Please do not attribute this to the tooling, this has nothing
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1573#comment-1573
]
Jason Tedor commented on LOG4J2-1563:
-
Please do not attribute this to the tooling, this has nothing
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1570#comment-1570
]
Gary Gregory commented on LOG4J2-1563:
--
On Windows 7, I use Git Bash, git in a cmd.exe, and EGit in
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1562#comment-1562
]
Jason Tedor commented on LOG4J2-1563:
-
I don't think this practice should be attributed to tooling.
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1563#comment-1563
]
Jason Tedor commented on LOG4J2-1563:
-
I don't think this practice should be attributed to tooling.
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1547#comment-1547
]
Remko Popma commented on LOG4J2-1563:
-
Jason, thank you for pointing this out. Your suggestion is a
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1429#comment-1429
]
Matt Sicker commented on LOG4J2-1563:
-
We always credit external contributes in the changelog for the
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1412#comment-1412
]
Jason Tedor commented on LOG4J2-1563:
-
I recognize that I'm an external contributor and my opinion
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491622#comment-15491622
]
Gary Gregory commented on LOG4J2-1563:
--
I used EGit. The background is that most of us started with
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491537#comment-15491537
]
Matt Sicker commented on LOG4J2-1563:
-
The commit message is kept usually in a pull request at least.
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491466#comment-15491466
]
Jason Tedor commented on LOG4J2-1563:
-
Thanks for replying [~garydgregory] :). That's a different
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491458#comment-15491458
]
Gary Gregory commented on LOG4J2-1563:
--
Hi Jason,
We don't bother with attribution at the commit
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491432#comment-15491432
]
Jason Tedor commented on LOG4J2-1563:
-
Heya [~garydgregory], I'm confused about the contribution
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482737#comment-15482737
]
Jason Tedor commented on LOG4J2-1563:
-
{quote}How do we run a whole build with a security
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482732#comment-15482732
]
Jason Tedor commented on LOG4J2-1563:
-
Thanks [~garydgregory], sorry that I missed your pings earlier
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482727#comment-15482727
]
Jason Tedor commented on LOG4J2-1563:
-
I think we can make this simpler by just following the same
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482723#comment-15482723
]
Jason Tedor commented on LOG4J2-1563:
-
That gets tricky because that means storing off the current
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469276#comment-15469276
]
Gary Gregory commented on LOG4J2-1563:
--
Hi,
We now have:
{code:java}
try {
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469270#comment-15469270
]
Gary Gregory commented on LOG4J2-1563:
--
The tests restores the Security Manager, which is good.
[
https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469261#comment-15469261
]
Gary Gregory commented on LOG4J2-1563:
--
The patch looks good. I'll apply it. Thank you.
My next
26 matches
Mail list logo
