Re: GitHub pull requests

2016-08-30 Thread Mikael Ståldal
Someone should have a look at this Pull Request: https://github.com/apache/logging-log4j2/pull/41 I am not sure if it makes sense or not. On Tue, Aug 30, 2016 at 7:10 PM, Mikael Ståldal wrote: > Done. > > On Sun, Aug 28, 2016 at 12:20 PM, Remko Popma

Re: GitHub pull requests

2016-08-30 Thread Mikael Ståldal
Done. On Sun, Aug 28, 2016 at 12:20 PM, Remko Popma wrote: > +1 Good idea! > > On Sun, Aug 28, 2016 at 7:12 PM, Mikael Ståldal > wrote: > >> I think that some people find the project on GitHub, and they might not >> be aware about our JIRA.

Re: GitHub pull requests

2016-08-28 Thread Remko Popma
+1 Good idea! On Sun, Aug 28, 2016 at 7:12 PM, Mikael Ståldal wrote: > I think that some people find the project on GitHub, and they might not be > aware about our JIRA. Should we mention this in the README.md that is > visible on GitHub? > > On Aug 27, 2016 2:30 PM,

Re: GitHub pull requests

2016-08-28 Thread Mikael Ståldal
I think that some people find the project on GitHub, and they might not be aware about our JIRA. Should we mention this in the README.md that is visible on GitHub? On Aug 27, 2016 2:30 PM, "Mikael Ståldal" wrote: > Does anyone keep track of incoming pull requests on

Re: GitHub pull requests

2016-08-27 Thread Matt Sicker
If you go here: https://issues.apache.org/jira/secure/ManageFilters.jspa You can see there's a "Shared With" column. In theory, we can make a filter public, but I can't find how. On 27 August 2016 at 11:26, Gary Gregory wrote: > Jira has a SQL like query language...

Re: GitHub pull requests

2016-08-27 Thread Gary Gregory
Jira has a SQL like query language... and you can save queries. But that might be per user. Gary On Aug 27, 2016 8:39 AM, "Ralph Goers" wrote: > Yes, every patch needs a Jira issue. > > To be honest, I’d really like a tool that could tell us all the Jira > issues

Re: GitHub pull requests

2016-08-27 Thread Ralph Goers
Yes, every patch needs a Jira issue. To be honest, I’d really like a tool that could tell us all the Jira issues that have patches and all the outstanding pull requests. I am sure there are commands or queries that could do both of these things but I don’t remember exactly how to do them. It

GitHub pull requests

2016-08-27 Thread Mikael Ståldal
Does anyone keep track of incoming pull requests on GitHub? It seems like we get a few with no corresponding JIRA ticket. Should we ask them to open a JIRA ticket?

Re: Merging github pull requests

2016-07-31 Thread Remko Popma
too. > > On Saturday, 30 July 2016, Gary Gregory <garydgreg...@gmail.com> wrote: >> Try adding ".patch" or ".diff" to the github URL >> >> >>> On Jul 30, 2016 4:50 AM, "Remko Popma" <remko.po...@gmail.com> wrote: >>&

Re: Merging github pull requests

2016-07-30 Thread Matt Sicker
.diff" to the github URL > > On Jul 30, 2016 4:50 AM, "Remko Popma" <remko.po...@gmail.com > <javascript:_e(%7B%7D,'cvml','remko.po...@gmail.com');>> wrote: > >> Does anyone have experience merging Github pull requests into Log4j2? >> The pull request

Re: Merging github pull requests

2016-07-30 Thread Gary Gregory
Try adding ".patch" or ".diff" to the github URL On Jul 30, 2016 4:50 AM, "Remko Popma" <remko.po...@gmail.com> wrote: > Does anyone have experience merging Github pull requests into Log4j2? > The pull requests are based on the github.com mirror o

Merging github pull requests

2016-07-30 Thread Remko Popma
Does anyone have experience merging Github pull requests into Log4j2? The pull requests are based on the github.com mirror of the git.apache.org repository so a lot of the instructions don't make sense to me. I want to work on https://github.com/apache/logging-log4j2/pull/34 but don't know how