Re: SyslogAppender parameter name change

2017-02-04 Thread Remko Popma 
Thanks Matt!
Sam, can you check if this resolves the issue? 

Sent from my iPhone

> On Feb 4, 2017, at 14:49, Matt Sicker  wrote:
> 
> I see. There were a couple issues with @PluginAliases for SyslogAppender 
> specifically. Fixed in master.
> 
>> On 3 February 2017 at 10:23, Matt Sicker  wrote:
>> Plugins can have aliases via @PluginAliases (see for example 
>> ),
>>  don't recall if attributes are supported. If not, that's a feature we can 
>> support for sure.
>> 
>>> On 2 February 2017 at 18:27, Gary Gregory  wrote:
>>> Darn, I apologize for that one. 
>>> 
>>> Gary
>>> 
 On Thu, Feb 2, 2017 at 4:09 PM, Remko Popma  wrote:
 Sorry for that and thanks for letting us know!
 
 I wonder if parameter names can have aliases so we can support both the 
 old and the new name without causing users inconvenience. If possible we 
 should address this for 2.8.1. 
 
 Remko 
 
 Sent from my iPhone
 
> On Feb 3, 2017, at 4:13, Sam Beroz  wrote:
> 
> The reconnectionDelayMillis parameter was renamed to 
> reconnectDelayMillis. After updating to release 2.8 I noticed that I was 
> getting the following error:
> 
> ERROR Syslog contains an invalid element or attribute 
> "reconnectionDelayMillis"
> 
> It appears that change was part of this commit:
> 
> commit ed828be67a23ee3513cafc9d2fd0ff16a26c7013
> Author: Gary Gregory 
> Date:   Mon Nov 14 15:11:47 2016 -0800
> 
> [LOG4J2-1709]
> 
> Add a Builder to SyslogAppender and deprecate
> SyslogAppender.createAppender().
> 
> 
> The documentation 
> (https://logging.apache.org/log4j/2.x/manual/appenders.html#SyslogAppender)
>  still has the parameter listed as "reconnectionDelayMillis" but the code 
> is now obviously looking for "reconnectDelayMillis". I'm going to change 
> my config to use the new name, but I thought I'd point out the disconnect 
> as it had me confused for a bit. Thanks - Sam
>>> 
>>> 
>>> 
>>> -- 
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org 
>>> Java Persistence with Hibernate, Second Edition 
>>> JUnit in Action, Second Edition 
>>> Spring Batch in Action 
>>> Blog: http://garygregory.wordpress.com 
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>> 
>> 
>> 
>> -- 
>> Matt Sicker 
> 
> 
> 
> -- 
> Matt Sicker

Re: SyslogAppender parameter name change

2017-02-03 Thread Matt Sicker 
I see. There were a couple issues with @PluginAliases for SyslogAppender
specifically. Fixed in master.

On 3 February 2017 at 10:23, Matt Sicker  wrote:

> Plugins can have aliases via @PluginAliases (see for example <
> https://github.com/apache/logging-log4j2/blob/master/
> log4j-core/src/main/java/org/apache/logging/log4j/core/
> appender/mom/JmsAppender.java>), don't recall if attributes are
> supported. If not, that's a feature we can support for sure.
>
> On 2 February 2017 at 18:27, Gary Gregory  wrote:
>
>> Darn, I apologize for that one.
>>
>> Gary
>>
>> On Thu, Feb 2, 2017 at 4:09 PM, Remko Popma 
>> wrote:
>>
>>> Sorry for that and thanks for letting us know!
>>>
>>> I wonder if parameter names can have aliases so we can support both the
>>> old and the new name without causing users inconvenience. If possible we
>>> should address this for 2.8.1.
>>>
>>> Remko
>>>
>>> Sent from my iPhone
>>>
>>> On Feb 3, 2017, at 4:13, Sam Beroz  wrote:
>>>
>>> The reconnectionDelayMillis parameter was renamed
>>> to reconnectDelayMillis. After updating to release 2.8 I noticed that I was
>>> getting the following error:
>>>
>>> ERROR Syslog contains an invalid element or attribute
>>> "reconnectionDelayMillis"
>>>
>>>
>>> It appears that change was part of this commit:
>>>
>>> commit ed828be67a23ee3513cafc9d2fd0ff16a26c7013
>>> Author: Gary Gregory 
>>> Date:   Mon Nov 14 15:11:47 2016 -0800
>>>
>>> [LOG4J2-1709]
>>>
>>> Add a Builder to SyslogAppender and deprecate
>>> SyslogAppender.createAppender().
>>>
>>>
>>>
>>> The documentation (https://logging.apache.org/lo
>>> g4j/2.x/manual/appenders.html#SyslogAppender) still has the parameter
>>> listed as "reconnectionDelayMillis" but the code is now obviously
>>> looking for "reconnectDelayMillis". I'm going to change my config to
>>> use the new name, but I thought I'd point out the disconnect as it had me
>>> confused for a bit. Thanks - Sam
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> 
>>
>> 
>> JUnit in Action, Second Edition
>> 
>>
>> 
>> Spring Batch in Action
>> 
>> 
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> Matt Sicker 
>



-- 
Matt Sicker

Re: SyslogAppender parameter name change

2017-02-03 Thread Matt Sicker 
Plugins can have aliases via @PluginAliases (see for example <
https://github.com/apache/logging-log4j2/blob/master/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/JmsAppender.java>),
don't recall if attributes are supported. If not, that's a feature we can
support for sure.

On 2 February 2017 at 18:27, Gary Gregory  wrote:

> Darn, I apologize for that one.
>
> Gary
>
> On Thu, Feb 2, 2017 at 4:09 PM, Remko Popma  wrote:
>
>> Sorry for that and thanks for letting us know!
>>
>> I wonder if parameter names can have aliases so we can support both the
>> old and the new name without causing users inconvenience. If possible we
>> should address this for 2.8.1.
>>
>> Remko
>>
>> Sent from my iPhone
>>
>> On Feb 3, 2017, at 4:13, Sam Beroz  wrote:
>>
>> The reconnectionDelayMillis parameter was renamed
>> to reconnectDelayMillis. After updating to release 2.8 I noticed that I was
>> getting the following error:
>>
>> ERROR Syslog contains an invalid element or attribute
>> "reconnectionDelayMillis"
>>
>>
>> It appears that change was part of this commit:
>>
>> commit ed828be67a23ee3513cafc9d2fd0ff16a26c7013
>> Author: Gary Gregory 
>> Date:   Mon Nov 14 15:11:47 2016 -0800
>>
>> [LOG4J2-1709]
>>
>> Add a Builder to SyslogAppender and deprecate
>> SyslogAppender.createAppender().
>>
>>
>>
>> The documentation (https://logging.apache.org/lo
>> g4j/2.x/manual/appenders.html#SyslogAppender) still has the parameter
>> listed as "reconnectionDelayMillis" but the code is now obviously
>> looking for "reconnectDelayMillis". I'm going to change my config to use
>> the new name, but I thought I'd point out the disconnect as it had me
>> confused for a bit. Thanks - Sam
>>
>>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
>
> 
> JUnit in Action, Second Edition
> 
>
> 
> Spring Batch in Action
> 
> 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker

Re: SyslogAppender parameter name change

2017-02-02 Thread Gary Gregory 
Darn, I apologize for that one.

Gary

On Thu, Feb 2, 2017 at 4:09 PM, Remko Popma  wrote:

> Sorry for that and thanks for letting us know!
>
> I wonder if parameter names can have aliases so we can support both the
> old and the new name without causing users inconvenience. If possible we
> should address this for 2.8.1.
>
> Remko
>
> Sent from my iPhone
>
> On Feb 3, 2017, at 4:13, Sam Beroz  wrote:
>
> The reconnectionDelayMillis parameter was renamed
> to reconnectDelayMillis. After updating to release 2.8 I noticed that I was
> getting the following error:
>
> ERROR Syslog contains an invalid element or attribute
> "reconnectionDelayMillis"
>
>
> It appears that change was part of this commit:
>
> commit ed828be67a23ee3513cafc9d2fd0ff16a26c7013
> Author: Gary Gregory 
> Date:   Mon Nov 14 15:11:47 2016 -0800
>
> [LOG4J2-1709]
>
> Add a Builder to SyslogAppender and deprecate
> SyslogAppender.createAppender().
>
>
>
> The documentation (https://logging.apache.org/lo
> g4j/2.x/manual/appenders.html#SyslogAppender) still has the parameter
> listed as "reconnectionDelayMillis" but the code is now obviously looking
> for "reconnectDelayMillis". I'm going to change my config to use the new
> name, but I thought I'd point out the disconnect as it had me confused for
> a bit. Thanks - Sam
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: SyslogAppender parameter name change

2017-02-02 Thread Remko Popma 
Sorry for that and thanks for letting us know!

I wonder if parameter names can have aliases so we can support both the old and 
the new name without causing users inconvenience. If possible we should address 
this for 2.8.1. 

Remko 

Sent from my iPhone

> On Feb 3, 2017, at 4:13, Sam Beroz  wrote:
> 
> The reconnectionDelayMillis parameter was renamed to reconnectDelayMillis. 
> After updating to release 2.8 I noticed that I was getting the following 
> error:
> 
> ERROR Syslog contains an invalid element or attribute 
> "reconnectionDelayMillis"
> 
> It appears that change was part of this commit:
> 
> commit ed828be67a23ee3513cafc9d2fd0ff16a26c7013
> Author: Gary Gregory 
> Date:   Mon Nov 14 15:11:47 2016 -0800
> 
> [LOG4J2-1709]
> 
> Add a Builder to SyslogAppender and deprecate
> SyslogAppender.createAppender().
> 
> 
> The documentation 
> (https://logging.apache.org/log4j/2.x/manual/appenders.html#SyslogAppender) 
> still has the parameter listed as "reconnectionDelayMillis" but the code is 
> now obviously looking for "reconnectDelayMillis". I'm going to change my 
> config to use the new name, but I thought I'd point out the disconnect as it 
> had me confused for a bit. Thanks - Sam

SyslogAppender parameter name change

2017-02-02 Thread Sam Beroz 
The reconnectionDelayMillis parameter was renamed to reconnectDelayMillis.
After updating to release 2.8 I noticed that I was getting the following
error:

ERROR Syslog contains an invalid element or attribute
"reconnectionDelayMillis"


It appears that change was part of this commit:

commit ed828be67a23ee3513cafc9d2fd0ff16a26c7013
Author: Gary Gregory 
Date:   Mon Nov 14 15:11:47 2016 -0800

[LOG4J2-1709]

Add a Builder to SyslogAppender and deprecate
SyslogAppender.createAppender().



The documentation (https://logging.apache.org/lo
g4j/2.x/manual/appenders.html#SyslogAppender) still has the parameter
listed as "reconnectionDelayMillis" but the code is now obviously looking
for "reconnectDelayMillis". I'm going to change my config to use the new
name, but I thought I'd point out the disconnect as it had me confused for
a bit. Thanks - Sam