Re: DOMConfigurator in 1.1b6
Sure, I hear what you're saying.
Cheers,
Anders
Ceki Gülcü wrote:
>
> Anders,
>
> It's well possible that the code was there before the move to JavaBeans style of
>configuration. I did not think it was added by me because I don't see why it should
>be there. So I assumed that you had spotted a problem and corrected it by adding the
>convertSpecialChars call. I was not throwing mud, not even criticizing. It was more a
>call for help. Does that make sense? Ceki
>
> At 19:11 05.05.2001 -0400, you wrote:
>
> >Ceki Gülcü wrote:
> >>
> >> Steven,
> >>
> >> I don't know the reason for having the OptionConverter.convertSpecialChars()
>call. If I am not mistaken, the change was made by Anders. Regards, Ceki
> >
> >Let's not get into mud slinging, but actually, I believe you're
> >mistaken. The 1.0.4 code had the equivalent call:
> >
> > protected
> > void parseParameters(Element elem, OptionHandler oh) {
> >String name = elem.getAttribute(NAME_ATTR);
> >String value = elem.getAttribute(VALUE_ATTR);
> >LogLog.debug("Handling parameter \""+name+ "="+value+'\"');
> >if(oh instanceof OptionHandler && value != null) {
> > oh.setOption(name, OptionConverter.convertSpecialChars(value));
> >}
> > }
>
> OK. I did not know that.
>
> >Cheers,
> >Anders
> >
> >>
> >> ps: It breaks support for windows style file names, e.g. "c:\n.log"
> >>
> >> At 10:23 30.04.2001 -0400, you wrote:
> >>
> >> >Has a defect in that it tries to do special character substitution when the
>characters come from a property. I don't think this is the desired behavior because
>when the property contains a windows path, then the path gets mangled. I have
>attached a patch to org/apache/log4j/xml/DOMConfigurator.java that hopefully resolves
>this issue.
> >> >
> >> >Steven Velez
> >> >Software Engineer
> >> >alventive
> >> >678-202-2226
> >> >
> >> >
> >> >465c465
> >> >< propSetter.setProperty(name, OptionConverter.convertSpecialChars(value));
> >> >---
> >> >> propSetter.setProperty(name, value);
> >> >678a679
> >> >> value = OptionConverter.convertSpecialChars(value);
> >>
>
> --
> Ceki Gülcü
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: DOMConfigurator in 1.1b6
Anders,
It's well possible that the code was there before the move to JavaBeans style of
configuration. I did not think it was added by me because I don't see why it should be
there. So I assumed that you had spotted a problem and corrected it by adding the
convertSpecialChars call. I was not throwing mud, not even criticizing. It was more a
call for help. Does that make sense? Ceki
At 19:11 05.05.2001 -0400, you wrote:
>Ceki Gülcü wrote:
>>
>> Steven,
>>
>> I don't know the reason for having the OptionConverter.convertSpecialChars() call.
>If I am not mistaken, the change was made by Anders. Regards, Ceki
>
>Let's not get into mud slinging, but actually, I believe you're
>mistaken. The 1.0.4 code had the equivalent call:
>
> protected
> void parseParameters(Element elem, OptionHandler oh) {
>String name = elem.getAttribute(NAME_ATTR);
>String value = elem.getAttribute(VALUE_ATTR);
>LogLog.debug("Handling parameter \""+name+ "="+value+'\"');
>if(oh instanceof OptionHandler && value != null) {
> oh.setOption(name, OptionConverter.convertSpecialChars(value));
>}
> }
OK. I did not know that.
>Cheers,
>Anders
>
>>
>> ps: It breaks support for windows style file names, e.g. "c:\n.log"
>>
>> At 10:23 30.04.2001 -0400, you wrote:
>>
>> >Has a defect in that it tries to do special character substitution when the
>characters come from a property. I don't think this is the desired behavior because
>when the property contains a windows path, then the path gets mangled. I have
>attached a patch to org/apache/log4j/xml/DOMConfigurator.java that hopefully resolves
>this issue.
>> >
>> >Steven Velez
>> >Software Engineer
>> >alventive
>> >678-202-2226
>> >
>> >
>> >465c465
>> >< propSetter.setProperty(name, OptionConverter.convertSpecialChars(value));
>> >---
>> >> propSetter.setProperty(name, value);
>> >678a679
>> >> value = OptionConverter.convertSpecialChars(value);
>>
--
Ceki Gülcü
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: DOMConfigurator in 1.1b6
Ceki Gülcü wrote:
>
> Steven,
>
> I don't know the reason for having the OptionConverter.convertSpecialChars() call.
>If I am not mistaken, the change was made by Anders. Regards, Ceki
Let's not get into mud slinging, but actually, I believe you're
mistaken. The 1.0.4 code had the equivalent call:
protected
void parseParameters(Element elem, OptionHandler oh) {
String name = elem.getAttribute(NAME_ATTR);
String value = elem.getAttribute(VALUE_ATTR);
LogLog.debug("Handling parameter \""+name+ "="+value+'\"');
if(oh instanceof OptionHandler && value != null) {
oh.setOption(name, OptionConverter.convertSpecialChars(value));
}
}
Cheers,
Anders
>
> ps: It breaks support for windows style file names, e.g. "c:\n.log"
>
> At 10:23 30.04.2001 -0400, you wrote:
>
> >Has a defect in that it tries to do special character substitution when the
>characters come from a property. I don't think this is the desired behavior because
>when the property contains a windows path, then the path gets mangled. I have
>attached a patch to org/apache/log4j/xml/DOMConfigurator.java that hopefully resolves
>this issue.
> >
> >Steven Velez
> >Software Engineer
> >alventive
> >678-202-2226
> >
> >
> >465c465
> >< propSetter.setProperty(name, OptionConverter.convertSpecialChars(value));
> >---
> >> propSetter.setProperty(name, value);
> >678a679
> >> value = OptionConverter.convertSpecialChars(value);
>
> --
> Ceki Gülcü
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: DOMConfigurator in 1.1b6
Steven, I don't know the reason for having the OptionConverter.convertSpecialChars() call. If I am not mistaken, the change was made by Anders. Regards, Ceki ps: It breaks support for windows style file names, e.g. "c:\n.log" At 10:23 30.04.2001 -0400, you wrote: >Has a defect in that it tries to do special character substitution when the >characters come from a property. I don't think this is the desired behavior because >when the property contains a windows path, then the path gets mangled. I have >attached a patch to org/apache/log4j/xml/DOMConfigurator.java that hopefully resolves >this issue. > >Steven Velez >Software Engineer >alventive >678-202-2226 > > >465c465 >< propSetter.setProperty(name, OptionConverter.convertSpecialChars(value)); >--- >> propSetter.setProperty(name, value); >678a679 >> value = OptionConverter.convertSpecialChars(value); -- Ceki Gülcü - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DOMConfigurator in 1.1b6
Title: DOMConfigurator in 1.1b6 Has a defect in that it tries to do special character substitution when the characters come from a property. I don't think this is the desired behavior because when the property contains a windows path, then the path gets mangled. I have attached a patch to org/apache/log4j/xml/DOMConfigurator.java that hopefully resolves this issue. Steven Velez Software Engineer alventive 678-202-2226 465c465 < propSetter.setProperty(name, OptionConverter.convertSpecialChars(value)); --- > propSetter.setProperty(name, value); 678a679 > value = OptionConverter.convertSpecialChars(value);
