[jira] [Commented] (LOG4J2-1588) Console or File Logger caches thread name, but not in older log4j2 versions
[
https://issues.apache.org/jira/browse/LOG4J2-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544625#comment-15544625
]
Remko Popma commented on LOG4J2-1588:
-
I agree it is not intuitive that the property name
{{AsyncLogger.ThreadNameStrategy}} can also be used to control caching for
synchronous logging. Basically this was existing code built for the async
loggers that was reused for synchronous logging in the garbage-free
ReusableEventFactory.
I will see if we can improve the docs or add another property to control this.
Not super urgent IMHO, but patches welcome. :-)
> Console or File Logger caches thread name, but not in older log4j2 versions
> ---
>
> Key: LOG4J2-1588
> URL: https://issues.apache.org/jira/browse/LOG4J2-1588
> Project: Log4j 2
> Issue Type: Bug
>Affects Versions: 2.6.2
> Environment: Windows, Grizzly HTTP container, SLF4J API, Log4j2
>Reporter: Rainer Schnitker
>
> Log4j2 2.6.x seems to cache the thread name. A revert to version 2.4.1.
> works! This affects synchronous logger: console, RollingFile
> My sample code (JAX-RS Filter):
> {code}
> import java.io.IOException;
> import javax.annotation.Priority;
> import javax.inject.Inject;
> import javax.ws.rs.container.ContainerRequestContext;
> import javax.ws.rs.container.ContainerRequestFilter;
> import javax.ws.rs.ext.Provider;
> import org.glassfish.grizzly.http.server.Request;
> import org.slf4j.LoggerFactory;
> @Provider
> @Priority(Integer.MIN_VALUE)
> public class GrizzlyRequestFilter implements ContainerRequestFilter {
> @Inject
> javax.inject.Provider< Request > provider;
> @Override
> public void filter( ContainerRequestContext requestContext ) throws
> IOException {
> Request request = this.provider.get();
> Thread thread = Thread.currentThread();
> thread.setName( request.getRemoteHost() + '/' + thread.getId() );
>
> // oops: logger thread name != expected
> LoggerFactory.getLogger(GrizzlyRequestFilter.class)
> .info( "expected thread name:" + request.getRemoteHost() + '/' +
> thread.getId() );
>
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1588) Console or File Logger caches thread name, but not in older log4j2 versions
[
https://issues.apache.org/jira/browse/LOG4J2-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544482#comment-15544482
]
Rainer Schnitker commented on LOG4J2-1588:
--
I agree with ThreadContextMap. The issure can be closed.
But the documentation says that AsyncLogger.ThreadNameStrategy should be set
(for async loggers only?). My code use synchonous loggers. Not clear.
> Console or File Logger caches thread name, but not in older log4j2 versions
> ---
>
> Key: LOG4J2-1588
> URL: https://issues.apache.org/jira/browse/LOG4J2-1588
> Project: Log4j 2
> Issue Type: Bug
>Affects Versions: 2.6.2
> Environment: Windows, Grizzly HTTP container, SLF4J API, Log4j2
>Reporter: Rainer Schnitker
>
> Log4j2 2.6.x seems to cache the thread name. A revert to version 2.4.1.
> works! This affects synchronous logger: console, RollingFile
> My sample code (JAX-RS Filter):
> {code}
> import java.io.IOException;
> import javax.annotation.Priority;
> import javax.inject.Inject;
> import javax.ws.rs.container.ContainerRequestContext;
> import javax.ws.rs.container.ContainerRequestFilter;
> import javax.ws.rs.ext.Provider;
> import org.glassfish.grizzly.http.server.Request;
> import org.slf4j.LoggerFactory;
> @Provider
> @Priority(Integer.MIN_VALUE)
> public class GrizzlyRequestFilter implements ContainerRequestFilter {
> @Inject
> javax.inject.Provider< Request > provider;
> @Override
> public void filter( ContainerRequestContext requestContext ) throws
> IOException {
> Request request = this.provider.get();
> Thread thread = Thread.currentThread();
> thread.setName( request.getRemoteHost() + '/' + thread.getId() );
>
> // oops: logger thread name != expected
> LoggerFactory.getLogger(GrizzlyRequestFilter.class)
> .info( "expected thread name:" + request.getRemoteHost() + '/' +
> thread.getId() );
>
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1588) Console or File Logger caches thread name, but not in older log4j2 versions
[
https://issues.apache.org/jira/browse/LOG4J2-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536624#comment-15536624
]
Gary Gregory commented on LOG4J2-1588:
--
+1, this is a _perfect_ use case for the {{ThreadContextMap}}.
> Console or File Logger caches thread name, but not in older log4j2 versions
> ---
>
> Key: LOG4J2-1588
> URL: https://issues.apache.org/jira/browse/LOG4J2-1588
> Project: Log4j 2
> Issue Type: Bug
>Affects Versions: 2.6.2
> Environment: Windows, Grizzly HTTP container, SLF4J API, Log4j2
>Reporter: Rainer Schnitker
>
> Log4j2 2.6.x seems to cache the thread name. A revert to version 2.4.1.
> works! This affects synchronous logger: console, RollingFile
> My sample code (JAX-RS Filter):
> {code}
> import java.io.IOException;
> import javax.annotation.Priority;
> import javax.inject.Inject;
> import javax.ws.rs.container.ContainerRequestContext;
> import javax.ws.rs.container.ContainerRequestFilter;
> import javax.ws.rs.ext.Provider;
> import org.glassfish.grizzly.http.server.Request;
> import org.slf4j.LoggerFactory;
> @Provider
> @Priority(Integer.MIN_VALUE)
> public class GrizzlyRequestFilter implements ContainerRequestFilter {
> @Inject
> javax.inject.Provider< Request > provider;
> @Override
> public void filter( ContainerRequestContext requestContext ) throws
> IOException {
> Request request = this.provider.get();
> Thread thread = Thread.currentThread();
> thread.setName( request.getRemoteHost() + '/' + thread.getId() );
>
> // oops: logger thread name != expected
> LoggerFactory.getLogger(GrizzlyRequestFilter.class)
> .info( "expected thread name:" + request.getRemoteHost() + '/' +
> thread.getId() );
>
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1588) Console or File Logger caches thread name, but not in older log4j2 versions
[
https://issues.apache.org/jira/browse/LOG4J2-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536094#comment-15536094
]
Ralph Goers commented on LOG4J2-1588:
-
My 2 cents. I agree with Mikael. This is exactly what the ThreadContextMap (MDC
in Log4j 1 and Logback) is for. You would do:
{code}
@Provider
@Priority(Integer.MIN_VALUE)
public class GrizzlyRequestFilter implements ContainerRequestFilter {
@Inject
javax.inject.Provider< Request > provider;
@Override
public void filter( ContainerRequestContext requestContext ) throws
IOException {
Request request = this.provider.get();
ThreadContext.put("remoteHost", request.getRemoteHost());
}
}
{code}
When the request is complete you should clear the threadContext (just like you
really should reset the thread name in your example).
> Console or File Logger caches thread name, but not in older log4j2 versions
> ---
>
> Key: LOG4J2-1588
> URL: https://issues.apache.org/jira/browse/LOG4J2-1588
> Project: Log4j 2
> Issue Type: Bug
>Affects Versions: 2.6.2
> Environment: Windows, Grizzly HTTP container, SLF4J API, Log4j2
>Reporter: Rainer Schnitker
>
> Log4j2 2.6.x seems to cache the thread name. A revert to version 2.4.1.
> works! This affects synchronous logger: console, RollingFile
> My sample code (JAX-RS Filter):
> {code}
> import java.io.IOException;
> import javax.annotation.Priority;
> import javax.inject.Inject;
> import javax.ws.rs.container.ContainerRequestContext;
> import javax.ws.rs.container.ContainerRequestFilter;
> import javax.ws.rs.ext.Provider;
> import org.glassfish.grizzly.http.server.Request;
> import org.slf4j.LoggerFactory;
> @Provider
> @Priority(Integer.MIN_VALUE)
> public class GrizzlyRequestFilter implements ContainerRequestFilter {
> @Inject
> javax.inject.Provider< Request > provider;
> @Override
> public void filter( ContainerRequestContext requestContext ) throws
> IOException {
> Request request = this.provider.get();
> Thread thread = Thread.currentThread();
> thread.setName( request.getRemoteHost() + '/' + thread.getId() );
>
> // oops: logger thread name != expected
> LoggerFactory.getLogger(GrizzlyRequestFilter.class)
> .info( "expected thread name:" + request.getRemoteHost() + '/' +
> thread.getId() );
>
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1588) Console or File Logger caches thread name, but not in older log4j2 versions
[
https://issues.apache.org/jira/browse/LOG4J2-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535923#comment-15535923
]
Remko Popma commented on LOG4J2-1588:
-
You should be able to control the behavior with [this system
property|https://logging.apache.org/log4j/2.x/manual/configuration.html#AsyncLogger.ThreadNameStrategy]:
{{AsyncLogger.ThreadNameStrategy}}.
Valid values: CACHED, UNCACHED.
> Console or File Logger caches thread name, but not in older log4j2 versions
> ---
>
> Key: LOG4J2-1588
> URL: https://issues.apache.org/jira/browse/LOG4J2-1588
> Project: Log4j 2
> Issue Type: Bug
>Affects Versions: 2.6.2
> Environment: Windows, Grizzly HTTP container, SLF4J API, Log4j2
>Reporter: Rainer Schnitker
>
> Log4j2 2.6.x seems to cache the thread name. A revert to version 2.4.1.
> works! This affects synchronous logger: console, RollingFile
> My sample code (JAX-RS Filter):
> {code}
> import java.io.IOException;
> import javax.annotation.Priority;
> import javax.inject.Inject;
> import javax.ws.rs.container.ContainerRequestContext;
> import javax.ws.rs.container.ContainerRequestFilter;
> import javax.ws.rs.ext.Provider;
> import org.glassfish.grizzly.http.server.Request;
> import org.slf4j.LoggerFactory;
> @Provider
> @Priority(Integer.MIN_VALUE)
> public class GrizzlyRequestFilter implements ContainerRequestFilter {
> @Inject
> javax.inject.Provider< Request > provider;
> @Override
> public void filter( ContainerRequestContext requestContext ) throws
> IOException {
> Request request = this.provider.get();
> Thread thread = Thread.currentThread();
> thread.setName( request.getRemoteHost() + '/' + thread.getId() );
>
> // oops: logger thread name != expected
> LoggerFactory.getLogger(GrizzlyRequestFilter.class)
> .info( "expected thread name:" + request.getRemoteHost() + '/' +
> thread.getId() );
>
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1588) Console or File Logger caches thread name, but not in older log4j2 versions
[
https://issues.apache.org/jira/browse/LOG4J2-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535875#comment-15535875
]
Mikael Ståldal commented on LOG4J2-1588:
Maybe you can use Thread Content Map (also known as MDC) instead:
http://logging.apache.org/log4j/2.x/manual/thread-context.html
Use the {{%X}} pattern instead of {{%t}}.
> Console or File Logger caches thread name, but not in older log4j2 versions
> ---
>
> Key: LOG4J2-1588
> URL: https://issues.apache.org/jira/browse/LOG4J2-1588
> Project: Log4j 2
> Issue Type: Bug
>Affects Versions: 2.6.2
> Environment: Windows, Grizzly HTTP container, SLF4J API, Log4j2
>Reporter: Rainer Schnitker
>
> Log4j2 2.6.x seems to cache the thread name. A revert to version 2.4.1.
> works! This affects synchronous logger: console, RollingFile
> My sample code (JAX-RS Filter):
> {code}
> import java.io.IOException;
> import javax.annotation.Priority;
> import javax.inject.Inject;
> import javax.ws.rs.container.ContainerRequestContext;
> import javax.ws.rs.container.ContainerRequestFilter;
> import javax.ws.rs.ext.Provider;
> import org.glassfish.grizzly.http.server.Request;
> import org.slf4j.LoggerFactory;
> @Provider
> @Priority(Integer.MIN_VALUE)
> public class GrizzlyRequestFilter implements ContainerRequestFilter {
> @Inject
> javax.inject.Provider< Request > provider;
> @Override
> public void filter( ContainerRequestContext requestContext ) throws
> IOException {
> Request request = this.provider.get();
> Thread thread = Thread.currentThread();
> thread.setName( request.getRemoteHost() + '/' + thread.getId() );
>
> // oops: logger thread name != expected
> LoggerFactory.getLogger(GrizzlyRequestFilter.class)
> .info( "expected thread name:" + request.getRemoteHost() + '/' +
> thread.getId() );
>
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1588) Console or File Logger caches thread name, but not in older log4j2 versions
[
https://issues.apache.org/jira/browse/LOG4J2-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535789#comment-15535789
]
Rainer Schnitker commented on LOG4J2-1588:
--
The log4j version 2.5 is also ok. Only affects 2.6.x.
> Console or File Logger caches thread name, but not in older log4j2 versions
> ---
>
> Key: LOG4J2-1588
> URL: https://issues.apache.org/jira/browse/LOG4J2-1588
> Project: Log4j 2
> Issue Type: Bug
>Affects Versions: 2.6.2
> Environment: Windows, Grizzly HTTP container, SLF4J API, Log4j2
>Reporter: Rainer Schnitker
>
> Log4j2 2.6.x seems to cache the thread name. A revert to version 2.4.1.
> works! This affects synchronous logger: console, RollingFile
> My sample code (JAX-RS Filter):
> {code}
> import java.io.IOException;
> import javax.annotation.Priority;
> import javax.inject.Inject;
> import javax.ws.rs.container.ContainerRequestContext;
> import javax.ws.rs.container.ContainerRequestFilter;
> import javax.ws.rs.ext.Provider;
> import org.glassfish.grizzly.http.server.Request;
> import org.slf4j.LoggerFactory;
> @Provider
> @Priority(Integer.MIN_VALUE)
> public class GrizzlyRequestFilter implements ContainerRequestFilter {
> @Inject
> javax.inject.Provider< Request > provider;
> @Override
> public void filter( ContainerRequestContext requestContext ) throws
> IOException {
> Request request = this.provider.get();
> Thread thread = Thread.currentThread();
> thread.setName( request.getRemoteHost() + '/' + thread.getId() );
>
> // oops: logger thread name != expected
> LoggerFactory.getLogger(GrizzlyRequestFilter.class)
> .info( "expected thread name:" + request.getRemoteHost() + '/' +
> thread.getId() );
>
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1588) Console or File Logger caches thread name, but not in older log4j2 versions
[
https://issues.apache.org/jira/browse/LOG4J2-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535783#comment-15535783
]
Rainer Schnitker commented on LOG4J2-1588:
--
This issure affects version 2.6.2.
Perhaps there are other alternatives to set a request context for an logging
event.
To identify the same client request in the log, we assign the thread name to
the current client hostname or ip address plus the thead id.
The log uses the logging pattern: %d{-MM-dd HH:mm:ss,SSS} [%t] %-5p %c -
%m%n
This works with all logging frameworks, that supports the thread name.
> Console or File Logger caches thread name, but not in older log4j2 versions
> ---
>
> Key: LOG4J2-1588
> URL: https://issues.apache.org/jira/browse/LOG4J2-1588
> Project: Log4j 2
> Issue Type: Bug
>Affects Versions: 2.6.2
> Environment: Windows, Grizzly HTTP container, SLF4J API, Log4j2
>Reporter: Rainer Schnitker
>
> Log4j2 2.6.x seems to cache the thread name. A revert to version 2.4.1.
> works! This affects synchronous logger: console, RollingFile
> My sample code (JAX-RS Filter):
> {code}
> import java.io.IOException;
> import javax.annotation.Priority;
> import javax.inject.Inject;
> import javax.ws.rs.container.ContainerRequestContext;
> import javax.ws.rs.container.ContainerRequestFilter;
> import javax.ws.rs.ext.Provider;
> import org.glassfish.grizzly.http.server.Request;
> import org.slf4j.LoggerFactory;
> @Provider
> @Priority(Integer.MIN_VALUE)
> public class GrizzlyRequestFilter implements ContainerRequestFilter {
> @Inject
> javax.inject.Provider< Request > provider;
> @Override
> public void filter( ContainerRequestContext requestContext ) throws
> IOException {
> Request request = this.provider.get();
> Thread thread = Thread.currentThread();
> thread.setName( request.getRemoteHost() + '/' + thread.getId() );
>
> // oops: logger thread name != expected
> LoggerFactory.getLogger(GrizzlyRequestFilter.class)
> .info( "expected thread name:" + request.getRemoteHost() + '/' +
> thread.getId() );
>
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1588) Console or File Logger caches thread name, but not in older log4j2 versions
[
https://issues.apache.org/jira/browse/LOG4J2-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510523#comment-15510523
]
Gary Gregory commented on LOG4J2-1588:
--
Hello Rainer,
I'm not sure playing with thread names is such a good idea here.
Can you explain what you are trying to achieve from a higher level POV?
Would you also be able to use 2.6.2 or our Git master?
Thank you,
Gary
> Console or File Logger caches thread name, but not in older log4j2 versions
> ---
>
> Key: LOG4J2-1588
> URL: https://issues.apache.org/jira/browse/LOG4J2-1588
> Project: Log4j 2
> Issue Type: Bug
>Affects Versions: 2.6.2
> Environment: Windows, Grizzly HTTP container, SLF4J API, Log4j2
>Reporter: Rainer Schnitker
>
> Log4j2 2.6.x seems to cache the thread name. A revert to version 2.4.1.
> works! This affects synchronous logger: console, RollingFile
> My sample code (JAX-RS Filter):
> {code}
> import java.io.IOException;
> import javax.annotation.Priority;
> import javax.inject.Inject;
> import javax.ws.rs.container.ContainerRequestContext;
> import javax.ws.rs.container.ContainerRequestFilter;
> import javax.ws.rs.ext.Provider;
> import org.glassfish.grizzly.http.server.Request;
> import org.slf4j.LoggerFactory;
> @Provider
> @Priority(Integer.MIN_VALUE)
> public class GrizzlyRequestFilter implements ContainerRequestFilter {
> @Inject
> javax.inject.Provider< Request > provider;
> @Override
> public void filter( ContainerRequestContext requestContext ) throws
> IOException {
> Request request = this.provider.get();
> Thread thread = Thread.currentThread();
> thread.setName( request.getRemoteHost() + '/' + thread.getId() );
>
> // oops: logger thread name != expected
> LoggerFactory.getLogger(GrizzlyRequestFilter.class)
> .info( "expected thread name:" + request.getRemoteHost() + '/' +
> thread.getId() );
>
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1588) Console or File Logger caches thread name, but not in older log4j2 versions
[
https://issues.apache.org/jira/browse/LOG4J2-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509743#comment-15509743
]
Rainer Schnitker commented on LOG4J2-1588:
--
A test with log4j 2.5 was ok. This issure affects only 2.6.
> Console or File Logger caches thread name, but not in older log4j2 versions
> ---
>
> Key: LOG4J2-1588
> URL: https://issues.apache.org/jira/browse/LOG4J2-1588
> Project: Log4j 2
> Issue Type: Bug
>Affects Versions: 2.6.2
> Environment: Windows, Grizzly HTTP container, SLF4J API, Log4j2
>Reporter: Rainer Schnitker
>
> Log4j2 2.6.x seems to cache the thread name. A revert to version 2.4.1.
> works! This affects synchronous logger: console, RollingFile
> My sample code (JAX-RS Filter):
> {code}
> import java.io.IOException;
> import javax.annotation.Priority;
> import javax.inject.Inject;
> import javax.ws.rs.container.ContainerRequestContext;
> import javax.ws.rs.container.ContainerRequestFilter;
> import javax.ws.rs.ext.Provider;
> import org.glassfish.grizzly.http.server.Request;
> import org.slf4j.LoggerFactory;
> @Provider
> @Priority(Integer.MIN_VALUE)
> public class GrizzlyRequestFilter implements ContainerRequestFilter {
> @Inject
> javax.inject.Provider< Request > provider;
> @Override
> public void filter( ContainerRequestContext requestContext ) throws
> IOException {
> Request request = this.provider.get();
> Thread thread = Thread.currentThread();
> thread.setName( request.getRemoteHost() + '/' + thread.getId() );
>
> // oops: logger thread name != expected
> LoggerFactory.getLogger(GrizzlyRequestFilter.class)
> .info( "expected thread name:" + request.getRemoteHost() + '/' +
> thread.getId() );
>
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
