Re: jsonlayout contextMap

2016-04-11 Thread Ralph Goers
Gary, I am not sure how this got implemented this way despite me objecting and saying it was wrong. Please fix it. Ralph > On Apr 11, 2016, at 2:30 PM, Gary Gregory wrote: > > You'll see if a toggle or a new appender makes sense depending on how much > code disruption this causes. > > Keep

Re: jsonlayout contextMap

2016-04-11 Thread John Bush
lol, well see, now I know you read it. Sorry, I'm just kinda like that... But seriously I can probably whip up a patch for a toggle, that sounds like a reasonable approach. On Mon, Apr 11, 2016 at 1:57 PM, Gary Gregory wrote: > "They are also Java nazi's" [sic]? > > Really? Is that necessary?

Re: jsonlayout contextMap

2016-04-11 Thread Gary Gregory
You'll see if a toggle or a new appender makes sense depending on how much code disruption this causes. Keep in mind that the Jackson-based appenders work for JSON, XML, and YAML formats. Make sure you base on work on the latest from Git master. Good luck! Gary On Mon, Apr 11, 2016 at 2:26 PM,

Re: jsonlayout contextMap

2016-04-11 Thread Gary Gregory
"They are also Java nazi's" [sic]? Really? Is that necessary? How about providing a patch for either an alternate JSON layout or a toggle on the current layout? That would sure be more productive that name calling. Gary On Mon, Apr 11, 2016 at 1:53 PM, John Bush wrote: > If you are frustrate

jsonlayout contextMap

2016-04-11 Thread John Bush
If you are frustrated by how the ootb JsonLayout handles context data, see https://issues.apache.org/jira/browse/LOG4J2-623 I've published how I worked around it here: https://github.com/johntbush/log4j2-jsonlayout

Re: XMLLayout indents, but not the first child tag ()

2016-04-11 Thread Gary Gregory
Feel free to submit a unit test and patch. Gary On Mon, Mar 28, 2016 at 12:00 PM, Kamal Mettananda wrote: > Hi all > > I am using log4j 2.5 to print the logs via XMLLayout. I have set > compact="true", hence the new line and indents of sub tags work correctly. > However I have noticed that the