Thanks for all your input.
I'm going to try and implement the appender we need to maintain our current
throttling infrastructure. I will send a patch with the changes we need as
far as moving items from private to protected and removing the final
keyword.
On Sat, Aug 30, 2014 at 2:02 PM, Matt
After looking at SmtpAppender, SmtpManager and your eamil it doesn’t sound to
me like there is a lot of benefit in extending SmtpAppender or SmtpManager.
Their primary purpose of those, and the majority of the code, is to send email
- which you have said your version doesn’t do. The only code
This sounds like a good feature to have in log4j2. I remember we had an issue
at work where error logs were emailed automatically, bringing down the mail
server when the app kept generating the same error. Painful.
Sent from my iPhone
On 2014/08/30, at 7:24, Michael Schall
)
/divdivTo: Log4J Users List log4j-user@logging.apache.org
/divdivSubject: Re: Extending Appenders /divdiv
/divThis sounds like a good feature to have in log4j2. I remember we had an
issue at work where error logs were emailed automatically, bringing down the
mail server when the app kept
It sounds like a feature that belongs to any logger. Syslog doesn't need to
know that a database server is unavailable every nanosecond, either.
Sent from my phone
On Aug 30, 2014, at 3:19 AM, Remko Popma remko.po...@gmail.com wrote:
This sounds like a good feature to have in log4j2. I
http://logging.apache.org/log4j/2.x/manual/filters.html#BurstFilter
http://logging.apache.org/log4j/2.x/manual/appenders.html#RoutingAppender
There are several ways to go about implementing what you're asking about
using existing features. You may be able to get what you need by using just
the
I'm upgrading an application to use Log4j2. With our existing
implementation we have created a new appender which extends the
SMTPAppender. I see the SMTPAppender is a final class now which prevents
me from extending it. I was wondering what the reason for this is? Do we
really need to
Looks like this class was made final in January 2013. The commit message
mentions checkstyle errors.
What change are you proposing? Would just removing the final keyword from
the class definition be enough to fulfill your needs?
It may be good to raise this as a feature request in Jira.
If you
Thanks for your response Remko.
Looking into this further, I could duplicate the SmtpAppender code as it
really just seems to do plugin work. The bulk of the code is in the
SmtpManager class which is not marked final. The constructor is marked
protected, however it takes a private class
I would not object to changing SmtpAppender to make it more extendible.
Can you tell me more about your use case? SmtpAppender is designed this way
because we had a specific usage in mind. By understanding your use case we
might be able to improve the design in a way that benefits not just you
I would prefer to see changes that allows more flexible usage without
subclassing. If you subclass a core class, there is no guarantee that the
next release will be binary compatible. For the API, we do guarantee binary
compatibility within a major version.
Gary
On Fri, Aug 29, 2014 at 6:22 PM,
This is a fair point. There are some things not in the API that we wouldn’t
change as they would also break compatibility, such as the Layout or Appender
interface, but we aren’t guaranteeing that specific Appender or Layout
instances won’t have a new parameter added to them or things like
Again, thanks for all the interest in my request.
I don't have the code in front of me, but I will try and give an
overview of what we did for log4j 1.x.
We want to send emails for errors happening in production. However for
example, we don't want to send thousands of emails if the network goes
.
Additonally, I'm not familiar with StubManager and it's implementation, any
insight is GREATLY appreciated.
Thank you,
-Dean
--
View this message in context:
http://apache-logging.6191.n7.nabble.com/Extending-Appenders-tp49160.html
Sent from the Log4j - Users mailing list archive at Nabble.com
implementation, any
insight is GREATLY appreciated.
Thank you,
-Dean
--
View this message in context:
http://apache-logging.6191.n7.nabble.com/Extending-Appenders-tp49160.html
Sent from the Log4j - Users mailing list archive at Nabble.com
15 matches
Mail list logo
