Re: Why is AsyncLogger#shutdown time not configurable?

2016-06-30 Thread David Leonhartsberger
https://issues.apache.org/jira/browse/LOG4J2-1453 On Thu, Jun 30, 2016 at 5:56 PM, Remko Popma wrote: > At the time it was on purpose but now I think about it more I agree it is > better to use some timeout. > Not sure when I will be able to get to it. Would you mind raising a Jira > for this so

Re: Why is AsyncLogger#shutdown time not configurable?

2016-06-30 Thread David Leonhartsberger
Yes no problem. I can also provide a PR for it if you want. On Thu, Jun 30, 2016 at 5:56 PM, Remko Popma wrote: > At the time it was on purpose but now I think about it more I agree it is > better to use some timeout. > Not sure when I will be able to get to it. Would you mind raising a Jira > f

Re: Why is AsyncLogger#shutdown time not configurable?

2016-06-30 Thread Mikael Ståldal
AsyncAppender has a shutdownTimeout parameter. It would be good to have something similar for async loggers. It is important to not block JVM shutdown forever. On Thu, Jun 30, 2016 at 5:56 PM, Remko Popma wrote: > At the time it was on purpose but now I think about it more I agree it is > better

Re: Why is AsyncLogger#shutdown time not configurable?

2016-06-30 Thread Remko Popma
At the time it was on purpose but now I think about it more I agree it is better to use some timeout. Not sure when I will be able to get to it. Would you mind raising a Jira for this so we won't forget about it? Remko On Thu, Jun 30, 2016 at 4:10 AM, David Leonhartsberger wrote: > I was just l

Why is AsyncLogger#shutdown time not configurable?

2016-06-29 Thread David Leonhartsberger
I was just looking at the AsyncLoggerDistruptor#stop() and figured out that the shutdown time is not configurable and it even could be blocking forever waiting that the Disruptor backlog has been processed. // Calling Disruptor.shutdown() will wait until all enqueued events are fully processed, /