Re: dynamic configuration

2015-08-10 Thread Xen
I was really wondering whether I was correct about that DCL. And whether this subclassing ConfigurationFactory was really the one (and only) way to go about this. It seems the easiest. The static control structure of the plugin/log4j2 seems very hard or impossible to get around (any number of o

Re: dynamic configuration

2015-08-09 Thread Gary Gregory
Same here. I am also alarmed that you do not have a mouse. That's is one handy tool! On Sun, Aug 9, 2015 at 11:44 AM, Ralph Goers wrote: > While interesting reading I can't quite figure out if there is a question > you wanted answered in there? > > Ralph > > > On Aug 9, 2015, at 6:05 AM, Xen wr

Re: dynamic configuration

2015-08-09 Thread Ralph Goers
While interesting reading I can't quite figure out if there is a question you wanted answered in there? Ralph > On Aug 9, 2015, at 6:05 AM, Xen wrote: > > I have a JIRA account now. > > At least, I hope I will have one for long, I am thinking of cancelling my > main account (email) for a sho

Re: dynamic configuration

2015-08-09 Thread Xen
I have a JIRA account now. At least, I hope I will have one for long, I am thinking of cancelling my main account (email) for a short while to start over with a clean slate. Including its domain ;-). Might get a lot of bounces for a LOT of email services ;-). But in any case... I was writ

Re: dynamic configuration

2015-08-09 Thread Ralph Goers
Note: in case you didn't know, everyone who submits patches that are applied gets "credit" for it. See the change log for any release. Without a Jira ticket we can't do that. Ralph > On Aug 9, 2015, at 2:28 AM, Gary Gregory wrote: > > Patch applied. TY. In the future, please create a JIRA fo

Re: dynamic configuration

2015-08-09 Thread Gary Gregory
Patch applied. TY. In the future, please create a JIRA for patches. Keep them coming :-) Cheers, Gary On Sun, Aug 9, 2015 at 1:11 AM, Xen wrote: > I've seen the commit. I will check it out. > > Offtopic: fixed a typo in the javadoc: > > > diff --git > a/log4j-core/src/main/java/org/apache/logg

Re: dynamic configuration

2015-08-09 Thread Xen
I've seen the commit. I will check it out. Offtopic: fixed a typo in the javadoc: diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java index 3c8c44a..14

Re: dynamic configuration

2015-08-08 Thread Gary Gregory
Pushed to Git master. Xen: Please see the setLevel methods in Configurator. Gary On Sat, Aug 8, 2015 at 4:24 PM, Gary Gregory wrote: > Please see the patch in https://issues.apache.org/jira/browse/LOG4J2-1090 > > Gary > > On Sat, Aug 8, 2015 at 4:05 PM, Ralph Goers > wrote: > >> Yes. >> >> Ra

Re: dynamic configuration

2015-08-08 Thread Gary Gregory
Please see the patch in https://issues.apache.org/jira/browse/LOG4J2-1090 Gary On Sat, Aug 8, 2015 at 4:05 PM, Ralph Goers wrote: > Yes. > > Ralph > > > On Aug 8, 2015, at 4:03 PM, Gary Gregory wrote: > > > > That's my bad, I misread Configurator for Configuration. > > > > That said, the > > m

Re: dynamic configuration

2015-08-08 Thread Ralph Goers
Yes. Ralph > On Aug 8, 2015, at 4:03 PM, Gary Gregory wrote: > > That's my bad, I misread Configurator for Configuration. > > That said, the > method > org.apache.logging.log4j.core.config.AbstractConfiguration.getRootLogger() > is not in the Configuration interface. Is it OK to add it? > >

Re: dynamic configuration

2015-08-08 Thread Gary Gregory
That's my bad, I misread Configurator for Configuration. That said, the method org.apache.logging.log4j.core.config.AbstractConfiguration.getRootLogger() is not in the Configuration interface. Is it OK to add it? Gary On Sat, Aug 8, 2015 at 3:42 PM, Ralph Goers wrote: > I just noticed you add

Re: dynamic configuration

2015-08-08 Thread Ralph Goers
I just noticed you added this to AbstractConfiguration. Wouldn’t it be easier for users to do it as a method on Configurator? Ralph > On Aug 8, 2015, at 12:55 PM, Gary Gregory wrote: > > setLevel, setRootLevel; code review please, note the added check " if > (!loggerConfig.getLevel().equals(le

Re: dynamic configuration

2015-08-08 Thread Gary Gregory
setLevel, setRootLevel; code review please, note the added check " if (!loggerConfig.getLevel().equals(level)) ..." diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfigur

Re: dynamic configuration

2015-08-08 Thread Xen
You are very friendly, thank you for that. I take it you mean that it is not thread-safe with regards to other threads that may already, and still, and currently be using Loggers to do things. So what you do instead is create the new object in safety and then quickly install it using a fo

Re: dynamic configuration

2015-08-08 Thread Gary Gregory
OK, things could get complicated for a full feature list. For now, I have a use case where setting levels in a running system is important, so making that easy is nice. Gary On Sat, Aug 8, 2015 at 12:19 PM, Ralph Goers wrote: > I have to amend what I said. In reviewing the pdf documentation I

Re: dynamic configuration

2015-08-08 Thread Ralph Goers
I have to amend what I said. In reviewing the pdf documentation I do see that we support dynamically adding a LoggerConfig to an existing configuration. Gary, while we could also add methods to make this simpler, doing that would almost certainly require some sort of “begin” and “end” as you mi

Re: dynamic configuration

2015-08-08 Thread Ralph Goers
Sorry if it appears we don’t care, but your original message seemed to be full of sarcasm and didn’t ask for any real help. FWIW, the goal wasn’t to make configuration harder - it was to make configuration changes thread safe. Log4j 1 has thread safety issues and locks in ways that can cause de

Re: dynamic configuration

2015-08-08 Thread Ralph Goers
Yup. And while your at it you might want to add setRootLevel(Level level); Ralph > On Aug 8, 2015, at 10:19 AM, Gary Gregory wrote: > > Like this: > > diff --git > a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java > b/log4j-core/src/main/java/org/apach

Re: dynamic configuration

2015-08-08 Thread Gary Gregory
Like this: diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java index ada5900..bf01c3e 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/con

Re: dynamic configuration

2015-08-08 Thread Xen
Heh, it seems more like you went out of your way to close off a configuration method on purpose that you would know would still be in high demand by a lot of people. The choice to have only configuration per external file would definitely have raised a lot of eyebrows. And I bet, still does

Re: dynamic configuration

2015-08-07 Thread Ralph Goers
I'd recommend the Configurator class. Ralph > On Aug 6, 2015, at 9:46 PM, Gary Gregory wrote: > > > For the simple case where you want to update one level, I think we should > have a one method call for folks. Where would be the best place to hang > that? > > Gary --

Re: dynamic configuration

2015-08-07 Thread Ralph Goers
I guess you can't please everybody. Sent from my iPad > On Aug 7, 2015, at 2:00 AM, Xen wrote: > > Quoting Ralph Goers : > >> To achieve what you want just get the LoggerConfig you want to modify, >> change its level and then call the updateLoggers() method of the >> LoggerContext. > > I'm

Re: dynamic configuration

2015-08-07 Thread Xen
Quoting Ralph Goers : To achieve what you want just get the LoggerConfig you want to modify, change its level and then call the updateLoggers() method of the LoggerContext. I'm sorry. Maybe this seems lazy or unwarranted, but... The only quick resource I could find was StackOverflow. And I

Re: dynamic configuration

2015-08-06 Thread Gary Gregory
On Thu, Aug 6, 2015 at 8:45 PM, Ralph Goers wrote: > 1. There are examples that show how to modify the configuration > programmatically. I recently created an example that is checked into the > log4j-samples subproject. However, it is probably more complicated than > what you are asking for. > 2

Re: dynamic configuration

2015-08-06 Thread Ralph Goers
1. There are examples that show how to modify the configuration programmatically. I recently created an example that is checked into the log4j-samples subproject. However, it is probably more complicated than what you are asking for. 2. Log4j 1 intermixed the public API that applications used t

Re: dynamic configuration

2015-08-06 Thread Gary Gregory
On Thu, Aug 6, 2015 at 2:50 PM, Shawn Heisey wrote: > On 8/6/2015 2:44 PM, Xen wrote: > > I am led to believe that I am not meant to configure log4j2 during > > program execution. Nor can I change the configuration except by > > loading different configuration files. > > > > I am happy to assume

Re: dynamic configuration

2015-08-06 Thread Shawn Heisey
On 8/6/2015 2:44 PM, Xen wrote: > I am led to believe that I am not meant to configure log4j2 during > program execution. Nor can I change the configuration except by > loading different configuration files. > > I am happy to assume that this is rather odd. I would like it if I had > a main configu

dynamic configuration

2015-08-06 Thread Xen
Hey, I just read the manual at https://logging.apache.org/log4j/2.0/log4j-users-guide.pdf. A reasonably good manual I must say, compared to some products out there. It doesn't really mention the public API though, only sparsely throughout the examples. I skipped through the remainder of t

Re: Persist dynamic configuration changes to log4j.xml file

2008-07-02 Thread Gopal Patwa
u, > Jacob. > > -- View this message in context: http://www.nabble.com/Persist-dynamic-configuration-changes-to-log4j.xml-file-tp17799896p18252684.html Sent from the Log4j - Users mailing list archive at Nabble.com.

Persist dynamic configuration changes to log4j.xml file

2008-06-12 Thread bjacobt
to achieve this. Thank you, Jacob. -- View this message in context: http://www.nabble.com/Persist-dynamic-configuration-changes-to-log4j.xml-file-tp17799896p17799896.html Sent from the Log4j - Users mailing list archive at

Re: web app dynamic configuration

2004-06-16 Thread Jacob Kjome
At 10:43 PM 6/16/2004 -0600, you wrote: Jacob Kjome wrote: Have you looked at the ConfigurationServlet in the logging-log4j-sandbox? http://cvs.apache.org/viewcvs.cgi/logging-log4j-sandbox/src/java/org/apache/log4j/servlet/ConfigurationServlet.java Hadn't seen it actually... thanks! No problem. Y

Re: web app dynamic configuration

2004-06-16 Thread Derek Scherger
Jacob Kjome wrote: Have you looked at the ConfigurationServlet in the logging-log4j-sandbox? http://cvs.apache.org/viewcvs.cgi/logging-log4j-sandbox/src/java/org/apache/log4j/servlet/ConfigurationServlet.java Hadn't seen it actually... thanks! You might want to verify whether your implementation p

Re: web app dynamic configuration

2004-06-16 Thread Jacob Kjome
so that the core log4j.jar is kept to a minimal size with only core logging functionality. Jake At 07:21 PM 6/16/2004 -0600, you wrote: Hi folks, I've got a bit of a start on a servlet that allows dynamic configuration changes to log levels used by various Logger's. It already is quite

web app dynamic configuration

2004-06-16 Thread Derek Scherger
Hi folks, I've got a bit of a start on a servlet that allows dynamic configuration changes to log levels used by various Logger's. It already is quite useful for me as it allows changes to be made to a running/deployed web-app without restarting or re-deploying. If this was inclu

web app dynamic configuration

2004-06-14 Thread Derek Scherger
Hi folks, I've got a bit of a start on a servlet that allows dynamic configuration changes to log levels used by various Logger's. It already is quite useful for me as it allows changes to be made to a running/deployed web-app without restarting or re-deploying. If this was inclu