Re: Have a patch to contribute to fix a lookup issue in Log4j 2

2018-09-26 Thread Bhavesh Patel
Hi Remko/Ralph,                            If you can just verify the bug that I have filed and reply to it or something, it would be great. I just want to make sure that i am not missing something and this is indeed a bug in the ResourceBundleLookup. Thanks,Bhavesh. On Wednesday,

Re: Have a patch to contribute to fix a lookup issue in Log4j 2

2018-09-26 Thread Bhavesh Patel
Thanks so much. Let me look into it and I can submit a pull request once I have it ready. Regards,Bhavesh. On Wednesday, September 26, 2018, 4:15:49 PM PDT, Remko Popma wrote: Hi, Yes, contributions are very welcome! You already raised a JIRA ticket, that’s great. Next step is to

Re: Have a patch to contribute to fix a lookup issue in Log4j 2

2018-09-26 Thread Remko Popma
Hi, Yes, contributions are very welcome! You already raised a JIRA ticket, that’s great. Next step is to provide a pull request with your fix. Please include unit tests and (if applicable) documentation updates. Please prefix commit messages with the JIRA ticket number. Log4j targets Java 7

Re: Have a patch to contribute to fix a lookup issue in Log4j 2

2018-09-26 Thread Ralph Goers
If you have a fix the easiest thing to do is to create a pull request at GitHub. If it has a unit test to validate the problem and the fix it will almost certainly be applied. As far as getting commit rights, that generally happens after someone has contributed several patches, participated to