[GitHub] log4net issue #30: Misc. fixes for netstandard

2016-08-13 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/30 No, NAnt seems to compile against 4.0's libraries where `Stream.ReadAsync` hasn't been defined. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] log4net issue #30: Misc. fixes for netstandard

2016-08-13 Thread jasonwilliams200OK
Github user jasonwilliams200OK commented on the issue: https://github.com/apache/log4net/pull/30 Oh, in other words Nant is having issue parsing this preprocessor directive: `#if NET_4_5 || NETSTANDARD1_3`? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] log4net issue #30: Misc. fixes for netstandard

2016-08-13 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/30 Thanks, I think I had this figured out myself already. Unfortunately it turns out the way we build the 4.5 version isn't working as intended (we tell Nant to build against 4.0 on a machine wi

[GitHub] log4net issue #30: Misc. fixes for netstandard

2016-08-13 Thread jasonwilliams200OK
Github user jasonwilliams200OK commented on the issue: https://github.com/apache/log4net/pull/30 I have rebased it against trunk. To review without whitespace diff, here is the proper diff link: https://github.com/apache/log4net/pull/30/files?w=1 --- If your project is set up for it,

[GitHub] log4net issue #30: Misc. fixes for netstandard

2016-08-13 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/30 by fixing `FileAppender` I'm now causing a merge conflict here, sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project