Re: recommendation for AspNetPatternLayoutConverter

2012-07-30 Thread George Chung
* Monday, July 30, 2012 4:40 AM > *To:* Log4NET Dev > *Subject:* Re: recommendation for AspNetPatternLayoutConverter > > ** ** > > Yes, I completely discounted backwards compatibility, sorry. > > On Sun, Jul 29, 2012 at 2:13 PM, Dominik Psenner > wrote: >

RE: recommendation for AspNetPatternLayoutConverter

2012-07-29 Thread Dominik Psenner
x27; Subject: RE: recommendation for AspNetPatternLayoutConverter No need to worry George. :-) Personally I prefer to stay on the bleeding edge of development. Though, this issue is currently not a problem to me. Would you try and get something done that is backwards compatible? I will commit an

RE: recommendation for AspNetPatternLayoutConverter

2012-07-29 Thread Dominik Psenner
[mailto:geo...@glympse.com] Sent: Monday, July 30, 2012 4:40 AM To: Log4NET Dev Subject: Re: recommendation for AspNetPatternLayoutConverter Yes, I completely discounted backwards compatibility, sorry. On Sun, Jul 29, 2012 at 2:13 PM, Dominik Psenner wrote: On 07/27/2012 10:42 PM, George Chung

Re: recommendation for AspNetPatternLayoutConverter

2012-07-29 Thread George Chung
Yes, I completely discounted backwards compatibility, sorry. On Sun, Jul 29, 2012 at 2:13 PM, Dominik Psenner wrote: > On 07/27/2012 10:42 PM, George Chung wrote: > > It currently defines this abstract method: > > > > protected abstract > > void Convert(TextWriter writer, LoggingEvent loggingEve

Re: recommendation for AspNetPatternLayoutConverter

2012-07-29 Thread Dominik Psenner
On 07/27/2012 10:42 PM, George Chung wrote: > It currently defines this abstract method: > > protected abstract > void Convert(TextWriter writer, LoggingEvent loggingEvent, HttpContext > httpContext) > > I would recommend changing it to: > > protected abstract void Convert(TextWriter writer, Lo

recommendation for AspNetPatternLayoutConverter

2012-07-27 Thread George Chung
It currently defines this abstract method: protected abstract void Convert(TextWriter writer, LoggingEvent loggingEvent, HttpContext httpContext) I would recommend changing it to: protected abstract void Convert(TextWriter writer, LoggingEvent loggingEvent, HttpContext*Base* httpContext) Effe