Casul User created LOG4NET-368:
--
Summary: PatternString properties in config file
Key: LOG4NET-368
URL: https://issues.apache.org/jira/browse/LOG4NET-368
Project: Log4net
Issue Type:
[
https://issues.apache.org/jira/browse/LOG4NET-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Meier updated LOG4NET-27:
--
Attachment: RollingFileAppender.zip
Rolling files on date/time boundaries doesn't support a
I pasted the patched files into a series of patches and bomb them to the
mailing list for eassier review.
Trivial changes to tabs and spaces, formatting etc.
diff -r b430bc3cc0f4 -r dc18d71a5304 src/Appender/RollingFileAppender.cs
--- a/src/Appender/RollingFileAppender.cs Tue Jan 22 14:27:20 2013 +0100
+++ b/src/Appender/RollingFileAppender.cs Tue Jan 22 14:31:05 2013 +0100
@@ -1,10 +1,10
In RollOverIfDateBoundaryCrossing preserveLogFileExtension wasn't respected.
diff -r dc18d71a5304 -r 76c5f9136b8f src/Appender/RollingFileAppender.cs
--- a/src/Appender/RollingFileAppender.cs Tue Jan 22 14:31:05 2013 +0100
+++ b/src/Appender/RollingFileAppender.cs Tue Jan 22 14:31:24
* some trivial changes in visibility, regions etc.
* additional functions, properties, members that aren't yet used from existing
code.
* NextCheckDate - GetRollDateTimeRelative:
Function works identically if called with relativePeriod==1. Existing code
does this.
Additionally any count of
diff -r 569e06c6cfb3 -r c4b727dc790c src/Appender/RollingFileAppender.cs
--- a/src/Appender/RollingFileAppender.cs Tue Jan 22 14:31:43 2013 +0100
+++ b/src/Appender/RollingFileAppender.cs Tue Jan 22 14:31:58 2013 +0100
@@ -835,6 +835,11 @@
}
diff -r c4b727dc790c -r 09c42c61e2db
tests/src/Appender/RollingFileAppenderTest.cs
--- a/tests/src/Appender/RollingFileAppenderTest.cs Tue Jan 22 14:31:58
2013 +0100
+++ b/tests/src/Appender/RollingFileAppenderTest.cs Tue Jan 22 14:37:21
2013 +0100
@@ -1874,12 +1874,110 @@
Quite a large patch, but looks sensible.
-Original Message-
From: Dominik Psenner [mailto:dpsen...@gmail.com]
Sent: Tuesday, January 22, 2013 2:41 PM
To: log4net-dev@logging.apache.org
Subject: [PATCH 1 of 5] Step 1: refactoring
Trivial changes to tabs and spaces, formatting etc.
diff
What are the effects of this bug? It is not yet reported as an issue, is it?
On 01/22/2013 02:41 PM, Dominik Psenner wrote:
In RollOverIfDateBoundaryCrossing preserveLogFileExtension wasn't respected.
diff -r dc18d71a5304 -r 76c5f9136b8f src/Appender/RollingFileAppender.cs
---
On 01/22/2013 02:41 PM, Dominik Psenner wrote:
diff -r c4b727dc790c -r 09c42c61e2db
tests/src/Appender/RollingFileAppenderTest.cs
--- a/tests/src/Appender/RollingFileAppenderTest.cs Tue Jan 22 14:31:58
2013 +0100
+++ b/tests/src/Appender/RollingFileAppenderTest.cs Tue Jan 22 14:37:21
On 01/22/2013 02:41 PM, Dominik Psenner wrote:
diff -r 569e06c6cfb3 -r c4b727dc790c src/Appender/RollingFileAppender.cs
--- a/src/Appender/RollingFileAppender.cs Tue Jan 22 14:31:43 2013 +0100
+++ b/src/Appender/RollingFileAppender.cs Tue Jan 22 14:31:58 2013 +0100
@@ -835,6 +835,11
[
https://issues.apache.org/jira/browse/LOG4NET-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559795#comment-13559795
]
Dominik Psenner commented on LOG4NET-27:
Hi Hans. Thanks for your help!
) with it.
* Kill it immediately.
Log directory now looks like this
---
log.log
---
* Wait until we are in another minute
* Start application again
* Kill it immediately
Log directory now looks like this
---
log.log
log.log.20130122-2042
---
Didn't we say we want
this
---
log.log
---
* Wait until we are in another minute
* Start application again
* Kill it immediately
Log directory now looks like this
---
log.log
log.log.20130122-2042
---
Didn't we say we want to preserveLogFileNameExtension?
Shouldn't the file name of the file rolled
Do you expect any response from other devs?
No.
In case you do, we practice CTR (Commit then review). If you are happy
with the patches, then just apply them to the code. If you are not
happy / in doubt, get to the ML. No need to wait for a second
confirmation :-)
I'm expecting feedback from
now looks like this
---
log.log
---
* Wait until we are in another minute
* Start application again
* Kill it immediately
Log directory now looks like this
---
log.log
log.log.20130122-2042
---
Didn't we say we want to preserveLogFileNameExtension?
Shouldn't the file name
it immediately.
Log directory now looks like this
---
log.log
---
* Wait until we are in another minute
* Start application again
* Kill it immediately
Log directory now looks like this
---
log.log
log.log.20130122-2042
---
Didn't we say we want to preserveLogFileNameExtension
until we are in another minute
* Start application again
* Kill it immediately
Log directory now looks like this
---
log.log
log.log.20130122-2042
---
Didn't we say we want to preserveLogFileNameExtension?
Shouldn't the file name of the file rolled over be log.20130122-2042.log
* Start application again
* Kill it immediately
Log directory now looks like this
---
log.log
log.log.20130122-2042
---
Didn't we say we want to preserveLogFileNameExtension?
Shouldn't the file name of the file rolled over be log.20130122-2042.log?
If the application weren't
20 matches
Mail list logo