GitHub user JJoe2 opened a pull request:
https://github.com/apache/log4net/pull/24
Use UTC internally to avoid ambiguous times
Currently log4net uses local times internally and converts to UTC on output
when needed (e.g. UtcDatePatternConverter). This can result in inaccurate UTC
times during one hour each year when local time is ambiguous
(DateTime.IsAmbiguous = true) for time zones that use daylight saving time.
Also TimeEvaluator uses local time, which means it can trigger too early or
too late when local time is ambiguous.
This change stores current date/time as UTC internally, converting to local
when required.
No new unit tests added as to do so would require mocking DateTime.Now /
DateTime.UtcNow, which isn't justified for such a simple change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JJoe2/log4net trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/log4net/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit a66d2fc61c4a1cfd8317aee41385ef6c43373ffc
Author: JoeJoe <jocular...@hotmail.com>
Date: 2016-04-22T19:21:07Z
Use UTC internally to avoid ambiguous times
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
