[GitHub] log4net issue #35: Wip/app settings

[JJoe2]

Github user JJoe2 commented on the issue:

https://github.com/apache/log4net/pull/35
  
Hi Stefan,

That's correct, those are the only changes.

Thanks,


From: Stefan Bodewig 
Sent: 23 October 2016 16:33:48
To: apache/log4net
Cc: JJoe2; Author
Subject: Re: [apache/log4net] Wip/app settings (#35)


Am I correct that AppSettingPatternConverter and the few changes in 
PatternString are the only relevant code changes (along with adding the new 
filte to the solution files)? If so, I can pick up the file myself, no need to 
rebase the PR.

-
You are receiving this because you authored the thread.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : log4net-trunk-tests #13

[Apache Jenkins Server]

See 

[jira] [Resolved] (LOG4NET-527) broken link on config-examples.html

[Dominik Psenner (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LOG4NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Psenner resolved LOG4NET-527.
-
   Resolution: Fixed
Fix Version/s: 2.0.6

> broken link on config-examples.html
> ---
>
> Key: LOG4NET-527
> URL: https://issues.apache.org/jira/browse/LOG4NET-527
> Project: Log4net
>  Issue Type: Bug
>  Components: Examples
>Reporter: raymond sanhcez
>Assignee: Dominik Psenner
>Priority: Minor
> Fix For: 2.0.6
>
> Attachments: config-examples.xml.patch
>
>
> I needed more information on AdoNetAppender but encounter a broken link.
> If you go to https://logging.apache.org/log4net/release/config-examples.html 
> and click on the link under AdoNetAppender, you will get not found error.
> I'm attaching a patch so we can fix this minor issue.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (LOG4NET-527) broken link on config-examples.html

[Dominik Psenner (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605471#comment-15605471
 ] 

Dominik Psenner edited comment on LOG4NET-527 at 10/25/16 2:34 PM:
---

Fixed with revision 1766540

Several other links were broken too and I did my best to fix them. Please note 
that the links will be fixed with the next release.


was (Author: nachbarslumpi):
Fixed with revision 1766540

Several other links were broken too and I did my best to fix them.

> broken link on config-examples.html
> ---
>
> Key: LOG4NET-527
> URL: https://issues.apache.org/jira/browse/LOG4NET-527
> Project: Log4net
>  Issue Type: Bug
>  Components: Examples
>Reporter: raymond sanhcez
>Assignee: Dominik Psenner
>Priority: Minor
> Fix For: 2.0.6
>
> Attachments: config-examples.xml.patch
>
>
> I needed more information on AdoNetAppender but encounter a broken link.
> If you go to https://logging.apache.org/log4net/release/config-examples.html 
> and click on the link under AdoNetAppender, you will get not found error.
> I'm attaching a patch so we can fix this minor issue.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-527) broken link on config-examples.html

[Dominik Psenner (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605471#comment-15605471
 ] 

Dominik Psenner commented on LOG4NET-527:
-

Fixed with revision 1766540

Several other links were broken too and I did my best to fix them.

> broken link on config-examples.html
> ---
>
> Key: LOG4NET-527
> URL: https://issues.apache.org/jira/browse/LOG4NET-527
> Project: Log4net
>  Issue Type: Bug
>  Components: Examples
>Reporter: raymond sanhcez
>Assignee: Dominik Psenner
>Priority: Minor
> Attachments: config-examples.xml.patch
>
>
> I needed more information on AdoNetAppender but encounter a broken link.
> If you go to https://logging.apache.org/log4net/release/config-examples.html 
> and click on the link under AdoNetAppender, you will get not found error.
> I'm attaching a patch so we can fix this minor issue.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (LOG4NET-527) broken link on config-examples.html

[Dominik Psenner (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LOG4NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Psenner reassigned LOG4NET-527:
---

Assignee: Dominik Psenner

> broken link on config-examples.html
> ---
>
> Key: LOG4NET-527
> URL: https://issues.apache.org/jira/browse/LOG4NET-527
> Project: Log4net
>  Issue Type: Bug
>  Components: Examples
>Reporter: raymond sanhcez
>Assignee: Dominik Psenner
>Priority: Minor
> Attachments: config-examples.xml.patch
>
>
> I needed more information on AdoNetAppender but encounter a broken link.
> If you go to https://logging.apache.org/log4net/release/config-examples.html 
> and click on the link under AdoNetAppender, you will get not found error.
> I'm attaching a patch so we can fix this minor issue.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-527) broken link on config-examples.html

[Dominik Psenner (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604531#comment-15604531
 ] 

Dominik Psenner commented on LOG4NET-527:
-

Thanks for the report. The link should probably read as follows:

/log4net/release/sdk/html/AllMembers_T_log4net_Appender_AdoNetAppender.htm

Going to change it right away.

> broken link on config-examples.html
> ---
>
> Key: LOG4NET-527
> URL: https://issues.apache.org/jira/browse/LOG4NET-527
> Project: Log4net
>  Issue Type: Bug
>  Components: Examples
>Reporter: raymond sanhcez
>Priority: Minor
> Attachments: config-examples.xml.patch
>
>
> I needed more information on AdoNetAppender but encounter a broken link.
> If you go to https://logging.apache.org/log4net/release/config-examples.html 
> and click on the link under AdoNetAppender, you will get not found error.
> I'm attaching a patch so we can fix this minor issue.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)