[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support

2016-09-27 Thread chlowell
Github user chlowell commented on the issue: https://github.com/apache/log4net/pull/16 Targeting `netstandard1.6` here is more limiting than useful. Doing so would remove support for current UWP apps, and the larger API surface won't light up any major features. --- If your project

[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support

2016-09-13 Thread chlowell
Github user chlowell commented on the issue: https://github.com/apache/log4net/pull/16 No, there are significant differences. My first post details some important ones. .NET Framework 4.6 implements `netstandard1.3`. This means it exposes all the APIs specified

[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support

2016-09-13 Thread chlowell
Github user chlowell commented on the issue: https://github.com/apache/log4net/pull/16 @bodewig I chose the version number to prevent any confusion between prerelease and published packages. There's no reason not to change it before release. I chose `netstandard1.3` because

[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support

2016-07-13 Thread chlowell
Github user chlowell commented on a diff in the pull request: https://github.com/apache/log4net/pull/16#discussion_r70652017 --- Diff: src/Util/ReadOnlyPropertiesDictionary.cs --- @@ -215,8 +216,13 @@ public virtual void GetObjectData(SerializationInfo info, StreamingContext conte

[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support

2016-07-12 Thread chlowell
Github user chlowell commented on the issue: https://github.com/apache/log4net/pull/16 I updated this branch for .NET Core 1.0 rather than creating a new PR. The branch name is unfortunate--there's no longer a PCL involved--but I hope keeping this open is convenient for those

[GitHub] log4net pull request: [WIP] (LOG4NET-467) .NET Core support

2016-05-27 Thread chlowell
Github user chlowell commented on the pull request: https://github.com/apache/log4net/pull/16#issuecomment-222199688 I have another branch on my fork (`dotnetcore-rc2`) which builds with RC2 tools, and has some improvements over the code here. A few tests are broken due to executing