[GitHub] log4net issue #35: Wip/app settings

Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/35 I've just realized there is no documentation outside of the API docs for the other `PatternStringConverter`s either, so yes, XML comments should be sufficient - and you've already provided that. I

[GitHub] log4net issue #35: Wip/app settings

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/35 I’ll be happy to do the unit tests and possibly the doc. Are suitable XML comments enough? Now this is added, I’ll also be thinking about the next step, which is to allow the

[GitHub] log4net issue #35: Wip/app settings

Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/35 I've added your converter, many thanks. Tests would be good and we need documentation before we can close LOG4NET-526. --- If your project is set up for it, you can reply to this email and

[GitHub] log4net issue #35: Wip/app settings

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/35 Hi Stefan, That's correct, those are the only changes. Thanks, From: Stefan Bodewig Sent: 23 October 2016

[GitHub] log4net issue #35: Wip/app settings

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/35 I'll rebase this after #36 and #37 have been processed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have