[jira] [Commented] (LOG4NET-554) LogicalThreadContext was removed in .NETStandard

2017-03-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895100#comment-15895100
 ] 

ASF GitHub Bot commented on LOG4NET-554:


Github user asfgit closed the pull request at:

https://github.com/apache/log4net/pull/42


> LogicalThreadContext was removed in .NETStandard
> 
>
> Key: LOG4NET-554
> URL: https://issues.apache.org/jira/browse/LOG4NET-554
> Project: Log4net
>  Issue Type: Bug
>  Components: Builds
>Affects Versions: 2.0.6, 2.0.7
> Environment: .NETStandard1.3
>Reporter: Thomas Clegg
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> LogicalThreadContext was excluded from dotnetcore version due to 
> System.Runtime.Remoting.Messaging no longer being available going forward.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (LOG4NET-554) LogicalThreadContext was removed in .NETStandard

2017-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887123#comment-15887123
 ] 

ASF GitHub Bot commented on LOG4NET-554:


GitHub user twcclegg opened a pull request:

https://github.com/apache/log4net/pull/42

LOG4NET-554 Use AsyncLocal for LogicalThreadContext

Replaces System.Runtime.Remoting.Messaging.CallContext which was removed in 
.NETStandard, with System.Threading.AsyncLocal which exists in .NET 4.6 and 
above

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twcclegg/log4net-1 AsyncLocal4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/log4net/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #42


commit 53d435577890ef9a68b8929acead75301be9151a
Author: Thomas Clegg 
Date:   2017-02-27T20:37:50Z

LOG4NET-554 Use AsyncLocal for LogicalThreadContext

commit cdcf231b028db599ff9f04705dc9ca1a0ecb17a0
Author: Thomas Clegg 
Date:   2017-02-27T21:14:44Z

remove LogicalThreadContext from not supported list




> LogicalThreadContext was removed in .NETStandard
> 
>
> Key: LOG4NET-554
> URL: https://issues.apache.org/jira/browse/LOG4NET-554
> Project: Log4net
>  Issue Type: Bug
>  Components: Builds
>Affects Versions: 2.0.6, 2.0.7
> Environment: .NETStandard1.3
>Reporter: Thomas Clegg
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> LogicalThreadContext was excluded from dotnetcore version due to 
> System.Runtime.Remoting.Messaging no longer being available going forward.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (LOG4NET-554) LogicalThreadContext was removed in .NETStandard

2017-02-17 Thread Dominik Psenner (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872182#comment-15872182
 ] 

Dominik Psenner commented on LOG4NET-554:
-

Interesting, I look forward seeing a patch!

> LogicalThreadContext was removed in .NETStandard
> 
>
> Key: LOG4NET-554
> URL: https://issues.apache.org/jira/browse/LOG4NET-554
> Project: Log4net
>  Issue Type: Bug
>  Components: Builds
>Affects Versions: 2.0.6, 2.0.7
> Environment: .NETStandard1.3
>Reporter: Thomas Clegg
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> LogicalThreadContext was excluded from dotnetcore version due to 
> System.Runtime.Remoting.Messaging no longer being available going forward.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (LOG4NET-554) LogicalThreadContext was removed in .NETStandard

2017-02-17 Thread Stefan Bodewig (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872183#comment-15872183
 ] 

Stefan Bodewig commented on LOG4NET-554:


Thank you

> LogicalThreadContext was removed in .NETStandard
> 
>
> Key: LOG4NET-554
> URL: https://issues.apache.org/jira/browse/LOG4NET-554
> Project: Log4net
>  Issue Type: Bug
>  Components: Builds
>Affects Versions: 2.0.6, 2.0.7
> Environment: .NETStandard1.3
>Reporter: Thomas Clegg
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> LogicalThreadContext was excluded from dotnetcore version due to 
> System.Runtime.Remoting.Messaging no longer being available going forward.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (LOG4NET-554) LogicalThreadContext was removed in .NETStandard

2017-02-17 Thread Thomas Clegg (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872154#comment-15872154
 ] 

Thomas Clegg commented on LOG4NET-554:
--

My team's use case is highly dependent on this functionality and as such we 
obviously don't want to lose it. The same functionality should be available via 
AsyncLocal which is supported in .NET 4.6 and above. I'm actively working on 
a patch to get things working again.

> LogicalThreadContext was removed in .NETStandard
> 
>
> Key: LOG4NET-554
> URL: https://issues.apache.org/jira/browse/LOG4NET-554
> Project: Log4net
>  Issue Type: Bug
>  Components: Builds
>Affects Versions: 2.0.6, 2.0.7
> Environment: .NETStandard1.3
>Reporter: Thomas Clegg
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> LogicalThreadContext was excluded from dotnetcore version due to 
> System.Runtime.Remoting.Messaging no longer being available going forward.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (LOG4NET-554) LogicalThreadContext was removed in .NETStandard

2017-02-16 Thread Stefan Bodewig (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871355#comment-15871355
 ] 

Stefan Bodewig commented on LOG4NET-554:


True. This is why it is excluded from the build that targets netstandard-1.3.

What do you want us to change?

> LogicalThreadContext was removed in .NETStandard
> 
>
> Key: LOG4NET-554
> URL: https://issues.apache.org/jira/browse/LOG4NET-554
> Project: Log4net
>  Issue Type: Bug
>  Components: Builds
>Affects Versions: 2.0.6, 2.0.7
> Environment: .NETStandard1.3
>Reporter: Thomas Clegg
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> LogicalThreadContext was excluded from dotnetcore version due to 
> System.Runtime.Remoting.Messaging no longer being available going forward.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)