RE: recommendation for AspNetPatternLayoutConverter

2012-07-30 Thread Dominik Psenner
[mailto:geo...@glympse.com] Sent: Monday, July 30, 2012 4:40 AM To: Log4NET Dev Subject: Re: recommendation for AspNetPatternLayoutConverter Yes, I completely discounted backwards compatibility, sorry. On Sun, Jul 29, 2012 at 2:13 PM, Dominik Psenner dpsen...@gmail.com wrote: On 07/27/2012 10:42

Re: recommendation for AspNetPatternLayoutConverter

2012-07-30 Thread George Chung
Dev *Subject:* Re: recommendation for AspNetPatternLayoutConverter ** ** Yes, I completely discounted backwards compatibility, sorry. On Sun, Jul 29, 2012 at 2:13 PM, Dominik Psenner dpsen...@gmail.com wrote: On 07/27/2012 10:42 PM, George Chung wrote: It currently defines

Re: recommendation for AspNetPatternLayoutConverter

2012-07-29 Thread Dominik Psenner
On 07/27/2012 10:42 PM, George Chung wrote: It currently defines this abstract method: protected abstract void Convert(TextWriter writer, LoggingEvent loggingEvent, HttpContext httpContext) I would recommend changing it to: protected abstract void Convert(TextWriter writer,

Re: recommendation for AspNetPatternLayoutConverter

2012-07-29 Thread George Chung
Yes, I completely discounted backwards compatibility, sorry. On Sun, Jul 29, 2012 at 2:13 PM, Dominik Psenner dpsen...@gmail.com wrote: On 07/27/2012 10:42 PM, George Chung wrote: It currently defines this abstract method: protected abstract void Convert(TextWriter writer, LoggingEvent