Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Stefan Bodewig
Many thanks for reviewing On 2016-12-22, Gary Gregory wrote: > Running build.cmd succeeds. ASC, MD5, SHA1, SHA256 OK. If you are going to > provide SHA1 or SHA256, you can do away with MD5 IMO. > -1 based on the RAT check failures: > 18 Unknown Licenses most of them are generated, namely > b

Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Gary Gregory
Running build.cmd succeeds. ASC, MD5, SHA1, SHA256 OK. If you are going to provide SHA1 or SHA256, you can do away with MD5 IMO. -1 based on the RAT check failures: 18 Unknown Licenses *** Unapproved licenses: bin/net/2.0/debug/log4net.xml bin/net/2.0/release/log

Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Apache
I suggest you include the PMC in your vote thread. Ralph > On Dec 22, 2016, at 7:58 AM, Stefan Bodewig wrote: > > Making my own vote explicit > > On 2016-12-20, Stefan Bodewig wrote: > >> Votes, please. This vote will close in 72 hours, 1000 GMT 24-Dec 2016 > >> [X] +1 Release these artifac

Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Stefan Bodewig
Making my own vote explicit On 2016-12-20, Stefan Bodewig wrote: > Votes, please. This vote will close in 72 hours, 1000 GMT 24-Dec 2016 > [X] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... +1 Stefan

Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Dominik Psenner
Great! All in all this is a clear +1 from Italy. On 2016-12-22 14:04, Stefan Bodewig wrote: On 2016-12-22, Dominik Psenner wrote: A question about the .net core support: according to the documentation, .net remoting is not available with .net standard 1.3. Would that mean too that the log4ne

Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Stefan Bodewig
On 2016-12-22, Dominik Psenner wrote: > Gotcha at http://stefan.samaflost.de/staging/log4net-2.0.6/license.html > {quote} > Copyright [] [name of copyright owner] > {quote > We should replace the placeholders. No, we should not, this is how it is supposed to be. This is inside the appen

Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Stefan Bodewig
On 2016-12-22, Dominik Psenner wrote: > A question about the .net core support: > according to the documentation, .net remoting is not available with > .net standard 1.3. Would that mean too that the > log4net.ThreadLogicalContext is not available either because it > requires System.Runtime.Remot

Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Stefan Bodewig
On 2016-12-22, Dominik Psenner wrote: > thanks for carving out 2.0.6. I'm looking through the website and am > going to run some sanity checks right now. Are you planning to push > this to nuget? Once the release vote has passed, yes. Stefan

Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Dominik Psenner
Just finished the tests and the binaries work for me. This means that the functionality is there but we have to discuss if the license issue is a showstopper before I can cast my vote. Cheers On 2016-12-20 11:07, Stefan Bodewig wrote: Hi all log4net 2.0.6 RC1 is available for review here:

Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Dominik Psenner
Gotcha at http://stefan.samaflost.de/staging/log4net-2.0.6/license.html {quote} Copyright [] [name of copyright owner] {quote We should replace the placeholders. On 2016-12-20 11:07, Stefan Bodewig wrote: Hi all log4net 2.0.6 RC1 is available for review here: https://dist.apache.or

Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Dominik Psenner
A question about the .net core support: according to the documentation, .net remoting is not available with .net standard 1.3. Would that mean too that the log4net.ThreadLogicalContext is not available either because it requires System.Runtime.Remoting.Messaging.CallContext? If so, is this w

Re: [VOTE] Release log4net 2.0.6 based on RC1

2016-12-22 Thread Dominik Psenner
Hi Stefan, thanks for carving out 2.0.6. I'm looking through the website and am going to run some sanity checks right now. Are you planning to push this to nuget? Cheers, Dominik On 2016-12-20 11:07, Stefan Bodewig wrote: Hi all log4net 2.0.6 RC1 is available for review here: https://di