Re: [VOTE] Release log4net 2.0.6 based on RC1

[Gary Gregory]

Running build.cmd succeeds. ASC, MD5, SHA1, SHA256 OK. If you are going to
provide SHA1 or SHA256, you can do away with MD5 IMO.

-1 based on the RAT check failures:
18 Unknown Licenses

***

Unapproved licenses:

  bin/net/2.0/debug/log4net.xml
  bin/net/2.0/release/log4net.xml
  bin/net/3.5/debug/log4net.xml
  bin/net/3.5/release/log4net.xml
  bin/net/4.0/debug/log4net.xml
  bin/net/4.0/release/log4net.xml
  bin/net/4.5/debug/log4net.xml
  bin/net/4.5/release/log4net.xml
  bin/net-cp/3.5/debug/log4net.xml
  bin/net-cp/3.5/release/log4net.xml
  bin/net-cp/4.0/debug/log4net.xml
  bin/net-cp/4.0/release/log4net.xml
  log4net.snk.readme
  netstandard/global.json
  netstandard/log4net/project.json
  netstandard/log4net.tests/project.json
  src/GeneratedAssemblyInfo.cs
  tests/lib/prerequisites.txt

It would help to have a BUILDING.txt file to guide reviewers.



Gary

On Tue, Dec 20, 2016 at 2:07 AM, Stefan Bodewig  wrote:

> Hi all
>
> log4net 2.0.6 RC1 is available for review here:
>   https://dist.apache.org/repos/dist/dev/logging/log4net
>   (revision 17495)
>
> Details of changes since 1.2.15 are in the release notes:
>   http://stefan.samaflost.de/staging/log4net-2.0.6/release/
> release-notes.html
>
> I have tested this with Mono and several .NET frameworks using NAnt.
>
> The tag is here:
>   https://svn.apache.org/repos/asf/logging/log4net/tags/2.0.6RC1
>   (revision 1775236)
>
> Site:
>   http://stefan.samaflost.de/staging/log4net-2.0.6/
>
> RAT Report:
>   http://stefan.samaflost.de/staging/log4net-2.0.6/rat-report.html
>
> Nuget Package:
>   https://www.myget.org/feed/log4net-test/package/nuget/log4net
>
> Votes, please.  This vote will close in 72 hours, 1000 GMT 24-Dec 2016
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [VOTE] Release log4net 2.0.6 based on RC1

[Apache]

I suggest you include the PMC in your vote thread.

Ralph

> On Dec 22, 2016, at 7:58 AM, Stefan Bodewig  wrote:
> 
> Making my own vote explicit
> 
> On 2016-12-20, Stefan Bodewig wrote:
> 
>> Votes, please.  This vote will close in 72 hours, 1000 GMT 24-Dec 2016
> 
>> [X] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...
> 
> +1
> 
> Stefan
> 

Re: [VOTE] Release log4net 2.0.6 based on RC1

[Stefan Bodewig]

Making my own vote explicit

On 2016-12-20, Stefan Bodewig wrote:

> Votes, please.  This vote will close in 72 hours, 1000 GMT 24-Dec 2016

> [X] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...

+1

Stefan

Re: [VOTE] Release log4net 2.0.6 based on RC1

[Dominik Psenner]

Great! All in all this is a clear

+1

from Italy.

On 2016-12-22 14:04, Stefan Bodewig wrote:

On 2016-12-22, Dominik Psenner wrote:


A question about the .net core support:
according to the documentation, .net remoting is not available with
.net standard 1.3. Would that mean too that the
log4net.ThreadLogicalContext is not available either because it
requires System.Runtime.Remoting.Messaging.CallContext?

You mean LogicalThreadContext? You are right, this one is excluded. I'll
add it to the list of things that don't work.

This - as well as fixing the license page - can be done independent of
the release as we can change the site whenever we want to.

Many thanks for testing

  Stefan

Re: [VOTE] Release log4net 2.0.6 based on RC1

[Stefan Bodewig]

On 2016-12-22, Dominik Psenner wrote:

> Gotcha at http://stefan.samaflost.de/staging/log4net-2.0.6/license.html

> {quote}

>  Copyright [] [name of copyright owner]


> {quote

> We should replace the placeholders.

No, we should not, this is how it is supposed to be. This is inside the
appendix about how anybody can apply the license to their own work
(which wouldn't be copyright by the ASF and probably use different years
from log4net). See also http://www.apache.org/licenses/LICENSE-2.0

Stefan


> On 2016-12-20 11:07, Stefan Bodewig wrote:
>> Hi all

>> log4net 2.0.6 RC1 is available for review here:
>>https://dist.apache.org/repos/dist/dev/logging/log4net
>>(revision 17495)

>> Details of changes since 1.2.15 are in the release notes:
>>
>> http://stefan.samaflost.de/staging/log4net-2.0.6/release/release-notes.html

>> I have tested this with Mono and several .NET frameworks using NAnt.

>> The tag is here:
>>https://svn.apache.org/repos/asf/logging/log4net/tags/2.0.6RC1
>>(revision 1775236)

>> Site:
>>http://stefan.samaflost.de/staging/log4net-2.0.6/

>> RAT Report:
>>http://stefan.samaflost.de/staging/log4net-2.0.6/rat-report.html

>> Nuget Package:
>>https://www.myget.org/feed/log4net-test/package/nuget/log4net

>> Votes, please.  This vote will close in 72 hours, 1000 GMT 24-Dec 2016

>> [ ] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...

>> Thanks!

Re: [VOTE] Release log4net 2.0.6 based on RC1

[Stefan Bodewig]

On 2016-12-22, Dominik Psenner wrote:

> A question about the .net core support:

> according to the documentation, .net remoting is not available with
> .net standard 1.3. Would that mean too that the
> log4net.ThreadLogicalContext is not available either because it
> requires System.Runtime.Remoting.Messaging.CallContext?

You mean LogicalThreadContext? You are right, this one is excluded. I'll
add it to the list of things that don't work.

This - as well as fixing the license page - can be done independent of
the release as we can change the site whenever we want to.

Many thanks for testing

 Stefan

Re: [VOTE] Release log4net 2.0.6 based on RC1

[Stefan Bodewig]

On 2016-12-22, Dominik Psenner wrote:

> thanks for carving out 2.0.6. I'm looking through the website and am
> going to run some sanity checks right now. Are you planning to push
> this to nuget?

Once the release vote has passed, yes.

Stefan

Re: [VOTE] Release log4net 2.0.6 based on RC1

[Dominik Psenner]

Just finished the tests and the binaries work for me. This means that 
the functionality is there but we have to discuss if the license issue 
is a showstopper before I can cast my vote.


Cheers

On 2016-12-20 11:07, Stefan Bodewig wrote:

Hi all

log4net 2.0.6 RC1 is available for review here:
   https://dist.apache.org/repos/dist/dev/logging/log4net
   (revision 17495)

Details of changes since 1.2.15 are in the release notes:
   http://stefan.samaflost.de/staging/log4net-2.0.6/release/release-notes.html

I have tested this with Mono and several .NET frameworks using NAnt.

The tag is here:
   https://svn.apache.org/repos/asf/logging/log4net/tags/2.0.6RC1
   (revision 1775236)

Site:
   http://stefan.samaflost.de/staging/log4net-2.0.6/

RAT Report:
   http://stefan.samaflost.de/staging/log4net-2.0.6/rat-report.html

Nuget Package:
   https://www.myget.org/feed/log4net-test/package/nuget/log4net

Votes, please.  This vote will close in 72 hours, 1000 GMT 24-Dec 2016

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thanks!

Re: [VOTE] Release log4net 2.0.6 based on RC1

[Dominik Psenner]

Gotcha at http://stefan.samaflost.de/staging/log4net-2.0.6/license.html

{quote}

 Copyright [] [name of copyright owner]


{quote

We should replace the placeholders.

On 2016-12-20 11:07, Stefan Bodewig wrote:

Hi all

log4net 2.0.6 RC1 is available for review here:
   https://dist.apache.org/repos/dist/dev/logging/log4net
   (revision 17495)

Details of changes since 1.2.15 are in the release notes:
   http://stefan.samaflost.de/staging/log4net-2.0.6/release/release-notes.html

I have tested this with Mono and several .NET frameworks using NAnt.

The tag is here:
   https://svn.apache.org/repos/asf/logging/log4net/tags/2.0.6RC1
   (revision 1775236)

Site:
   http://stefan.samaflost.de/staging/log4net-2.0.6/

RAT Report:
   http://stefan.samaflost.de/staging/log4net-2.0.6/rat-report.html

Nuget Package:
   https://www.myget.org/feed/log4net-test/package/nuget/log4net

Votes, please.  This vote will close in 72 hours, 1000 GMT 24-Dec 2016

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thanks!

Re: [VOTE] Release log4net 2.0.6 based on RC1

[Dominik Psenner]

Hi Stefan,

thanks for carving out 2.0.6. I'm looking through the website and am 
going to run some sanity checks right now. Are you planning to push this 
to nuget?


Cheers,
Dominik

On 2016-12-20 11:07, Stefan Bodewig wrote:

Hi all

log4net 2.0.6 RC1 is available for review here:
   https://dist.apache.org/repos/dist/dev/logging/log4net
   (revision 17495)

Details of changes since 1.2.15 are in the release notes:
   http://stefan.samaflost.de/staging/log4net-2.0.6/release/release-notes.html

I have tested this with Mono and several .NET frameworks using NAnt.

The tag is here:
   https://svn.apache.org/repos/asf/logging/log4net/tags/2.0.6RC1
   (revision 1775236)

Site:
   http://stefan.samaflost.de/staging/log4net-2.0.6/

RAT Report:
   http://stefan.samaflost.de/staging/log4net-2.0.6/rat-report.html

Nuget Package:
   https://www.myget.org/feed/log4net-test/package/nuget/log4net

Votes, please.  This vote will close in 72 hours, 1000 GMT 24-Dec 2016

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thanks!