Re: [jira] Commented: (LOG4PHP-26) Add file locking to file appenders

2009-04-28 Thread Christian Grobmeier
>> Uhm, what happens if I actually wan't different php processes to log to >> the same file? >> I'm pretty sure I have done this at some point in Java. In PHP you do this with very hi chances. I think on high load servers which open multiple php processes and write to the same logfile. > File loc

Re: One class one file?

2009-04-28 Thread Christian Grobmeier
> I see that helpers/LoggerPatternConverter.php has many classes. I'm fine > with having multiple classes in the same file if the are classes that is > tightly tied to the main class in that particular file. OK > I think we have more important stuff to work on than moving classes around > ;) Wel

Re: Which PHP version to support in 2.0?

2009-04-28 Thread Christian Grobmeier
I agree to such a high PHP requirement. I usually check out which versions the biggest hosters currently have and it looks like that everybody is using 5.2.x and above. On Tue, Apr 28, 2009 at 11:16 PM, Knut Urdalen wrote: > We should probably agree on which versions we are supporting in log4php

Re: What do do with our database appenders?

2009-04-28 Thread Christian Grobmeier
Hi > Initially I would suggest to at least create a LoggerAppenderPDO and maybe > remove LoggerAppenderAdodb and LoggerAppenderDb. Any opinions? I think PDO would be a better choice. I don't like dependencies very much :-) and PDO is the way to go for future. But what about backwards compatibili

Re: [jira] Commented: (LOG4PHP-26) Add file locking to file appenders

2009-04-28 Thread Knut Urdalen
Dennis Korbar wrote: Uhm, what happens if I actually wan't different php processes to log to the same file? I'm pretty sure I have done this at some point in Java. File locking should only ensure that your log file doesn't include corrupt log messages due to race condition between two or more P

Re: [jira] Commented: (LOG4PHP-26) Add file locking to file appenders

2009-04-28 Thread Dennis Korbar
Uhm, what happens if I actually wan't different php processes to log to the same file? I'm pretty sure I have done this at some point in Java. 2009/4/28 Knut Urdalen (JIRA) > >[ > https://issues.apache.org/jira/browse/LOG4PHP-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-ta

svn commit: r769573 - /incubator/log4php/trunk/CHANGELOG

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 22:22:08 2009 New Revision: 769573 URL: http://svn.apache.org/viewvc?rev=769573&view=rev Log: (empty) Modified: incubator/log4php/trunk/CHANGELOG Modified: incubator/log4php/trunk/CHANGELOG URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/CHANGELOG

[jira] Created: (LOG4PHP-32) Refactor from using define to class contants

2009-04-28 Thread Knut Urdalen (JIRA)
Refactor from using define to class contants Key: LOG4PHP-32 URL: https://issues.apache.org/jira/browse/LOG4PHP-32 Project: Log4php Issue Type: Improvement Components: Code R

svn commit: r769570 - in /incubator/log4php/trunk/src/test/php: LoggerManagerTest.php phpunit.xml

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 22:19:10 2009 New Revision: 769570 URL: http://svn.apache.org/viewvc?rev=769570&view=rev Log: a few more test stubs and fixed test suite Modified: incubator/log4php/trunk/src/test/php/LoggerManagerTest.php incubator/log4php/trunk/src/test/php/phpunit.xml

svn commit: r769562 - in /incubator/log4php/trunk/src/main/php: ./ appenders/ config/ helpers/ layouts/ or/ spi/ varia/ xml/

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 22:03:07 2009 New Revision: 769562 URL: http://svn.apache.org/viewvc?rev=769562&view=rev Log: fixed #LOG4PHP-31 Modified: incubator/log4php/trunk/src/main/php/Logger.php incubator/log4php/trunk/src/main/php/LoggerAppender.php incubator/log4php/trunk/s

[jira] Created: (LOG4PHP-31) Removing unnecessary use of LOG4PHP_DIR

2009-04-28 Thread Knut Urdalen (JIRA)
Removing unnecessary use of LOG4PHP_DIR --- Key: LOG4PHP-31 URL: https://issues.apache.org/jira/browse/LOG4PHP-31 Project: Log4php Issue Type: Improvement Components: Code Reporter: K

svn commit: r769556 - in /incubator/log4php/trunk/src/main/php: LoggerManager.php LoggerPropertyConfigurator.php helpers/LoggerOptionConverter.php or/LoggerRendererMap.php xml/LoggerDOMConfigurator.ph

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 21:44:45 2009 New Revision: 769556 URL: http://svn.apache.org/viewvc?rev=769556&view=rev Log: even more fixed related to #LOG4PHP-29 Modified: incubator/log4php/trunk/src/main/php/LoggerManager.php incubator/log4php/trunk/src/main/php/LoggerPropertyConfig

svn commit: r769545 - in /incubator/log4php/trunk/src/main/php: LoggerAppender.php LoggerLayout.php or/LoggerObjectRenderer.php

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 21:20:22 2009 New Revision: 769545 URL: http://svn.apache.org/viewvc?rev=769545&view=rev Log: a few more fixes related to #LOG4PHP-29 Modified: incubator/log4php/trunk/src/main/php/LoggerAppender.php incubator/log4php/trunk/src/main/php/LoggerLayout.php

Which PHP version to support in 2.0?

2009-04-28 Thread Knut Urdalen
We should probably agree on which versions we are supporting in log4php 2.0. As far as I can see the the requirement is now raised to PHP >= 5.1.2 because of introduction of using spl_autoload_register(). For the record: Zend Framework 1.7.8 requires PHP >= 5.2.4 eZ Components 2008.2.2 requir

svn commit: r769537 - /incubator/log4php/trunk/src/main/php/LoggerManager.php

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 21:05:49 2009 New Revision: 769537 URL: http://svn.apache.org/viewvc?rev=769537&view=rev Log: added missing classes to classmap Modified: incubator/log4php/trunk/src/main/php/LoggerManager.php Modified: incubator/log4php/trunk/src/main/php/LoggerManager.php

Re: One class one file?

2009-04-28 Thread Knut Urdalen
Christian Grobmeier wrote: Have to check again - sorry, i wrote this in march hehe :-) Maybe we should add an Jira task? I see that helpers/LoggerPatternConverter.php has many classes. I'm fine with having multiple classes in the same file if the are classes that is tightly tied to the main

[jira] Created: (LOG4PHP-30) Implement LoggerAppenderPDO

2009-04-28 Thread Knut Urdalen (JIRA)
Implement LoggerAppenderPDO --- Key: LOG4PHP-30 URL: https://issues.apache.org/jira/browse/LOG4PHP-30 Project: Log4php Issue Type: New Feature Components: Code Reporter: Knut Urdalen

svn commit: r769528 - /incubator/log4php/trunk/build.xml

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 20:44:56 2009 New Revision: 769528 URL: http://svn.apache.org/viewvc?rev=769528&view=rev Log: fixed "mvn test" Modified: incubator/log4php/trunk/build.xml Modified: incubator/log4php/trunk/build.xml URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/

What do do with our database appenders?

2009-04-28 Thread Knut Urdalen
Hi, We both have LoggerAppenderAdodb which depends on the Adodb library [1] and LoggerAppenderDb which depends on PEAR::DB [2]. I think it's time to update our database appenders to some more reasonable back-ends. PEAR::DB in example is not being updated anymore and since the last version of

Re: Getting rid of author tags:

2009-04-28 Thread Knut Urdalen
Christian Grobmeier wrote: I have a commit ready for getting rid of the author tags and would like to apply. Since a user complained about this and I am unsure about all this legal stuff, I would like to have your "go"s for this commit. (Please don't check the patch applied to the bug, I have re-

svn commit: r769476 - /incubator/log4php/trunk/CHANGELOG

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 17:39:07 2009 New Revision: 769476 URL: http://svn.apache.org/viewvc?rev=769476&view=rev Log: added change log file Added: incubator/log4php/trunk/CHANGELOG Added: incubator/log4php/trunk/CHANGELOG URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/C

[jira] Commented: (LOG4PHP-26) Add file locking to file appenders

2009-04-28 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703698#action_12703698 ] Knut Urdalen commented on LOG4PHP-26: - We have raised this discussion as part of anothe

Re: [jira] Closed: (LOG4PHP-21) Incorrect params passed in set_include_path

2009-04-28 Thread Knut Urdalen
Gavin wrote: So your log message for the above issue correctly ties in to the Jira Issue :- Log: fixed #LOG4PHP-21 but in cases like these I would like to see something like :- Log: fixed #LOG4PHP-21 - Due to Ion CERTEJAN or Log: fixed #LOG4PHP-21 - With thanks to Ion CERTEJAN Entirely your

Re: Autoloading now in trunk

2009-04-28 Thread Knut Urdalen
Christian Grobmeier wrote: does this function break applications which defined an own autoload? No, it should not. You can only have one __autoload() function while with spl_autoload_register() you can add multiple autoload functions to the autoload stack. http://de.php.net/spl_autoload_

[jira] Resolved: (LOG4PHP-9) log4php.dtd should be reviewed

2009-04-28 Thread Christian Grobmeier (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Grobmeier resolved LOG4PHP-9. --- Resolution: Fixed I added: http://logging.apache.org/log4php as namespace since there

[jira] Resolved: (LOG4PHP-24) LoggerAppenderRollingFile unable to rollover

2009-04-28 Thread Christian Grobmeier (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Grobmeier resolved LOG4PHP-24. Resolution: Fixed Committed revision 769426. Thanks! > LoggerAppenderRollingFile u

Re: One class one file?

2009-04-28 Thread Christian Grobmeier
>> i figured out that not every class in log4php has it's own file. >> Can we agree on that convention? > > Fine, which files do you think of? I'm working on the autoload > implementation and would like to know ;) Have to check again - sorry, i wrote this in march hehe :-) Maybe we should add an J

Re: Autoloading now in trunk

2009-04-28 Thread Christian Grobmeier
Hi Knut, does this function break applications which defined an own autoload? http://de.php.net/spl_autoload_register "If your code has an existing __autoload function then this function must be explicitly registered on the __autoload stack." This would break for example the PIWI frameworks incl

[jira] Resolved: (LOG4PHP-29) Load classes through autoload instead of explicitly include them

2009-04-28 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen resolved LOG4PHP-29. - Resolution: Fixed > Load classes through autoload instead of explicitly include them > --

Autoloading now in trunk

2009-04-28 Thread Knut Urdalen
Hi all, As you may have seen I've just refactored trunk to load classes with PHP's autoload [1]. I've tested all examples and current unit tests with this change and nothing should break. The LoggerManager is now self aware of all classes and autoload is registered when you include LoggerMan

svn commit: r769408 - in /incubator/log4php/trunk/src: main/php/ main/php/appenders/ main/php/config/ main/php/helpers/ main/php/layouts/ main/php/or/ main/php/spi/ main/php/varia/ main/php/xml/ test/

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 14:05:21 2009 New Revision: 769408 URL: http://svn.apache.org/viewvc?rev=769408&view=rev Log: fixed #LOG4PHP-29 Modified: incubator/log4php/trunk/src/main/php/Logger.php incubator/log4php/trunk/src/main/php/LoggerAppenderSkeleton.php incubator/log4php

RE: New committers

2009-04-28 Thread Gavin
> -Original Message- > From: Curt Arnold [mailto:[email protected]] > Sent: Tuesday, 28 April 2009 11:14 PM > To: Log4PHP Dev > Subject: Re: New committers > > Good to see some new faces, but I'm curious about how it happened. I > don't recall any discussion or votes and I didn't reque

Re: One class one file?

2009-04-28 Thread Knut Urdalen
Christian Grobmeier wrote: i figured out that not every class in log4php has it's own file. Can we agree on that convention? Fine, which files do you think of? I'm working on the autoload implementation and would like to know ;) Knut

Re: New committers

2009-04-28 Thread Curt Arnold
Good to see some new faces, but I'm curious about how it happened. I don't recall any discussion or votes and I didn't request new accounts or make changes to the SVN authorization file.

[jira] Created: (LOG4PHP-29) Load classes through autoload instead of explicitly include them

2009-04-28 Thread Knut Urdalen (JIRA)
Load classes through autoload instead of explicitly include them Key: LOG4PHP-29 URL: https://issues.apache.org/jira/browse/LOG4PHP-29 Project: Log4php Issue Type: Improvement

Re: Google Summer Of Code

2009-04-28 Thread Christian Grobmeier
> Seems like we are a bit to late for that now. The "Mentoring organization > application deadline" was on March 13th for GSoC 2009. We have hands full with building community for log4php - guess this can wait for next year then :-) cheers

Re: Google Summer Of Code

2009-04-28 Thread Knut Urdalen
Christian Grobmeier wrote: should log4php propose a project idea to the GSoC? I guess this could build up the urgent necessary community quickly. Maybe we should propose the port to PHP5 or something. Wdyt? Seems like we are a bit to late for that now. The "Mentoring organization application

[jira] Resolved: (LOG4PHP-25) Allow to set environment variables in LoggerOptionConverter

2009-04-28 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen resolved LOG4PHP-25. - Resolution: Fixed > Allow to set environment variables in LoggerOptionConverter > ---

svn commit: r769373 - /incubator/log4php/trunk/src/main/php/helpers/LoggerOptionConverter.php

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 12:31:55 2009 New Revision: 769373 URL: http://svn.apache.org/viewvc?rev=769373&view=rev Log: fixed #LOG4PHP-25 Modified: incubator/log4php/trunk/src/main/php/helpers/LoggerOptionConverter.php Modified: incubator/log4php/trunk/src/main/php/helpers/LoggerOpti

[jira] Resolved: (LOG4PHP-28) LoggerAppenderConsole doesn't write to STDERR

2009-04-28 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen resolved LOG4PHP-28. - Resolution: Fixed Fix Version/s: 2.0 Assignee: Knut Urdalen Thanks Michael! I've

svn commit: r769355 - in /incubator/log4php/trunk/src: examples/php/console.properties main/php/LoggerPropertyConfigurator.php main/php/appenders/LoggerAppenderConsole.php

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 12:12:31 2009 New Revision: 769355 URL: http://svn.apache.org/viewvc?rev=769355&view=rev Log: fixed #LOG4PHP-28 Modified: incubator/log4php/trunk/src/examples/php/console.properties incubator/log4php/trunk/src/main/php/LoggerPropertyConfigurator.php i

RE: [jira] Closed: (LOG4PHP-21) Incorrect params passed in set_include_path

2009-04-28 Thread Gavin
> -Original Message- > From: Knut Urdalen (JIRA) [mailto:[email protected]] > Sent: Tuesday, 28 April 2009 5:05 PM > To: [email protected] > Subject: [jira] Closed: (LOG4PHP-21) Incorrect params passed in > set_include_path > > > [ https://issues.apache.org/jira/browse/L

[jira] Updated: (LOG4PHP-28) LoggerAppenderConsole doesn't write to STDERR

2009-04-28 Thread Michael Kuenzli (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Kuenzli updated LOG4PHP-28: --- Attachment: LoggerAppenderConsole.patch > LoggerAppenderConsole doesn't write to STDERR > ---

Re: Getting rid of author tags:

2009-04-28 Thread Christian Grobmeier
>> http://www.mailinglistarchive.com/[email protected]/msg00068.html >> I think this lead to the issue. >> > Yes, Curt mentioned this decision from Apache that I was not aware of after > I did the initial commit of the PHP 5 port. Hence ticket #1 was created ;) So, what came out? Did

[jira] Created: (LOG4PHP-28) LoggerAppenderConsole doesn't write to STDERR

2009-04-28 Thread Michael Kuenzli (JIRA)
LoggerAppenderConsole doesn't write to STDERR - Key: LOG4PHP-28 URL: https://issues.apache.org/jira/browse/LOG4PHP-28 Project: Log4php Issue Type: Bug Components: Code Reporte

[jira] Assigned: (LOG4PHP-23) Mixed PHP4 and PHP5 syntax

2009-04-28 Thread Christian Grobmeier (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Grobmeier reassigned LOG4PHP-23: -- Assignee: Christian Grobmeier > Mixed PHP4 and PHP5 syntax > --

[jira] Created: (LOG4PHP-27) Add the option of defining permissions of a log file

2009-04-28 Thread Knut Urdalen (JIRA)
Add the option of defining permissions of a log file Key: LOG4PHP-27 URL: https://issues.apache.org/jira/browse/LOG4PHP-27 Project: Log4php Issue Type: New Feature Components: Co

[jira] Created: (LOG4PHP-26) Add file locking to file appenders

2009-04-28 Thread Knut Urdalen (JIRA)
Add file locking to file appenders -- Key: LOG4PHP-26 URL: https://issues.apache.org/jira/browse/LOG4PHP-26 Project: Log4php Issue Type: New Feature Components: Code Reporter: Knut Urdale

[jira] Created: (LOG4PHP-25) Allow to set environment variables in LoggerOptionConverter

2009-04-28 Thread Knut Urdalen (JIRA)
Allow to set environment variables in LoggerOptionConverter --- Key: LOG4PHP-25 URL: https://issues.apache.org/jira/browse/LOG4PHP-25 Project: Log4php Issue Type: Improvement

[jira] Updated: (LOG4PHP-1) Remove @author tags in code and document credits in README and website

2009-04-28 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen updated LOG4PHP-1: --- Component/s: Website Documentation > Remove @author tags in code and document credits

[jira] Updated: (LOG4PHP-16) Patch for LoggerAppenderSyslog to use Layouts

2009-04-28 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen updated LOG4PHP-16: Component/s: Code > Patch for LoggerAppenderSyslog to use Layouts > ---

[jira] Updated: (LOG4PHP-20) Custom layout for LoggerAppenderPhp

2009-04-28 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen updated LOG4PHP-20: Component/s: Code > Custom layout for LoggerAppenderPhp > --- > >

[jira] Updated: (LOG4PHP-9) log4php.dtd should be reviewed

2009-04-28 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen updated LOG4PHP-9: --- Component/s: Code > log4php.dtd should be reviewed > -- > >

[jira] Updated: (LOG4PHP-12) LoggerAppenderFile does not create missing directories

2009-04-28 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen updated LOG4PHP-12: Component/s: Code > LoggerAppenderFile does not create missing directories > --

[jira] Closed: (LOG4PHP-21) Incorrect params passed in set_include_path

2009-04-28 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen closed LOG4PHP-21. --- Resolution: Fixed Thanks! This is now fixed in trunk. (note that due to the refactoring of our unit

svn commit: r769266 - /incubator/log4php/trunk/src/test/php/bootstrap.php

2009-04-28 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 07:00:58 2009 New Revision: 769266 URL: http://svn.apache.org/viewvc?rev=769266&view=rev Log: fixed #LOG4PHP-21 Modified: incubator/log4php/trunk/src/test/php/bootstrap.php Modified: incubator/log4php/trunk/src/test/php/bootstrap.php URL: http://svn.apache.