Do we have a buildserver (cruisecontrol/phpundercontrol) or otherwise
maybe I could start by looking in to this project.
When we have build server we should make it package the
product(log4php) for pear automatically and maybe deploy it to a pear
repository as a aplha/beta/something.
We s
[
https://issues.apache.org/jira/browse/LOG4PHP-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen updated LOG4PHP-43:
Attachment: 43-LoggerMDC.patch
> Remove size restriction of MDC table in LoggerMDC
> --
Remove size restriction of MDC table in LoggerMDC
-
Key: LOG4PHP-43
URL: https://issues.apache.org/jira/browse/LOG4PHP-43
Project: Log4php
Issue Type: Improvement
Components: Code
I think we should allow installation of log4php through the PEAR installer.
A typical installation could be:
$ sudo pear channel-discover pear.apache.org
$ sudo pear install apache/log4php
While upgrading to latest stable release would be:
$ sudo pear upgrade apache/log4php
Utilizing installa
Hi Joe,
> Could we create tags and branches so we have the following structure:
> It seems this is the favored structure for most other svn based projects
> I've used + plus it's the structure I use myself in my projects.
its already done, see this:
https://svn.apache.org/repos/asf/incubator/log4
Create phpunit tests
Key: LOG4PHP-42
URL: https://issues.apache.org/jira/browse/LOG4PHP-42
Project: Log4php
Issue Type: Improvement
Affects Versions: 2.0
Reporter: Christian Grobmeier
Fix For
Hi
Could we create tags and branches so we have the following structure:
./
branches/
tags/
trunk/
It seems this is the favored structure for most other svn based
projects I've used + plus it's the structure I use myself in my
projects.
If you need help on the project I would like to v
Author: kurdalen
Date: Tue May 5 14:33:01 2009
New Revision: 771745
URL: http://svn.apache.org/viewvc?rev=771745&view=rev
Log:
more updates to tests
Added:
incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php
- copied, changed from r771741,
incubator/log4php/trunk/src/test/
Author: kurdalen
Date: Tue May 5 14:29:17 2009
New Revision: 771742
URL: http://svn.apache.org/viewvc?rev=771742&view=rev
Log:
updated tests and one more fix related to #LOG4PHP-41
Added:
incubator/log4php/trunk/src/test/php/configurators/
incubator/log4php/trunk/src/test/php/configurat
Author: kurdalen
Date: Tue May 5 14:22:38 2009
New Revision: 771738
URL: http://svn.apache.org/viewvc?rev=771738&view=rev
Log:
updating tests
Modified:
incubator/log4php/trunk/src/test/php/or/LoggerDefaultRendererTest.php
incubator/log4php/trunk/src/test/php/or/LoggerObjectRendererTest.p
Christian Grobmeier wrote:
How can he?
We don't have any tags or branches here:
https://svn.apache.org/repos/asf/incubator/log4php/
$ svn export -r 743368
http://svn.apache.org/repos/asf/incubator/log4php/trunk
log4php-trunk-r743368
should do.
That's the latest revision before we restart
Christian Grobmeier wrote:
However, what broke? Do you have a error message?
I think the biggest problem is that lack of test cases. We really need
to improve those quickly to make a refactoring more safe.
All examples should be working fine now with the latest commit (needed 3
commits to fix
>> If major rewrites are in the making could we create a stable branch
>> meanwhile!
>
> Why not just check out the revision you would like to use? The last "stable"
> release of log4php was 0.9 many years ago.
How can he?
We don't have any tags or branches here:
https://svn.apache.org/repos/asf/
Johannes Frandsen wrote:
could we focus on committing code that doesn't break log4php
We have been doing that for quite some time now. But there has also been
a wish to clean up naming and structure. This is the time to fix it
(before we release 2.0). By bumping the version number from 0.9
Hi Joe,
> could we focus on committing code that doesn't break log4php
we have that policy :-)
However, what broke? Do you have a error message?
I think the biggest problem is that lack of test cases. We really need
to improve those quickly to make a refactoring more safe.
> If major rewrit
Author: kurdalen
Date: Tue May 5 13:52:57 2009
New Revision: 771728
URL: http://svn.apache.org/viewvc?rev=771728&view=rev
Log:
more cleanup #LOG4PHP-41
Added:
incubator/log4php/trunk/src/main/php/configurators/LoggerConfiguratorBasic.php
- copied, changed from r771577,
incubator/log4
could we focus on committing code that doesn't break log4php
I recognize that log4php never actually has been labeled as stable but
I have used it as svn external in my project for several months
without problems until today where everything starts to break.
If major rewrites are in the
Author: kurdalen
Date: Tue May 5 13:09:25 2009
New Revision: 771704
URL: http://svn.apache.org/viewvc?rev=771704&view=rev
Log:
more refactoring #LOG4PHP-41
Added:
incubator/log4php/trunk/src/main/php/LoggerConfigurator.php
- copied unchanged from r771577,
incubator/log4php/trunk/src/m
Author: kurdalen
Date: Tue May 5 12:51:53 2009
New Revision: 771701
URL: http://svn.apache.org/viewvc?rev=771701&view=rev
Log:
fixes related to #LOG4PHP-41
Added:
incubator/log4php/trunk/src/main/php/LoggerFilter.php
- copied unchanged from r771577,
incubator/log4php/trunk/src/main/ph
Author: kurdalen
Date: Tue May 5 12:48:33 2009
New Revision: 771700
URL: http://svn.apache.org/viewvc?rev=771700&view=rev
Log:
added LoggerException class
Added:
incubator/log4php/trunk/src/main/php/LoggerException.php
Added: incubator/log4php/trunk/src/main/php/LoggerException.php
URL:
ht
Author: kurdalen
Date: Tue May 5 12:44:37 2009
New Revision: 771699
URL: http://svn.apache.org/viewvc?rev=771699&view=rev
Log:
corrected inheritance after the merge
Modified:
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderDailyFile.php
Modified:
incubator/log4php/trunk/src/ma
On May 4, 2009, at 3:51 AM, Christian Grobmeier wrote:
any idea why my commit notifications come not through while Knuts
get
through the wire perfectly?
I have no idea. Quite annoying to not get notified. I had a lot of
conflicting files this morning because I'm fixing the code style
whil
Author: kurdalen
Date: Tue May 5 10:09:31 2009
New Revision: 771651
URL: http://svn.apache.org/viewvc?rev=771651&view=rev
Log:
initial version of LoggerConfiguratorPhp #LOG4PHP-36
Added:
incubator/log4php/trunk/src/main/php/configurators/
incubator/log4php/trunk/src/main/php/configurator
Christian Grobmeier wrote:
Agreed. I think a simple LoggerException with appropriate Message
inside should do all tricks we need. I don't think a
LoggerConfiguratorException is really necessary, but this is a matter
of taste.
Nothing else than that the name of the exception is more specific to
> Our prefix is "Logger". Which means we should have a LoggerException (base
> exception class for everything exception class needed in log4php) +
> LoggerConfiguratorException (for errors in configurators).
>
> I currently can't think of others. In general we should only throw
> exceptions during
Christian Grobmeier wrote:
you are reading minds. I thought the same when I was under shower this morning.
Hehe, probably one of the best places to think about open source
contributions ;)
I think too that we should introduce exceptions. Basically I don't
think we need too much exceptions.
> Yes, LoggerPropertyGetter can be removed, and we should also try to get rid
> of LoggerPropertySetter in my eyes. Utilizing __get() and __set() magic
> methods is a little nicer option in PHP 5.
OK at removing Getter. About property setter: we have several other
places in code where methods name
Christian Grobmeier wrote:
please let me know when you are doing these changes (or if) since I
would like to avoid merge conflicts :-)
It's going to happen soon (today or tomorrow).
If I've assigned the task to myself, it means that I will do it ;)
Knut
Hi,
> Currently we don't throw any exceptions in log4php, but there's a few places
> where I think it makes sense to throw an exception. In example all
> configurators should yield an exception if something the provided
> configuration is wrong.
you are reading minds. I thought the same when I wa
Hi Knut,
please let me know when you are doing these changes (or if) since I
would like to avoid merge conflicts :-)
Christian
On Tue, May 5, 2009 at 9:04 AM, Knut Urdalen (JIRA) wrote:
> Refactor class names and directory layout
> -
>
> Key
Gavin wrote:
Do you think log4php could utilise buildbot for running some tests ?
http://ci.apache.org/buildbot.html
Yes, it can, but I would prefer phpUnderControl [1] which gives us much
more tools. I would like to see all the graphs with current code
coverage, test reports, latest api do
Hi,
Do you think log4php could utilise buildbot for running some tests ?
http://ci.apache.org/buildbot.html
If so, let me know what commands you want using for the tests you want and
I'll set it up.
Cheers
Gav...
Refactor class names and directory layout
-
Key: LOG4PHP-41
URL: https://issues.apache.org/jira/browse/LOG4PHP-41
Project: Log4php
Issue Type: Improvement
Components: Code
Reporte
33 matches
Mail list logo
