Re: Moving files about

2010-09-18 Thread Christian Grobmeier
hei the root directory does not contain to much files. I currently tend to leave the files were there are because all "the api stuff" is in root, while all "the implementations" are in the subdirectories. That feels good to me. Other opinions? Cheers Christian PS: thanks ivan for the other commi

Moving files about

2010-09-18 Thread Ivan Habunek
I think it may be a good idea to move files with abstract classes and interfaces to their respective directories. i.e. move: - LoggerAppender.php to appenders - LoggerConfigurator.php to configurators - LoggerFilter.php to filters - LoggerLayout.php to layouts This would make the root directory

[jira] Resolved: (LOG4PHP-104) LoggerNDC: discuss sense and refactor

2010-09-18 Thread Ivan Habunek (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Habunek resolved LOG4PHP-104. -- Resolution: Fixed I have refactored the class to use a private variable for storage and added

svn commit: r998456 - in /logging/log4php/trunk/src: changes/changes.xml main/php/LoggerLoggingEvent.php main/php/LoggerNDC.php test/php/LoggerNDCTest.php

2010-09-18 Thread ihabunek
Author: ihabunek Date: Sat Sep 18 12:29:24 2010 New Revision: 998456 URL: http://svn.apache.org/viewvc?rev=998456&view=rev Log: LOG4PHP-104: Refactored LoggerNDC and added tests. Added: logging/log4php/trunk/src/test/php/LoggerNDCTest.php Modified: logging/log4php/trunk/src/changes/change

[jira] Updated: (LOG4PHP-104) LoggerNDC: discuss sense and refactor

2010-09-18 Thread Ivan Habunek (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Habunek updated LOG4PHP-104: - Assignee: Ivan Habunek Fix Version/s: 2.1 (was: 2.2) I think thi

[jira] Assigned: (LOG4PHP-105) LoggerMDC needs refactoring

2010-09-18 Thread Ivan Habunek (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Habunek reassigned LOG4PHP-105: Assignee: Ivan Habunek > LoggerMDC needs refactoring > --- > >

[jira] Resolved: (LOG4PHP-105) LoggerMDC needs refactoring

2010-09-18 Thread Ivan Habunek (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Habunek resolved LOG4PHP-105. -- Resolution: Fixed Committed revision 998444. > LoggerMDC needs refactoring >

[jira] Updated: (LOG4PHP-105) LoggerMDC needs refactoring

2010-09-18 Thread Ivan Habunek (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Habunek updated LOG4PHP-105: - Fix Version/s: (was: 2.3) Affects Version/s: 2.0 (was: 2.2

svn commit: r998444 - in /logging/log4php/trunk/src: changes/changes.xml main/php/LoggerMDC.php test/php/LoggerMDCTest.php

2010-09-18 Thread ihabunek
Author: ihabunek Date: Sat Sep 18 11:42:17 2010 New Revision: 998444 URL: http://svn.apache.org/viewvc?rev=998444&view=rev Log: LOG4PHP-105: LoggerMDC needs refactoring; added tests Added: logging/log4php/trunk/src/test/php/LoggerMDCTest.php Modified: logging/log4php/trunk/src/changes/cha

svn commit: r998428 - in /logging/log4php/trunk/src/main/php: LoggerAppenderPool.php LoggerHierarchy.php

2010-09-18 Thread ihabunek
Author: ihabunek Date: Sat Sep 18 09:27:49 2010 New Revision: 998428 URL: http://svn.apache.org/viewvc?rev=998428&view=rev Log: LoggerHierarchy::resetConfiguration() now clears the LoggerAppenderPool. Modified: logging/log4php/trunk/src/main/php/LoggerAppenderPool.php logging/log4php/trun

Re: [jira] Commented: (LOG4PHP-108) Add HTML line break to LoggerAppenderEcho output

2010-09-18 Thread Ivan Habunek
Hi everybody. Remember this thread? X) Well, I'm back on this problem once again. So far it has been proposed that a long term solution would be either: a) to stop using LoggerAppenderPool Personally I think we could do without it, in fact my rewrite of the XML configurator does not use an append

svn commit: r998427 - /logging/log4php/trunk/src/test/php/configurators/LoggerConfiguratorIniTest.php

2010-09-18 Thread ihabunek
Author: ihabunek Date: Sat Sep 18 09:18:13 2010 New Revision: 998427 URL: http://svn.apache.org/viewvc?rev=998427&view=rev Log: Added @expectedException to a test which causes an error to be triggered. Modified: logging/log4php/trunk/src/test/php/configurators/LoggerConfiguratorIniTest.php

Re: buildbot failure in ASF Buildbot on log4php-trunk

2010-09-18 Thread Christian Grobmeier
Wow, I thought you have killed log4php too :-) We had this error before a good while... I have meanwhile rights to do this, but i am really bad with administration. Gavin - don't know if you read this - can you advise how we solve this? Infra-ticket? Can you take a look? Cheers Christian On Sat,

Re: buildbot failure in ASF Buildbot on log4php-trunk

2010-09-18 Thread Ivan Habunek
Hm, I thought I messed something up with the last commit, but it seems I'm not to blame. :) Looks like xdebug failed to load because of version mismatch with zend engine api. Can we update xdebug on buildbot? Regards, Ivan P.S. Here's the bit of log which shows it: [INFO] Executing tasks [m

buildbot failure in ASF Buildbot on log4php-trunk

2010-09-18 Thread buildbot
The Buildbot has detected a new failure of log4php-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/log4php-trunk/builds/15 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: ceres_ubuntu Build Reason: Build Source Stamp: [branch logging/log4php/t

svn commit: r998420 - in /logging/log4php/trunk/src: changes/changes.xml main/php/LoggerLevel.php main/php/layouts/LoggerLayoutHtml.php main/php/layouts/LoggerLayoutSimple.php main/php/layouts/LoggerL

2010-09-18 Thread ihabunek
Author: ihabunek Date: Sat Sep 18 07:46:03 2010 New Revision: 998420 URL: http://svn.apache.org/viewvc?rev=998420&view=rev Log: Added __toString magic method to LoggerLevel. Modified: logging/log4php/trunk/src/changes/changes.xml logging/log4php/trunk/src/main/php/LoggerLevel.php logg