On Jul 14, 2007, at 1:52 AM, Knut Urdalen wrote:
Hi all,
I've just submitted the initial code for the PHP 5 port [1].
svn checkout http://svn.apache.org/repos/asf/incubator/log4php
The code can currently be found in src/php5/*
This revision contains:
- working code for most appenders
- an examples folder [2] with working examples (go to the folder
and run any PHP file with the CLI)
- some unit tests using PHPUnit 3 (go to src/php5/tests and run
"phpunit AllTests.php" add "--report=coverage" if you have xdebug
installed to get a nice code coverage report)
- a TODO-list [3] with a lot of tasks to choose from (feel free to
grab one or more tasks - just inform us here on the mailing list
and we'll help you out)
This is our starting point for the PHP 5 port. Please start testing
this version in your environment to see if it works as expected.
Any feedback is appreciated!
Best regards,
Knut Urdalen
[1] http://svn.apache.org/viewvc?view=rev&revision=556231
[2] http://svn.apache.org/viewvc/incubator/log4php/trunk/src/php5/
examples/
[3] http://svn.apache.org/viewvc/incubator/log4php/trunk/src/php5/
TODO?view=markup
I do not know why log4php was still showing up in the https://
svn.apache.org/repos/asf/logging. I thought I had svn mv'd it, but
if I inadvertently svn cp'd it, I've not svn rm'd the original in rev
556719.
Subversion will generate a commit email message on changes and send
it to log4php-dev. Unfortunately, since Knut was not subscribed to
log4php-dev as [EMAIL PROTECTED], the message was rejected as
spam. I've forcibly subscribed the log4php committers to log4php-dev-
allow (a list consulted to determine if messages should be accept
using the @apache.org addresses), so hopefully any subsequent commit
messages will get through even if you are not subscribed to log4php-
dev using your @apache.org address.
Rev 556231 lost the revision history since files were file system
copied from src/log4php to src/php5/log4php and then committed as
brand new files apparently. It would
have been preferable to svn cp or svn mv the PHP 4 files and then
apply the PHP 5 changes. I've going to shortly commit a rebuilt
log4php source code in src/main/php by moving src/log4php (the
current PHP 4 source code) and then apply a patch that updates that
source to be identical (other than whitespace) to src/php5/log4php.
There were a lot of whitespace changes which I assume are
unnecessary. If the whitespace changes are necessary, then it would
be better to commit the non-whitespace changes and then run a code
formatter on the whole lot.
@author tags are discouraged in ASF code (http://www.apache.org/
foundation/records/minutes/2004/board_minutes_2004_09_22.txt, perhaps
there is a better reference), but there hasn't been any effort to
remove them in LS code. I did see that Knut added author tags, maybe
it would be better to start removing the ones that are there instead
of adding new ones.
