[logback-dev] [JIRA] (LOGBACK-1205) CheckForCollisions methods can cause performance issue

[QOS.CH (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Artem Yermakov commented on  LOGBACK-1205  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: CheckForCollisions methods can cause performance issue   
 

  
 
 
 
 

 
 Looks like the suggested patch was applied when fixing LOGBACK-1167 (included to 1.2.3 release). Maybe this issue can be closed?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)  
 
 

 
   
 

  
 

  
 

   

___
logback-dev mailing list
logback-dev@qos.ch
http://mailman.qos.ch/mailman/listinfo/logback-dev

[logback-dev] [JIRA] (LOGBACK-1205) CheckForCollisions methods can cause performance issue

[Igor Vagulin (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Igor Vagulin commented on  LOGBACK-1205 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: CheckForCollisions methods can cause performance issue  
 
 
 
 
 
 
 
 
 
 
Have similar problem. Patch fixing issue for me 
diff --git a/logback-core/src/main/java/ch/qos/logback/core/FileAppender.java b/logback-core/src/main/java/ch/qos/logback/core/FileAppender.java index cdc5d25..32673c1 100644 — a/logback-core/src/main/java/ch/qos/logback/core/FileAppender.java +++ b/logback-core/src/main/java/ch/qos/logback/core/FileAppender.java @@ -256,4 +256,12 @@ public class FileAppender extends OutputStreamAppender  { super.writeOut(event); } 
 } +  + @Override + public void stop() { + @SuppressWarnings("unchecked") + Map map = (Map) context.getObject(CoreConstants.RFA_FILENAME_PATTERN_COLLISION_MAP); + map.remove(getName()); + super.stop(); + } 
 } 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   

___
logback-dev mailing list
logback-dev@qos.ch
http://mailman.qos.ch/mailman/listinfo/logback-dev