Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-20 Thread bruno . decraene
Barry, Les > From: Barry Leiba > Sent: Saturday, March 16, 2024 1:05 AM > > Indeed; given the explanation and the fact that it's copied from otherwise > existing text, I think Les is right: just leave it as is, and thanks for > considering and discussing my question. Thanks for your commen

Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-15 Thread Barry Leiba
Indeed; given the explanation and the fact that it's copied from otherwise existing text, I think Les is right: just leave it as is, and thanks for considering and discussing my question. Barry On Sat, Mar 16, 2024 at 6:00 AM Les Ginsberg (ginsberg) wrote: > > Bruno - > > Inline. > > > -Orig

Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-15 Thread Les Ginsberg (ginsberg)
Bruno - Inline. > -Original Message- > From: bruno.decra...@orange.com > Sent: Friday, March 15, 2024 11:17 AM > To: Les Ginsberg (ginsberg) ; Barry Leiba > > Cc: draft-ietf-lsr-isis-fast-flooding@ietf.org; last-c...@ietf.org; > lsr@ietf.org; > sec...@ietf.org > Subject: RE: Secdir

Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-15 Thread bruno . decraene
Les, Barry, > From: Les Ginsberg (ginsberg) > Sent: Friday, March 15, 2024 4:29 PM > > Bruno/Barry - > > In regards to: > > > > — Section 4.4 — > > > > >> Length: Indicates the length in octets (1-8) of the Value field. The > >> length SHOULD be the minimum required to send all bits

Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-15 Thread Les Ginsberg (ginsberg)
Bruno/Barry - In regards to: > > — Section 4.4 — > > >> Length: Indicates the length in octets (1-8) of the Value field. The >> length SHOULD be the minimum required to send all bits that are set. > > > > The SHOULD seems very odd: what would be a good reason to make it > longer than nec

Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-15 Thread bruno . decraene
Hi Barry, Thanks for your review, comments and proposed resolution. Much appreciated. Please see inline [Bruno] > From: Barry Leiba via Datatracker > Sent: Thursday, March 14, 2024 6:21 AM > To: sec...@ietf.org > Cc: draft-ietf-lsr-isis-fast-flooding@ietf.org; last-c...@ietf.org; > lsr

[Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-13 Thread Barry Leiba via Datatracker
Reviewer: Barry Leiba Review result: Has Issues Only some minor things here: — Section 3 — Although modern implementations have not strictly adhered to the 33 millisecond interval, it is commonplace for implementations to limit the flooding rate to the same order of magnitude similar as